You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xianglyc (via GitHub)" <gi...@apache.org> on 2024/10/09 08:35:49 UTC

[PR] arch/x86_64:Add allsymbol functionality [nuttx]

xianglyc opened a new pull request, #13980:
URL: https://github.com/apache/nuttx/pull/13980

   ## Summary
   Add allsymbol functionality
   ## Impact
   no impact
   ## Testing
   open backtrace and then when the crash occurs, you can see the symbols.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/x86_64:Add allsymbol functionality [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #13980:
URL: https://github.com/apache/nuttx/pull/13980


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/x86_64:Add allsymbol functionality [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #13980:
URL: https://github.com/apache/nuttx/pull/13980#issuecomment-2402547311

   @xianglyc please fix the ci error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arch/x86_64:Add allsymbol functionality [nuttx]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #13980:
URL: https://github.com/apache/nuttx/pull/13980#issuecomment-2401724607

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   This Pull Request description **does not meet** the NuttX requirements. Here's why:
   
   **Missing Information:**
   
   * **Summary:** 
       * Lacks a clear explanation of why the "allsymbol" functionality is necessary. Is it a fix, update, or new feature?  What problem does it solve?
       * Doesn't describe what functional part of the code is affected.
       * Needs a better explanation of how the change works. What does "allsymbol" do? How does it make symbols visible in backtraces?
       * No mention of related issues in NuttX or NuttX Apps.
   * **Impact:**
       * While stating "no impact," the description doesn't address all the points. Does this change affect any of the following:
           * Build process?
           * Hardware architectures, boards, or drivers?
           * Documentation (does this feature need to be documented)?
           * Security (are there any security implications)?
           * Compatibility with previous NuttX versions? 
   * **Testing:**
       *  The testing section is very vague. It should include:
           * **Specifics about the build host:** OS, CPU architecture, compiler (including version), and any other relevant details.
           * **Details about the target platform:** Architecture (simulator or real hardware), the specific board and its configuration. 
           * **Actual testing logs:**  Instead of just saying "your testing logs here," provide the real logs from before and after the change. 
   
   **How to Improve the PR Description:**
   
   1. **Be Specific:**  Provide concrete details about the change and its effects.
   2. **Address All Requirements:**  Go through each point in the NuttX requirements and make sure your description covers it.
   3. **Show, Don't Tell:**  Use testing logs and clear explanations to demonstrate the change's impact and functionality. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org