[GitHub] [pulsar] lhotari commented on pull request #16622: Skip topics with remote replication producers in topic inactivity check

[GitBox <gi...@apache.org>]

lhotari commented on PR #16622:
URL: https://github.com/apache/pulsar/pull/16622#issuecomment-1186106379

   > Question:
   > 
   > 1. Do you mean we will delete the topic at the second GC check?
   
   please see how the existing code works in https://github.com/apache/pulsar/blob/c48a3243287c7d775459b6437d9f4b24ed44cf4c/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L2182-L2231 . The existing logic closes replicators that contain no backlog. However if there are connected replication producers, the inactivity deletion will be skipped eventually and it's possible that some replicators were already closed and they won't be restored. This is why this PR is made since it's better to make the check as the first step instead of possibly closing some replicators and then terminating the inactivity deletion.
   
   > 2. I'm not sure If it's a breaking change for the user. Maybe we need to notice this change?
   
   This PR doesn't introduce a breaking change.
   
   > 3. This will cause the broker to have a large number of unused producers, right?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org