[GitHub] [couchdb] ecerulm opened a new pull request, #4561: Clarify encoding length in performance.rst

["ecerulm (via GitHub)" <gi...@apache.org>]

ecerulm opened a new pull request, #4561:
URL: https://github.com/apache/couchdb/pull/4561

   
   
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   The original text  in the [documentation](https://docs.couchdb.org/en/stable/maintenance/performance.html#document-s-id) said that something that takes 16 hex digits can be represented with just 4 digits (in an hypothetical base62 encoding).
   
   I believe that was a typo since 16 hex digits encode a 8-byte sequence that will require (8/3)*4 = 11 digits in base64 (without padding).
   
   So I fixed the typo, and took the liberty of rephrasing it to be more clear, and reference to `base64url` encoding 
   instead of base62 (since it's a base64url is a well known encoding)
   
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provide any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affect multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] Documentation changes were made in the `src/docs` folder
   - [ ] Documentation changes were backported (separated PR) to affected branches
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva merged pull request #4561: Clarify encoding length in performance.rst

["nickva (via GitHub)" <gi...@apache.org>]

nickva merged PR #4561:
URL: https://github.com/apache/couchdb/pull/4561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org