You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ryan Baxter (Created) (JIRA)" <ji...@apache.org> on 2012/04/18 16:39:36 UTC
[jira] [Created] (SHINDIG-1752) When the property
gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the
default post size ends up being 0 instead of using the default value
When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value
------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: SHINDIG-1752
URL: https://issues.apache.org/jira/browse/SHINDIG-1752
Project: Shindig
Issue Type: Bug
Affects Versions: 2.5.0
Reporter: Ryan Baxter
If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1752) When the property
gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the
default post size ends up being 0 instead of using the default value
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256670#comment-13256670 ]
jiraposter@reviews.apache.org commented on SHINDIG-1752:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4789/#review7006
-----------------------------------------------------------
Ship it!
+1
- Stanton
On 2012-04-18 14:54:36, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4789/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-18 14:54:36)
bq.
bq.
bq. Review request for shindig and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
bq.
bq.
bq. This addresses bug SHINDIG-1752.
bq. https://issues.apache.org/jira/browse/SHINDIG-1752
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1326802
bq.
bq. Diff: https://reviews.apache.org/r/4789/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1752
> URL: https://issues.apache.org/jira/browse/SHINDIG-1752
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1752) When the property
gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the
default post size ends up being 0 instead of using the default value
Posted by "Ryan Baxter (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter resolved SHINDIG-1752.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.5.0
Committed revision 1327569
> When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1752
> URL: https://issues.apache.org/jira/browse/SHINDIG-1752
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Fix For: 2.5.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1752) When the property
gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the
default post size ends up being 0 instead of using the default value
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256619#comment-13256619 ]
jiraposter@reviews.apache.org commented on SHINDIG-1752:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4789/
-----------------------------------------------------------
Review request for shindig and Dan Dumont.
Summary
-------
If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
This addresses bug SHINDIG-1752.
https://issues.apache.org/jira/browse/SHINDIG-1752
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1326802
Diff: https://reviews.apache.org/r/4789/diff
Testing
-------
Ran unit tests
Thanks,
Ryan
> When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1752
> URL: https://issues.apache.org/jira/browse/SHINDIG-1752
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1752) When the property
gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the
default post size ends up being 0 instead of using the default value
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256637#comment-13256637 ]
jiraposter@reviews.apache.org commented on SHINDIG-1752:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4789/#review7005
-----------------------------------------------------------
Ship it!
LGTM, thanks for fixing this.
- Dan
On 2012-04-18 14:54:36, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4789/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-18 14:54:36)
bq.
bq.
bq. Review request for shindig and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
bq.
bq.
bq. This addresses bug SHINDIG-1752.
bq. https://issues.apache.org/jira/browse/SHINDIG-1752
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1326802
bq.
bq. Diff: https://reviews.apache.org/r/4789/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1752
> URL: https://issues.apache.org/jira/browse/SHINDIG-1752
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1752) When the property
gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the
default post size ends up being 0 instead of using the default value
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1752:
---------------------------------
Fix Version/s: (was: 2.5.0)
2.5.0-beta2
> When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1752
> URL: https://issues.apache.org/jira/browse/SHINDIG-1752
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Fix For: 2.5.0-beta2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1752) When the property
gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the
default post size ends up being 0 instead of using the default value
Posted by "Ryan Baxter (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter closed SHINDIG-1752.
--------------------------------
Committed revision 1327569
> When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1752
> URL: https://issues.apache.org/jira/browse/SHINDIG-1752
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Fix For: 2.5.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SHINDIG-1752) When the property
gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the
default post size ends up being 0 instead of using the default value
Posted by "Ryan Baxter (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter reassigned SHINDIG-1752:
------------------------------------
Assignee: Ryan Baxter
> When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1752
> URL: https://issues.apache.org/jira/browse/SHINDIG-1752
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1752) When the property
gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the
default post size ends up being 0 instead of using the default value
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256685#comment-13256685 ]
jiraposter@reviews.apache.org commented on SHINDIG-1752:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4789/#review7007
-----------------------------------------------------------
Committed revision 1327569
- Ryan
On 2012-04-18 14:54:36, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4789/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-18 14:54:36)
bq.
bq.
bq. Review request for shindig and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
bq.
bq.
bq. This addresses bug SHINDIG-1752.
bq. https://issues.apache.org/jira/browse/SHINDIG-1752
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1326802
bq.
bq. Diff: https://reviews.apache.org/r/4789/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1752
> URL: https://issues.apache.org/jira/browse/SHINDIG-1752
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Fix For: 2.5.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira