You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/28 08:22:41 UTC
[GitHub] [trafficserver] tomoatan opened a new pull request #8182: Revert "Remove UnixNetVConnection::startEvent - not actually called."
tomoatan opened a new pull request #8182:
URL: https://github.com/apache/trafficserver/pull/8182
Reverts #7596
In #7596, UnixNetVConnection::startEvent was removed but it's necessary in UnixNetProcessor::connect_re_internal.
In the following code, UnixNetVConnection is scheduled if some mutexes can't be locked.
https://github.com/apache/trafficserver/blob/84cf02e6d87377d68cce8f687f6c001bc43aea47/iocore/net/UnixNetProcessor.cc#L240-L254
In this case, UnixNetVConnection::startEvent is appropriate as a handler
because UnixNetVConnection is scheduled to execute UnixNetVConnection::connectUp.
Before #7596, UnixNetVConnection::startEvent was set as a handler in constructor, so I revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8182: Revert "Remove UnixNetVConnection::startEvent - not actually called."
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8182:
URL: https://github.com/apache/trafficserver/pull/8182#issuecomment-888643537
I’m on PTO and away from my computer right now. But I see that clang analyzer fails with this. @SolidWallOfCode and I looked at the report a few months ago and that’s why we initially removed this code (to address it). We convinced ourselves that it was not called. But apparently this code can’t be removed. We’ll have to figure out how to fix the analyzer issue another way apparently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8182: Revert "Remove UnixNetVConnection::startEvent - not actually called."
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8182:
URL: https://github.com/apache/trafficserver/pull/8182#issuecomment-890606095
#8184 has the commit from @tomoatan and the clang-analyzer fix. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 closed pull request #8182: Revert "Remove UnixNetVConnection::startEvent - not actually called."
Posted by GitBox <gi...@apache.org>.
masaori335 closed pull request #8182:
URL: https://github.com/apache/trafficserver/pull/8182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8182: Revert "Remove UnixNetVConnection::startEvent - not actually called."
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8182:
URL: https://github.com/apache/trafficserver/pull/8182#issuecomment-888615328
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 edited a comment on pull request #8182: Revert "Remove UnixNetVConnection::startEvent - not actually called."
Posted by GitBox <gi...@apache.org>.
masaori335 edited a comment on pull request #8182:
URL: https://github.com/apache/trafficserver/pull/8182#issuecomment-890606095
Unfortunately, we can't merge this PR because of clang-analyzer build failure.
#8184 has the commit from @tomoatan and the clang-analyzer fix. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org