You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "KesharwaniArpita (via GitHub)" <gi...@apache.org> on 2023/11/20 14:49:02 UTC

[PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

KesharwaniArpita opened a new pull request, #897:
URL: https://github.com/apache/airflow-site/pull/897

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1842913022

   I think this output of the CI explains everything. I would have to literally copy what it says if you want instructions :)
   
   It's there precisely to instruct people what to do


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1837427718

   https://github.com/apache/airflow-site/actions/runs/7075369981/job/19258840711?pr=897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1841352741

   Well. You do realize you need to run pre-commit and apply the change though :) ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1842910897

   ![image](https://github.com/apache/airflow-site/assets/595491/530d3c23-08c1-4055-b037-d2f21b2bfd45)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1819306207

   This should be generated automtatically. We hve pre-commit for that in apache-airflow - so we should copy the pre-commit from there and generate the TOC automatically with it - this way it will be always "fresh"
   
   https://github.com/apache/airflow/blob/main/.pre-commit-config.yaml#L30


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #897: Added table of content in CONTRIBUTE.md and enhanced the documentation.
URL: https://github.com/apache/airflow-site/pull/897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1842909424

   `I did. I run the pre-commit run --all-files as mentioned in the [file](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#id3). Is there anything else I need to do?
   I would really appreciate it if you could tell me.
   `
   
   Well it does not look like because the same thing in CI produced different result. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1823459056

   +1 for auto generated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1837427512

   You also need to actually use the pre-commit to generate the content :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1837427568

   And remove the one added by hand


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

Posted by "KesharwaniArpita (via GitHub)" <gi...@apache.org>.
KesharwaniArpita commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1842877259

   > Well. You do realize you need to run pre-commit and apply the change though :) ?
   
   I did. I run the `pre-commit run --all-files` as mentioned in the [file](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#id3). Is there anything else I need to do?
   I would really appreciate it if you could tell me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org