You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/06/14 19:22:44 UTC
[GitHub] [cloudstack-terraform-provider] Damans227 opened a new pull request, #38: Adding new data sources to cloudstack-terraform-proivder
Damans227 opened a new pull request, #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38
Hi @Pearl1594 and @harikrishna-patnala This PR is a continuation of PR: https://github.com/apache/cloudstack-terraform-provider/pull/34. In order to keep everything organized, I renamed the `AddInstanceDataSource` branch to `AddNewDataSources`. Hence, this new PR is needed. I will close the old PR and continue adding additional data sources to this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud merged pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on a diff in pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
Damans227 commented on code in PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#discussion_r903147546
##########
cloudstack/data_source_cloudstack_network_offering_test.go:
##########
@@ -0,0 +1,65 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package cloudstack
+
+import (
+ "testing"
+
+ "github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccNetworkOfferingDataSource_basic(t *testing.T) {
+ resourceName := "cloudstack_network_offering.net-off-resource"
+ datasourceName := "data.cloudstack_network_offering.net-off-data-source"
+
+ resource.Test(t, resource.TestCase{
+ PreCheck: func() { testAccPreCheck(t) },
+ Providers: testAccProviders,
+ Steps: []resource.TestStep{
+ {
+ Config: testNetworkOfferingDataSourceConfig_basic,
+ Check: resource.ComposeTestCheckFunc(
+ resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
+ ),
+ ExpectNonEmptyPlan: true,
+ },
+ },
+ })
+}
+
Review Comment:
```
❯ TF_ACC=1 go test -run TestAccNetworkOfferingDataSource_basic -v
=== RUN TestAccNetworkOfferingDataSource_basic
--- PASS: TestAccNetworkOfferingDataSource_basic (0.26s)
PASS
ok
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on a diff in pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
Damans227 commented on code in PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#discussion_r918379906
##########
cloudstack/data_source_cloudstack_zone_test.go:
##########
@@ -0,0 +1,66 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package cloudstack
+
+import (
+ "testing"
+
+ "github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccZoneDataSource_basic(t *testing.T) {
+ resourceName := "cloudstack_zone.zone-resource"
+ datasourceName := "data.cloudstack_zone.zone-data-source"
+
+ resource.Test(t, resource.TestCase{
+ PreCheck: func() { testAccPreCheck(t) },
+ Providers: testAccProviders,
+ Steps: []resource.TestStep{
+ {
+ Config: testZoneDataSourceConfig_basic,
+ Check: resource.ComposeTestCheckFunc(
+ resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
+ ),
+ ExpectNonEmptyPlan: true,
+ },
+ },
+ })
+}
+
Review Comment:
```
❯ TF_ACC=1 go test -run TestAccZoneDataSource_basic -v
=== RUN TestAccZoneDataSource_basic
--- PASS: TestAccZoneDataSource_basic (0.29s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 0.302s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on a diff in pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
Damans227 commented on code in PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#discussion_r897347394
##########
cloudstack/data_source_cloudstack_ssh_keypair_test.go:
##########
@@ -0,0 +1,62 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package cloudstack
+
+import (
+ "testing"
+
+ "github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccSshKeyPairDataSource_basic(t *testing.T) {
+ resourceName := "cloudstack_ssh_keypair.ssh-keypair-resource"
+ datasourceName := "data.cloudstack_ssh_keypair.ssh-keypair-data"
+
+ resource.Test(t, resource.TestCase{
+ PreCheck: func() { testAccPreCheck(t) },
+ Providers: testAccProviders,
+ Steps: []resource.TestStep{
+ {
+ Config: testAccSshKeyPairDataSourceConfig_basic,
+ Check: resource.ComposeTestCheckFunc(
+ resource.TestCheckResourceAttrPair(datasourceName, "id", resourceName, "id"),
+ ),
+ ExpectNonEmptyPlan: true,
+ },
+ },
+ })
+}
+
Review Comment:
```
❯ TF_ACC=1 go test -run TestAccSshKeyPairDataSource_basic -v
=== RUN TestAccSshKeyPairDataSource_basic
--- PASS: TestAccSshKeyPairDataSource_basic (0.21s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 0.217s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on a diff in pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
Damans227 commented on code in PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#discussion_r956750408
##########
cloudstack/data_source_cloudstack_vpc_test.go:
##########
@@ -0,0 +1,72 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package cloudstack
+
+import (
+ "testing"
+
+ "github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccVPCDataSource_basic(t *testing.T) {
+ resourceName := "cloudstack_vpc.vpc-resource"
+ datasourceName := "data.cloudstack_vpc.vpc-data-source"
+
+ resource.Test(t, resource.TestCase{
+ PreCheck: func() { testAccPreCheck(t) },
+ Providers: testAccProviders,
+ Steps: []resource.TestStep{
+ {
+ Config: testVPCDataSourceConfig_basic,
+ Check: resource.ComposeTestCheckFunc(
+ resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
+ ),
+ ExpectNonEmptyPlan: true,
+ },
+ },
+ })
+}
+
Review Comment:
```
❯ TF_ACC=1 go test -run TestAccVPCDataSource_basic -v
=== RUN TestAccVPCDataSource_basic
--- PASS: TestAccVPCDataSource_basic (31.61s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 31.617s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
Damans227 commented on PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#issuecomment-1241369010
> Hi @Damans227 can you advise if this is ready for review and testing or you're still working on it?
Hello @rohityadavcloud, this PR is ready to be reviewed and tested as per the timeline agreed upon in my GSoC proposal.
I am actually ahead of schedule because after the final evaluation, I am supposed to request an extension to add new resources and corresponding data sources, which I have already begun.
Looping in @Pearl1594 and @harikrishna-patnala. Lemme know what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#issuecomment-1521625003
Thanks for the review and merge and guys, @kiranchavala @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on a diff in pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
Damans227 commented on code in PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#discussion_r956753748
##########
cloudstack/data_source_cloudstack_user_test.go:
##########
@@ -0,0 +1,70 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package cloudstack
+
+import (
+ "testing"
+
+ "github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccUserDataSource_basic(t *testing.T) {
+ resourceName := "cloudstack_user.user-resource"
+ datasourceName := "data.cloudstack_user.user-data-source"
+
+ resource.Test(t, resource.TestCase{
+ PreCheck: func() { testAccPreCheck(t) },
+ Providers: testAccProviders,
+ Steps: []resource.TestStep{
+ {
+ Config: testUserDataSourceConfig_basic,
+ Check: resource.ComposeTestCheckFunc(
+ resource.TestCheckResourceAttrPair(datasourceName, "first_name", resourceName, "first_name"),
+ ),
+ ExpectNonEmptyPlan: true,
+ },
+ },
+ })
+}
+
Review Comment:
```
❯ TF_ACC=1 go test -run TestAccUserDataSource_basic -v
=== RUN TestAccUserDataSource_basic
--- PASS: TestAccUserDataSource_basic (0.34s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 0.349s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on a diff in pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
Damans227 commented on code in PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#discussion_r946228221
##########
cloudstack/data_source_cloudstack_volume_test.go:
##########
@@ -0,0 +1,63 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package cloudstack
+
+import (
+ "testing"
+
+ "github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccVolumeDataSource_basic(t *testing.T) {
+ resourceName := "cloudstack_volume.volume-resource"
+ datasourceName := "data.cloudstack_volume.volume-data-source"
+
+ resource.Test(t, resource.TestCase{
+ PreCheck: func() { testAccPreCheck(t) },
+ Providers: testAccProviders,
+ Steps: []resource.TestStep{
+ {
+ Config: testVolumeDataSourceConfig_basic,
+ Check: resource.ComposeTestCheckFunc(
+ resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
+ ),
+ ExpectNonEmptyPlan: true,
+ },
+ },
+ })
+}
+
Review Comment:
```
❯ TF_ACC=1 go test -run TestAccVolumeDataSource_basic -v
=== RUN TestAccVolumeDataSource_basic
--- PASS: TestAccVolumeDataSource_basic (1.35s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 1.360s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
Damans227 commented on PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#issuecomment-1241372987
> > Hi @Damans227 can you advise if this is ready for review and testing or you're still working on it?
>
> Hello @rohityadavcloud, this PR is ready to be reviewed and tested as per the timeline agreed upon in my GSoC proposal.
>
> I am actually ahead of schedule because after the final evaluation, I am supposed to request an extension to add new resources and corresponding data sources, which I have already begun.
>
> Looping in @Pearl1594 and @harikrishna-patnala. Lemme know what do you think.
I believe it would be best to finalize this PR and then work on the extended scope of the project in a separate PR after final evaluation. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on a diff in pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
Damans227 commented on code in PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#discussion_r924823597
##########
cloudstack/data_source_cloudstack_service_offering_test.go:
##########
@@ -0,0 +1,62 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package cloudstack
+
+import (
+ "testing"
+
+ "github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccServiceOfferingDataSource_basic(t *testing.T) {
+ resourceName := "cloudstack_service_offering.service-offering-resource"
+ datasourceName := "cloudstack_service_offering.service-offering-data-source"
+
+ resource.Test(t, resource.TestCase{
+ PreCheck: func() { testAccPreCheck(t) },
+ Providers: testAccProviders,
+ Steps: []resource.TestStep{
+ {
+ Config: testServiceOfferingDataSourceConfig_basic,
+ Check: resource.ComposeTestCheckFunc(
+ resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
+ ),
+ ExpectNonEmptyPlan: true,
+ },
+ },
+ })
+}
+
Review Comment:
```
❯ TF_ACC=1 go test -run TestAccNetworkOfferingDataSource_basic -v
=== RUN TestAccNetworkOfferingDataSource_basic
--- PASS: TestAccNetworkOfferingDataSource_basic (0.27s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 0.273s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on a diff in pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
Damans227 commented on code in PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#discussion_r956752303
##########
cloudstack/data_source_cloudstack_ipaddress_test.go:
##########
@@ -0,0 +1,65 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package cloudstack
+
+import (
+ "testing"
+
+ "github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccIPAddressDataSource_basic(t *testing.T) {
+ resourceName := "cloudstack_ipaddress.ipaddress-resource"
+ datasourceName := "data.cloudstack_ipaddress.ipaddress-data-source"
+
+ resource.Test(t, resource.TestCase{
+ PreCheck: func() { testAccPreCheck(t) },
+ Providers: testAccProviders,
+ Steps: []resource.TestStep{
+ {
+ Config: testIPAddressDataSourceConfig_basic,
+ Check: resource.ComposeTestCheckFunc(
+ resource.TestCheckResourceAttrPair(datasourceName, "zone_name", resourceName, "zone"),
+ ),
+ ExpectNonEmptyPlan: true,
+ },
+ },
+ })
+}
+
Review Comment:
```
❯ TF_ACC=1 go test -run TestAccIPAddressDataSource_basic -v
=== RUN TestAccIPAddressDataSource_basic
--- PASS: TestAccIPAddressDataSource_basic (2.38s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 2.390s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#issuecomment-1240361284
Hi @Damans227 can you advise if this is ready for review and testing or you're still working on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#issuecomment-1243007677
Thanks for the update @Damans227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] Damans227 commented on pull request #38: Adding new data sources to cloudstack-terraform-proivder
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on PR #38:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#issuecomment-1521626096
Thanks for the review and merge, @kiranchavala @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org