You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mi...@apache.org on 2016/10/25 06:05:22 UTC
zeppelin git commit: [MINOR] remove comments in NotebookRestApi.java
Repository: zeppelin
Updated Branches:
refs/heads/master 4f6a0e34f -> 0dd04d528
[MINOR] remove comments in NotebookRestApi.java
### What is this PR for?
Since ZEPPELIN-1162 (PR #1341) has been solved, we should remove TODO comments correspondingly.
### What type of PR is it?
Minor
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Kai Jiang <ji...@gmail.com>
Closes #1556 from vectorijk/minor-remove-comments and squashes the following commits:
1e8ce8a [Kai Jiang] remove TODO comments since 1162 has been solved
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/0dd04d52
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/0dd04d52
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/0dd04d52
Branch: refs/heads/master
Commit: 0dd04d52844f1f6c8100e148f8de9274628df3fc
Parents: 4f6a0e3
Author: Kai Jiang <ji...@gmail.com>
Authored: Sun Oct 23 20:23:01 2016 -0700
Committer: Mina Lee <mi...@apache.org>
Committed: Tue Oct 25 15:05:14 2016 +0900
----------------------------------------------------------------------
.../src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java | 4 ----
1 file changed, 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/0dd04d52/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java
index d429d08..ae66330 100644
--- a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java
+++ b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java
@@ -113,10 +113,6 @@ public class NotebookRestApi {
@ZeppelinApi
public Response putNotePermissions(@PathParam("noteId") String noteId, String req)
throws IOException {
- /**
- * TODO(jl): Fixed the type of HashSet
- * https://issues.apache.org/jira/browse/ZEPPELIN-1162
- */
HashMap<String, HashSet<String>> permMap =
gson.fromJson(req, new TypeToken<HashMap<String, HashSet<String>>>() {
}.getType());