You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/05 16:13:34 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request #8042: Remove ShardingSphereSchema.dataSourcesMetaData
terrymanu opened a new pull request #8042:
URL: https://github.com/apache/shardingsphere/pull/8042
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8042: Remove ShardingSphereSchema.dataSourcesMetaData
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8042:
URL: https://github.com/apache/shardingsphere/pull/8042#issuecomment-722771863
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=h1) Report
> Merging [#8042](https://codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/37651f3aca8e05042be192ce7a08bbaa31fee6d8?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `81.25%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8042/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8042 +/- ##
============================================
- Coverage 75.12% 75.12% -0.01%
Complexity 547 547
============================================
Files 1447 1447
Lines 22701 22704 +3
Branches 4049 4049
============================================
+ Hits 17055 17057 +2
Misses 4545 4545
- Partials 1101 1102 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ource/metadata/ShardingSphereDatabaseMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvZGF0YXNvdXJjZS9tZXRhZGF0YS9TaGFyZGluZ1NwaGVyZURhdGFiYXNlTWV0YURhdGEuamF2YQ==) | `89.65% <33.33%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../route/engine/type/ShardingRouteEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL1NoYXJkaW5nUm91dGVFbmdpbmVGYWN0b3J5LmphdmE=) | `75.51% <90.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...phere/sharding/route/engine/ShardingSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9TaGFyZGluZ1NRTFJvdXRlci5qYXZh) | `77.41% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...nance/context/schema/GovernanceSchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC9zY2hlbWEvR292ZXJuYW5jZVNjaGVtYUNvbnRleHRzLmphdmE=) | `92.53% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/infra/context/schema/SchemaContextsBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9zY2hlbWEvU2NoZW1hQ29udGV4dHNCdWlsZGVyLmphdmE=) | `95.34% <100.00%> (-0.11%)` | `0.00 <0.00> (ø)` | |
| [...phere/ha/route/engine/impl/HADataSourceRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3JvdXRlL2VuZ2luZS9pbXBsL0hBRGF0YVNvdXJjZVJvdXRlci5qYXZh) | `66.66% <0.00%> (-16.67%)` | `0.00% <0.00%> (ø%)` | |
| [...pache/shardingsphere/ha/rule/HADataSourceRule.java](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS9ydWxlL0hBRGF0YVNvdXJjZVJ1bGUuamF2YQ==) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...config/rule/YamlHADataSourceRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS95YW1sL2NvbmZpZy9ydWxlL1lhbWxIQURhdGFTb3VyY2VSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...g/namespace/parser/HARuleBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWhhLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL0hBUnVsZUJlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
| [...RuleAlgorithmProviderConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS95YW1sL3N3YXBwZXIvSEFSdWxlQWxnb3JpdGhtUHJvdmlkZXJDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `96.15% <0.00%> (+0.15%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1 more](https://codecov.io/gh/apache/shardingsphere/pull/8042/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=footer). Last update [37651f3...970e3cb](https://codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #8042: Remove ShardingSphereSchema.dataSourcesMetaData
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #8042:
URL: https://github.com/apache/shardingsphere/pull/8042
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org