[jira] Commented: (MYFACES-52) Difference between image attribute of commandButton and url attribute of graphicImage on render

["Han Lee (JIRA)" <in...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/MYFACES-52?page=comments#action_58853 ]
     
Han Lee commented on MYFACES-52:
--------------------------------

This seems like a bigger problem with the handling of contextRoot. The myfaces/src/share/net/sourceforge/myfaces/renderkit/html/HtmlButtonRendererBase.java component passes the taglib's image field directly to the page. It should prepend the webapp's contextRoot and encode the URL. I've fixed the problem with this bit of code (replacing the "if image != null" block around line 257):

if (image != null)
{
    String imageUrl = facesContext.getApplication()
                        .getViewHandler().getResourceURL(facesContext,
                        image);
    writer.writeAttribute(HTML.TYPE_ATTR, HTML.INPUT_TYPE_IMAGE, null);
    writer.writeAttribute(HTML.SRC_ATTR,
        facesContext.getExternalContext().encodeResourceURL(imageUrl), 
        JSFAttr.IMAGE_ATTR);
}


> Difference between image attribute of commandButton and url attribute of graphicImage on render
> -----------------------------------------------------------------------------------------------
>
>          Key: MYFACES-52
>          URL: http://issues.apache.org/jira/browse/MYFACES-52
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.7 beta
>  Environment: JBoss 4, Tomcat 5, JDK 1.5, Win XP
>     Reporter: 

>
> I set the value of url (graphicImage) and image (commandButton) to images/minus.gif and the HTML source page has generated     src attribute of img and input with the same value. But, when I set the value of url (graphicImage) and image (commandButton) to /images/minus.gif the HTML source page has generated different: src attribute of input TAG is the same value; src attribute of img TAG has added with web context (/solution.web).
> Pratical result: the image of commandButton don´t show because /image/minus.gif don´t exists.
> Attribute value
> ---------------
> JSF : image        == url        == images/minus.gif
> HTML: src of input == src of img == images/minus.gif
> HTML source page (ok)
> ----------------
> <img id="_id0:graphicImage1" src="images/minus.gif"/>
> <input id="_id0:commandButton1" name="_id0:commandButton1" type="image" src="images/plus.gif" 
> onclick="clear__5Fid0();document.forms['_id0'].elements['autoScroll'].value=getScrolling();"/>
> Attribute value
> ---------------
> JSF : image        == url        == /images/minus.gif
> HTML: src of input ==               /images/minus.gif
>       src of img   ==               /solution.web/images/minus.gif
> HTML source page (problem)
> ----------------
> <img id="_id0:graphicImage1" src="/solution.web/images/minus.gif"/>
> <input id="_id0:commandButton1" name="_id0:commandButton1" type="image" src="/images/plus.gif" onclick="clear__5Fid0();document.forms['_id0'].elements['autoScroll'].value=getScrolling();"/>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira