You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "LuGuangming (via GitHub)" <gi...@apache.org> on 2024/01/20 12:37:46 UTC

[PR] [fix][security] BE log exists print sensitive msg [doris]

LuGuangming opened a new pull request, #30174:
URL: https://github.com/apache/doris/pull/30174

   ## Proposed changes
   
   Issue Number: close #30173
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1902093254

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.57 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0b5c6f8b29fd4b0e7c92f863fcdb898d48925242, data reload: false
   
   query1	0.02	0.02	0.02
   query2	0.05	0.02	0.02
   query3	0.25	0.04	0.05
   query4	1.83	0.06	0.06
   query5	0.53	0.52	0.52
   query6	1.29	0.61	0.60
   query7	0.01	0.01	0.01
   query8	0.05	0.02	0.02
   query9	0.54	0.49	0.49
   query10	0.55	0.52	0.52
   query11	0.11	0.09	0.08
   query12	0.11	0.09	0.09
   query13	0.61	0.61	0.61
   query14	0.79	0.77	0.78
   query15	0.79	0.76	0.76
   query16	0.37	0.37	0.38
   query17	1.01	1.02	1.02
   query18	0.25	0.24	0.24
   query19	1.85	1.86	1.86
   query20	0.01	0.01	0.01
   query21	15.48	0.58	0.59
   query22	1.83	1.98	1.30
   query23	17.69	0.91	0.93
   query24	6.62	3.32	0.94
   query25	2.38	0.16	0.16
   query26	0.15	0.14	0.15
   query27	0.14	0.15	0.14
   query28	5.20	0.73	0.72
   query29	12.58	2.28	2.36
   query30	0.61	0.52	0.50
   query31	2.83	0.38	0.39
   query32	3.41	0.50	0.51
   query33	3.10	3.02	3.17
   query34	15.26	4.79	4.80
   query35	4.83	4.86	4.84
   query36	1.05	1.01	1.03
   query37	0.05	0.05	0.05
   query38	0.03	0.02	0.02
   query39	0.02	0.01	0.01
   query40	0.16	0.13	0.14
   query41	0.07	0.02	0.01
   query42	0.01	0.02	0.02
   query43	0.02	0.01	0.02
   Total cold run time: 104.54 s
   Total hot run time: 30.57 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1902089358

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #30174:
URL: https://github.com/apache/doris/pull/30174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "LuGuangming (via GitHub)" <gi...@apache.org>.
LuGuangming commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1902084014

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1902093897

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 0b5c6f8b29fd4b0e7c92f863fcdb898d48925242 with default session variables
   Stream load json:         21 seconds loaded 2358488459 Bytes, about 107 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1925377785

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1902092220

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 243957 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0b5c6f8b29fd4b0e7c92f863fcdb898d48925242, data reload: false
   
   query1	913	387	388	387
   query2	6520	2246	2134	2134
   query3	6918	199	201	199
   query4	21227	18087	18126	18087
   query5	19722	6269	6234	6234
   query6	288	214	220	214
   query7	4153	306	308	306
   query8	279	253	239	239
   query9	3126	2701	2622	2622
   query10	417	309	296	296
   query11	11467	10717	10693	10693
   query12	118	78	65	65
   query13	5643	653	630	630
   query14	17844	13353	13360	13353
   query15	377	253	230	230
   query16	6458	263	269	263
   query17	3220	851	869	851
   query18	2267	409	407	407
   query19	211	148	147	147
   query20	79	77	74	74
   query21	180	95	94	94
   query22	5204	4981	5141	4981
   query23	32628	31990	32017	31990
   query24	6883	6587	6531	6531
   query25	538	420	426	420
   query26	522	169	158	158
   query27	1782	296	296	296
   query28	6103	2243	2216	2216
   query29	2873	2686	2713	2686
   query30	242	161	160	160
   query31	919	728	717	717
   query32	64	55	59	55
   query33	392	266	260	260
   query34	848	468	477	468
   query35	1107	937	945	937
   query36	1747	1414	1535	1414
   query37	87	60	60	60
   query38	3073	2950	2927	2927
   query39	1370	1309	1325	1309
   query40	198	89	96	89
   query41	33	33	32	32
   query42	88	79	81	79
   query43	580	567	632	567
   query44	1142	717	715	715
   query45	245	238	228	228
   query46	1240	990	966	966
   query47	1866	1720	1822	1720
   query48	988	672	678	672
   query49	615	365	357	357
   query50	870	597	577	577
   query51	5673	5519	5593	5519
   query52	86	85	84	84
   query53	443	320	319	319
   query54	2405	2281	2227	2227
   query55	88	88	85	85
   query56	232	199	198	198
   query57	1120	1106	1102	1102
   query58	207	196	213	196
   query59	3279	3359	3181	3181
   query60	204	201	197	197
   query61	84	82	86	82
   query62	775	517	466	466
   query63	480	339	335	335
   query64	1994	1288	1273	1273
   query65	3710	3611	3589	3589
   query66	822	370	362	362
   query67	17542	17004	15304	15304
   query68	5912	671	640	640
   query69	548	351	350	350
   query70	1665	1644	1599	1599
   query71	369	299	310	299
   query72	4325	3383	3375	3375
   query73	704	332	319	319
   query74	6283	5921	5840	5840
   query75	4296	3579	3535	3535
   query76	3868	1181	1204	1181
   query77	551	258	247	247
   query78	31891	53127	55222	53127
   query79	15542	661	641	641
   query80	4848	385	380	380
   query81	559	228	225	225
   query82	1959	104	96	96
   query83	327	140	133	133
   query84	260	70	70	70
   query85	1823	278	282	278
   query86	450	367	393	367
   query87	3238	3025	3015	3015
   query88	7216	2335	2284	2284
   query89	466	277	279	277
   query90	2541	212	208	208
   query91	181	114	119	114
   query92	66	49	51	49
   query93	6541	646	630	630
   query94	1755	205	208	205
   query95	1113	1095	1097	1095
   query96	644	326	333	326
   query97	6459	6359	6423	6359
   query98	188	179	178	178
   query99	3739	919	884	884
   Total cold run time: 345145 ms
   Total hot run time: 243957 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1903625665

   run beut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1925397020

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 240740 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c84ba8c2328d528773bace57e35fcde4bd27156e, data reload: false
   
   query1	911	391	376	376
   query2	6516	2252	2098	2098
   query3	6917	205	199	199
   query4	21292	17955	18115	17955
   query5	19733	6237	6243	6237
   query6	278	221	217	217
   query7	4147	303	307	303
   query8	264	238	241	238
   query9	3111	2655	2611	2611
   query10	409	281	306	281
   query11	11299	10731	10758	10731
   query12	124	71	71	71
   query13	5649	659	637	637
   query14	17482	13434	13267	13267
   query15	377	246	240	240
   query16	6437	262	266	262
   query17	3179	896	874	874
   query18	2260	416	408	408
   query19	199	149	161	149
   query20	78	75	71	71
   query21	184	91	95	91
   query22	5232	5079	5115	5079
   query23	32653	31811	32081	31811
   query24	7049	6524	6598	6524
   query25	516	429	416	416
   query26	527	173	164	164
   query27	1873	293	294	293
   query28	6052	2219	2189	2189
   query29	2982	2647	2835	2647
   query30	249	164	159	159
   query31	893	727	736	727
   query32	57	54	59	54
   query33	395	271	264	264
   query34	862	476	495	476
   query35	1104	932	933	932
   query36	1701	1567	1851	1567
   query37	87	57	58	57
   query38	3106	2899	2908	2899
   query39	1358	1342	1320	1320
   query40	203	93	90	90
   query41	33	32	33	32
   query42	100	87	87	87
   query43	682	547	695	547
   query44	1120	708	720	708
   query45	239	235	229	229
   query46	1231	976	962	962
   query47	1879	1750	1884	1750
   query48	983	689	664	664
   query49	623	366	366	366
   query50	881	591	593	591
   query51	5596	5505	5522	5505
   query52	93	78	81	78
   query53	443	329	321	321
   query54	2446	2246	2281	2246
   query55	86	77	77	77
   query56	219	207	207	207
   query57	1159	1134	1180	1134
   query58	203	185	205	185
   query59	3411	3235	3376	3235
   query60	214	195	201	195
   query61	89	90	86	86
   query62	788	507	434	434
   query63	466	343	333	333
   query64	2012	1301	1295	1295
   query65	3710	3593	3623	3593
   query66	834	376	357	357
   query67	15989	15483	15742	15483
   query68	8331	649	634	634
   query69	571	329	350	329
   query70	1871	1647	1715	1647
   query71	398	302	307	302
   query72	4599	3363	3378	3363
   query73	724	329	326	326
   query74	6293	5856	5825	5825
   query75	4386	3549	3513	3513
   query76	4834	1155	1181	1155
   query77	706	250	250	250
   query78	31555	51086	49956	49956
   query79	15817	630	639	630
   query80	4719	389	385	385
   query81	568	229	232	229
   query82	1214	95	94	94
   query83	334	139	131	131
   query84	251	70	70	70
   query85	2384	295	283	283
   query86	446	371	374	371
   query87	3252	3048	3005	3005
   query88	7235	2357	2375	2357
   query89	455	296	274	274
   query90	2539	202	214	202
   query91	151	119	125	119
   query92	65	53	49	49
   query93	6473	578	605	578
   query94	1697	203	210	203
   query95	1139	1054	1063	1054
   query96	649	330	330	330
   query97	6492	6429	6367	6367
   query98	184	188	179	179
   query99	3713	846	952	846
   Total cold run time: 347319 ms
   Total hot run time: 240740 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1925385080

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1902087484

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1925398234

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.99 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit c84ba8c2328d528773bace57e35fcde4bd27156e, data reload: false
   
   query1	0.02	0.02	0.02
   query2	0.05	0.02	0.02
   query3	0.25	0.04	0.04
   query4	1.84	0.06	0.08
   query5	0.53	0.53	0.52
   query6	1.26	0.60	0.59
   query7	0.02	0.00	0.01
   query8	0.03	0.02	0.03
   query9	0.52	0.48	0.47
   query10	0.54	0.54	0.54
   query11	0.11	0.08	0.08
   query12	0.12	0.09	0.09
   query13	0.62	0.61	0.61
   query14	0.79	0.81	0.79
   query15	0.79	0.76	0.76
   query16	0.37	0.37	0.37
   query17	0.96	1.00	1.00
   query18	0.22	0.26	0.21
   query19	1.94	1.89	1.83
   query20	0.01	0.01	0.00
   query21	15.45	0.57	0.56
   query22	2.01	2.04	1.66
   query23	17.61	0.84	0.95
   query24	4.67	5.56	1.26
   query25	1.63	0.12	0.10
   query26	0.44	0.13	0.14
   query27	0.10	0.10	0.11
   query28	4.65	0.78	0.77
   query29	12.66	2.37	2.34
   query30	0.60	0.48	0.51
   query31	2.83	0.37	0.39
   query32	3.41	0.49	0.50
   query33	3.09	3.03	3.10
   query34	15.32	4.79	4.77
   query35	4.86	4.83	4.86
   query36	1.06	1.00	1.02
   query37	0.06	0.04	0.05
   query38	0.03	0.02	0.02
   query39	0.02	0.01	0.01
   query40	0.16	0.14	0.14
   query41	0.07	0.01	0.01
   query42	0.02	0.01	0.01
   query43	0.02	0.01	0.01
   Total cold run time: 101.76 s
   Total hot run time: 30.99 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1925396879

   TeamCity be ut coverage result:
    Function Coverage: 37.84% (8034/21233) 
    Line Coverage: 29.54% (65468/221635)
    Region Coverage: 28.96% (33623/116119)
    Branch Coverage: 24.82% (17253/69516)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/c84ba8c2328d528773bace57e35fcde4bd27156e_c84ba8c2328d528773bace57e35fcde4bd27156e/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1902089233

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 50045 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0b5c6f8b29fd4b0e7c92f863fcdb898d48925242, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	18357	4320	4309	4309
   q2	2024	148	144	144
   q3	10284	1887	1927	1887
   q4	10130	1249	1320	1249
   q5	8475	4003	4042	4003
   q6	226	130	123	123
   q7	2029	1623	1616	1616
   q8	9342	2728	2728	2728
   q9	10735	10568	10382	10382
   q10	8623	3539	3548	3539
   q11	423	238	248	238
   q12	464	301	302	301
   q13	18352	3993	4047	3993
   q14	345	317	322	317
   q15	508	452	457	452
   q16	700	591	592	591
   q17	1135	973	957	957
   q18	7285	7089	6849	6849
   q19	1696	1542	1551	1542
   q20	545	323	330	323
   q21	4436	4108	4190	4108
   q22	510	394	408	394
   Total cold run time: 116624 ms
   Total hot run time: 50045 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4304	4259	4318	4259
   q2	316	220	222	220
   q3	4219	4166	4125	4125
   q4	2753	2724	2771	2724
   q5	7314	7267	7260	7260
   q6	237	122	117	117
   q7	3262	2912	2851	2851
   q8	4372	4467	4566	4467
   q9	17002	17008	17156	17008
   q10	4209	4257	4275	4257
   q11	770	676	675	675
   q12	1030	856	847	847
   q13	6739	3709	3770	3709
   q14	453	425	431	425
   q15	492	447	464	447
   q16	762	709	717	709
   q17	3863	3818	3849	3818
   q18	8904	8882	8829	8829
   q19	1710	1695	1640	1640
   q20	2363	2195	2120	2120
   q21	8640	8512	8579	8512
   q22	1065	942	975	942
   Total cold run time: 84779 ms
   Total hot run time: 79961 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1902085233

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1902088303

   TeamCity be ut coverage result:
    Function Coverage: 37.84% (8031/21225) 
    Line Coverage: 29.50% (65289/221324)
    Region Coverage: 28.96% (33587/115993)
    Branch Coverage: 24.81% (17234/69450)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/0b5c6f8b29fd4b0e7c92f863fcdb898d48925242_0b5c6f8b29fd4b0e7c92f863fcdb898d48925242/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1903677011

   TeamCity be ut coverage result:
    Function Coverage: 37.82% (8028/21227) 
    Line Coverage: 29.49% (65274/221344)
    Region Coverage: 28.94% (33578/116011)
    Branch Coverage: 24.81% (17232/69462)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/eed6fe88ff730e6a0106a0c3f0e5de9dc2a230ec_eed6fe88ff730e6a0106a0c3f0e5de9dc2a230ec/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1925399038

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit c84ba8c2328d528773bace57e35fcde4bd27156e with default session variables
   Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix][security] BE log exists print sensitive msg [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30174:
URL: https://github.com/apache/doris/pull/30174#issuecomment-1925393704

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 50173 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c84ba8c2328d528773bace57e35fcde4bd27156e, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	18032	4426	4327	4327
   q2	2060	157	144	144
   q3	10337	1934	1975	1934
   q4	10097	1307	1329	1307
   q5	8482	4063	4005	4005
   q6	232	122	125	122
   q7	2065	1590	1609	1590
   q8	9484	2739	2744	2739
   q9	13764	10750	10469	10469
   q10	8690	3557	3535	3535
   q11	416	240	248	240
   q12	459	300	299	299
   q13	18358	3951	4078	3951
   q14	358	333	335	333
   q15	505	469	457	457
   q16	688	609	592	592
   q17	1137	978	939	939
   q18	7264	6892	6882	6882
   q19	1704	1557	1516	1516
   q20	529	288	316	288
   q21	4517	4121	4116	4116
   q22	519	388	396	388
   Total cold run time: 119697 ms
   Total hot run time: 50173 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4324	4304	4277	4277
   q2	320	222	227	222
   q3	4156	4160	4145	4145
   q4	2787	2767	2754	2754
   q5	7317	7198	7193	7193
   q6	242	123	118	118
   q7	3252	2835	2786	2786
   q8	4392	4540	4554	4540
   q9	17081	16981	17014	16981
   q10	4263	4277	4292	4277
   q11	770	693	668	668
   q12	1046	842	867	842
   q13	6287	3772	3773	3772
   q14	452	422	408	408
   q15	508	460	461	460
   q16	765	701	697	697
   q17	3861	3861	4027	3861
   q18	8740	8838	8735	8735
   q19	1735	1705	1707	1705
   q20	2397	2155	2108	2108
   q21	8615	8552	8544	8544
   q22	1039	957	960	957
   Total cold run time: 84349 ms
   Total hot run time: 80050 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org