You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/09/02 10:28:44 UTC
[GitHub] [camel] bvahdat opened a new pull request, #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
bvahdat opened a new pull request, #8266:
URL: https://github.com/apache/camel/pull/8266
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat commented on pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
bvahdat commented on PR #8266:
URL: https://github.com/apache/camel/pull/8266#issuecomment-1235594358
> it is on the shoulders of servicemix and the release cycle timing is different
I see. I am not familiar with the SMX and it's release cycles, but I would expect if the intention is there to provide a bundle for azure-XXX, then that activity should always happen in the context of a given azure-sdk-bom version with all the other azure-YYY bundles belonging to the same azure-sdk-bom version. Otherwise it doesn't help much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #8266:
URL: https://github.com/apache/camel/pull/8266#issuecomment-1235588863
Who will release the bundles aligned with the specific bom? They are not provided with the SDK so it is on the shoulders of servicemix and the release cycle timing is different. I'm not saying it's wrong, I'm just saying for compatibility reasons we won't be able to be aligned each month. Just this. Alternatively we can wrap the jars in the features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8266:
URL: https://github.com/apache/camel/pull/8266#issuecomment-1235386773
:x: Finished component verification: **1 component(s) test failed** out of 1 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8266:
URL: https://github.com/apache/camel/pull/8266#issuecomment-1235334470
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat commented on pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
bvahdat commented on PR #8266:
URL: https://github.com/apache/camel/pull/8266#issuecomment-1235582071
> This looks good to me. The concern I have mainly is about the other runtimes. Especially Karaf. It won't be possible to have all the needed bundles for each non release. So we either remove the features from Karaf or we find a way to support this approach
Why would we want to make use of the needed bundles not belonging to the same BOM as that would cause all sorts of problems, no mater if Karaf, Quarkus or SB runtime? If we would continue doing that, then we would run into the same issue as currently on the main branch described in CAMEL-18452 in regards to CAMEL-18451.
Let's compare azure-XXX versions in 3.18.1:
https://github.com/apache/camel/blob/camel-3.18.1/parent/pom.xml#L86-L96
With the corresponding azure-XXX bundle versions:
https://github.com/apache/camel-karaf/blob/main/pom.xml#L130-L140
They are out-of-sync. E.g.
`<azure-eventhubs-version>5.11.2</azure-eventhubs-version>`
Versus:
`<azure-messaging-eventhubs-bundle-version>5.8.0_1</azure-messaging-eventhubs-bundle-version>`
But that doesn't need to be that way. If we rely on a given azure-sdk-bom version we can see in one shot what are the corresponding bundles we should come up with:
https://mvnrepository.com/artifact/com.azure/azure-sdk-bom/1.2.5
Just thinking about a given Apache Camel based integration where camel-azure-eventhubs + camel-azure-servicebus + camel-azure-blobstorage of a given Camel version are all inside the same POM and if their versions are not aligned / consistent then that integration would run into all sorts of problems at runtime with conflicting transitive dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat commented on pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
bvahdat commented on PR #8266:
URL: https://github.com/apache/camel/pull/8266#issuecomment-1235716560
> The error in this PR kinda reminds me of the issues I had fixed in the past. I am not saying it is the cause, but it reminded me of those.
Thanks @orpiske for your feedback. The root cause of the error was because of the ancient version of Azurite from February in use. The build is now successful.
BTW I find test-infra a tremendous added value to the Apache Camel project, KUDOS :raised_hands:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8266:
URL: https://github.com/apache/camel/pull/8266#issuecomment-1235749432
Thanks! I am glad that you found the issue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat closed pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
bvahdat closed pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
URL: https://github.com/apache/camel/pull/8266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8266:
URL: https://github.com/apache/camel/pull/8266#issuecomment-1235757779
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8266:
URL: https://github.com/apache/camel/pull/8266#issuecomment-1235716255
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8266: CAMEL-18452: Integrate azure-sdk-bom in a non-conflicting manner
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8266:
URL: https://github.com/apache/camel/pull/8266#issuecomment-1235433662
> ❌ Finished component verification: **1 component(s) test failed** out of 1 component(s) tested
One additional comment regarding this ... In the past I remember fixing conflicts caused by different Netty versions used in these vendor BOMs and Camel. We may also need to make sure it doesn't cause conflicts.
The error in this PR kinda reminds me of the issues I had fixed in the past. I am not saying it is the cause, but it reminded me of those. 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org