You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/14 07:26:12 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6430: wireless/bcm430xx: rename chip minor id to 'x'

xiaoxiang781216 commented on code in PR #6430:
URL: https://github.com/apache/incubator-nuttx/pull/6430#discussion_r896465864


##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c:
##########
@@ -483,6 +481,25 @@ int bcmf_core_upload_firmware(FAR struct bcmf_sdio_dev_s *sbus)
 #endif
 
       default:
+#ifdef CONFIG_IEEE80211_BROADCOM_BCM4301X
+        if (sbus->cur_chip_id >= SDIO_DEVICE_ID_BROADCOM_43011 &&

Review Comment:
   should we list in case instead if?



##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_core.c:
##########
@@ -585,6 +600,20 @@ int bcmf_core_upload_firmware(FAR struct bcmf_sdio_dev_s *sbus)
 #endif
 
       default:
+#ifdef CONFIG_IEEE80211_BROADCOM_BCM4301X
+        if (sbus->cur_chip_id >= SDIO_DEVICE_ID_BROADCOM_43011 &&

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org