You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "jiangML (via GitHub)" <gi...@apache.org> on 2023/03/10 11:43:37 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #24545: Fix suite test error
jiangML opened a new pull request, #24545:
URL: https://github.com/apache/shardingsphere/pull/24545
Fixes #24540.
Changes proposed in this pull request:
- Fix suite test error
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #24545: Fix GeneralRALE2EIT test error
Posted by "tristaZero (via GitHub)" <gi...@apache.org>.
tristaZero merged PR #24545:
URL: https://github.com/apache/shardingsphere/pull/24545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #24545: Fix GeneralRALE2EIT test error
Posted by "taojintianxia (via GitHub)" <gi...@apache.org>.
taojintianxia commented on code in PR #24545:
URL: https://github.com/apache/shardingsphere/pull/24545#discussion_r1133541408
##########
test/e2e/suite/src/test/java/org/apache/shardingsphere/test/e2e/engine/ral/GeneralRALE2EIT.java:
##########
@@ -59,7 +59,7 @@ private void assertResultSet(final Statement statement) throws SQLException, Par
assertResultSet(statement, getSQL());
} else {
statement.execute(getSQL());
- sleep();
+ sleep(2000);
Review Comment:
why not use awaitility ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org