You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@yetus.apache.org by GitBox <gi...@apache.org> on 2022/05/23 14:34:48 UTC

[GitHub] [yetus-homebrew] ndimiduk commented on a diff in pull request #6: YETUS-1185. release process for yetus-homebrew is broken

ndimiduk commented on code in PR #6:
URL: https://github.com/apache/yetus-homebrew/pull/6#discussion_r879529777


##########
release.sh:
##########
@@ -19,6 +19,10 @@
 
 USER_NAME=${SUDO_USER:=$USER}
 USER_ID=$(id -u "${USER_NAME}")
+GPG=$(command -v gpg)
+GPGAGENT=$(command -v gpg-agent)
+LOGDIR="/tmp/homebrew-sign.$$"

Review Comment:
   Since we write GPG configs here, should this file be generated with something like `mktemp` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org