You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by ha...@apache.org on 2022/09/07 20:23:26 UTC
[hop] branch master updated: HOP-4190 Fix IT join rows (dataset with decimal dot separator)
This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/master by this push:
new 60e9abcc43 HOP-4190 Fix IT join rows (dataset with decimal dot separator)
new c51108b6e4 Merge pull request #1671 from nadment/HOP-4190
60e9abcc43 is described below
commit 60e9abcc43960c8e638704cd93e6c046f8abb232
Author: Nicolas Adment <39...@users.noreply.github.com>
AuthorDate: Sun Sep 4 12:23:49 2022 +0200
HOP-4190 Fix IT join rows (dataset with decimal dot separator)
---
.../transforms/datasets/golden-join-rows-equal.csv | 4 ++--
.../transforms/datasets/golden-join-rows-range.csv | 22 +++++++++++-----------
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/integration-tests/transforms/datasets/golden-join-rows-equal.csv b/integration-tests/transforms/datasets/golden-join-rows-equal.csv
index e9d768d375..b1474d8981 100644
--- a/integration-tests/transforms/datasets/golden-join-rows-equal.csv
+++ b/integration-tests/transforms/datasets/golden-join-rows-equal.csv
@@ -1,3 +1,3 @@
id1,value1,id2,value2,rangeStart,rangeEnd
-2,b,2,B,"0,0","5,0"
-5,e,5,E,"6,0","10,0"
+2,b,2,B,0.0,5.0
+5,e,5,E,6.0,10.0
diff --git a/integration-tests/transforms/datasets/golden-join-rows-range.csv b/integration-tests/transforms/datasets/golden-join-rows-range.csv
index 496d36fe23..fd7f5a6a81 100644
--- a/integration-tests/transforms/datasets/golden-join-rows-range.csv
+++ b/integration-tests/transforms/datasets/golden-join-rows-range.csv
@@ -1,12 +1,12 @@
id1,value1,id2,value2,rangeStart,rangeEnd
-1,a,2,B,"0,0","5,0"
-2,b,2,B,"0,0","5,0"
-3,c,2,B,"0,0","5,0"
-3,c,4,D,"2,5","3,5"
-5,e,2,B,"0,0","5,0"
-5,e,9,H,"5,0","50,0"
-8,h,5,E,"6,0","10,0"
-8,h,9,H,"5,0","50,0"
-10,j,5,E,"6,0","10,0"
-10,j,7,G,"10,0","100,0"
-10,j,9,H,"5,0","50,0"
+1,a,2,B,0.0,5.0
+2,b,2,B,0.0,5.0
+3,c,2,B,0.0,5.0
+3,c,4,D,2.5,3.5
+5,e,2,B,0.0,5.0
+5,e,9,H,5.0,50.0
+8,h,5,E,6.0,10.0
+8,h,9,H,5.0,50.0
+10,j,5,E,6.0,10.0
+10,j,7,G,10.0,100.0
+10,j,9,H,5.0,50.0