You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/23 19:19:21 UTC

[GitHub] [tvm] driazati opened a new pull request, #11856: [ci] Add manual workflow to upload files to CI bucket

driazati opened a new pull request, #11856:
URL: https://github.com/apache/tvm/pull/11856

   This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in #11839
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] areusch commented on a diff in pull request #11856: [ci] Add manual workflow to upload files to CI bucket

Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #11856:
URL: https://github.com/apache/tvm/pull/11856#discussion_r905405171


##########
jenkins/README.md:
##########
@@ -72,6 +72,16 @@ See #<issue number>
 '
 gh pr create
 ```
+
+## Network Resources
+
+Downloading files from the Internet in CI is a big source of flaky failures
+(e.g. remote server goes down or is slow), so try to avoid using the network at
+all during tests. In some cases this isn't a reasonable proposition (e.g. the
+docs tutorials which need to download models). In these cases you can re-host
+files in S3 for fast access in CI. A committer can upload a file, specified by
+a name, hash, and path in S3, using the `workflow_dispatch` event on
+[the `upload_ci_resource.yml` GitHub Actions workflow](https://github.com/driazati/tvm/actions/workflows/upload_ci_resource.yml).

Review Comment:
   can you fix private repo mention? also, what should folks use as upload_path?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] driazati commented on pull request #11856: [ci] Add manual workflow to upload files to CI bucket

Posted by GitBox <gi...@apache.org>.
driazati commented on PR #11856:
URL: https://github.com/apache/tvm/pull/11856#issuecomment-1165790090

   I need the `main` branch in my fork for developing other Actions things, @Mousius we can address any comments in a follow up (this one doesn't have any effect unless someone manually runs it anyways)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] github-actions[bot] commented on pull request #11856: [ci] Add manual workflow to upload files to CI bucket

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11856:
URL: https://github.com/apache/tvm/pull/11856#issuecomment-1164788293

   Built docs for commit 2dced89d5ddee68ccc42379d20ce9f0e281a2ae8 can be found [here](https://pr-docs.tlcpack.ai/PR-11856/1/docs/index.html).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] driazati commented on a diff in pull request #11856: [ci] Add manual workflow to upload files to CI bucket

Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #11856:
URL: https://github.com/apache/tvm/pull/11856#discussion_r905416326


##########
jenkins/README.md:
##########
@@ -72,6 +72,16 @@ See #<issue number>
 '
 gh pr create
 ```
+
+## Network Resources
+
+Downloading files from the Internet in CI is a big source of flaky failures
+(e.g. remote server goes down or is slow), so try to avoid using the network at
+all during tests. In some cases this isn't a reasonable proposition (e.g. the
+docs tutorials which need to download models). In these cases you can re-host
+files in S3 for fast access in CI. A committer can upload a file, specified by
+a name, hash, and path in S3, using the `workflow_dispatch` event on
+[the `upload_ci_resource.yml` GitHub Actions workflow](https://github.com/driazati/tvm/actions/workflows/upload_ci_resource.yml).

Review Comment:
   fixed, and `upload_path` is wherever the file goes in s3 so it can be whatever the person triggering the build wants (e.g. for the oneflow dep in #11839 the upload path is `oneflow/resnet18.zip`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] github-actions[bot] commented on pull request #11856: [ci] Add manual workflow to upload files to CI bucket

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11856:
URL: https://github.com/apache/tvm/pull/11856#issuecomment-1164834538

   Built docs for commit 949435d63cb1768b3e27c2cdb2a52e2fc88e3616 can be found [here](https://pr-docs.tlcpack.ai/PR-11856/2/docs/index.html).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] driazati merged pull request #11856: [ci] Add manual workflow to upload files to CI bucket

Posted by GitBox <gi...@apache.org>.
driazati merged PR #11856:
URL: https://github.com/apache/tvm/pull/11856


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org