You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/12 20:17:30 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #1696: Fix docs.rs build
alamb opened a new pull request, #1696:
URL: https://github.com/apache/arrow-rs/pull/1696
# Which issue does this PR close?
Closes # https://github.com/apache/arrow-rs/issues/1695
# Rationale for this change
I broke docs.rs build by merging https://github.com/apache/arrow-rs/pull/1349 without testing it first (shame on me!)
# What changes are included in this PR?
Fix the build by removing unneeded part of 1349
I tested this by temporarily publishing an ancient version of parquet to crates.io from this branch https://github.com/alamb/arrow-rs/tree/alamb/test_crates_publish and verifying the docs built correctly
You can see the results here:
* https://crates.io/crates/parquet/0.18.1
* https://docs.rs/parquet/0.18.1/parquet/
# Are there any user-facing changes?
Docs will work correctly when published on crates.io
cc @HaoYang670 @viirya @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1696: Fix docs.rs build
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1696:
URL: https://github.com/apache/arrow-rs/pull/1696#issuecomment-1125413997
I plan to merge this when the test has completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1696: Fix docs.rs build
Posted by GitBox <gi...@apache.org>.
alamb merged PR #1696:
URL: https://github.com/apache/arrow-rs/pull/1696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on pull request #1696: Fix docs.rs build
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on PR #1696:
URL: https://github.com/apache/arrow-rs/pull/1696#issuecomment-1125780011
Just a small nit in PR description:
Replace `Closes # #1695` with `Closes #1695`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1696: Fix docs.rs build
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1696:
URL: https://github.com/apache/arrow-rs/pull/1696#issuecomment-1125401801
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1696?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1696](https://codecov.io/gh/apache/arrow-rs/pull/1696?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e57d8d8) into [master](https://codecov.io/gh/apache/arrow-rs/commit/101edc91f8d329464a8267eb6378a4a2521d3ca8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (101edc9) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1696 +/- ##
==========================================
- Coverage 83.10% 83.09% -0.01%
==========================================
Files 193 193
Lines 56011 56011
==========================================
- Hits 46547 46545 -2
- Misses 9464 9466 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.75% <0.00%> (-0.46%)` | :arrow_down: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `65.09% <0.00%> (-0.37%)` | :arrow_down: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/1696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.65% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1696?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1696?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [101edc9...e57d8d8](https://codecov.io/gh/apache/arrow-rs/pull/1696?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1696: Fix docs.rs build
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1696:
URL: https://github.com/apache/arrow-rs/pull/1696#issuecomment-1125871581
Thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org