You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jianxia Chen <jc...@pivotal.io> on 2015/09/21 20:04:31 UTC
Review Request 38563: Auto Reconnect changes for GEODE-77 (sub-task
GEODE-205)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38563/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Jason Huynh, and Lynn Gallinat.
Repository: geode
Description
-------
Original review request: https://reviews.apache.org/r/38384/
Somehow I cannot update the diff, so create this new one.
Patch from Jason.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 3ed9607
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java 9382d9c
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/JoinLeave.java 7bf35ec
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Manager.java 4539909
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Messenger.java d01dcd8
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java f88e1c0
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSPingPonger.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumChecker.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 1bf0213
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java d58bef1
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumCheckerJUnitTest.java PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java 3b1c1dc
Diff: https://reviews.apache.org/r/38563/diff/
Testing
-------
Included JUnit test and ReconnectDUnitTest
Thanks,
Jianxia Chen
Re: Review Request 38563: Auto Reconnect changes for GEODE-77
(sub-task GEODE-205)
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38563/#review99843
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java (line 2579)
<https://reviews.apache.org/r/38563/#comment156829>
This should be uncommented. Delete the setDaemon() since it isn't needed anymore and doesn't work anyway.
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java (line 109)
<https://reviews.apache.org/r/38563/#comment156831>
you can delete this
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java (line 2889)
<https://reviews.apache.org/r/38563/#comment156827>
I think this should be outside of the thread, so we don't create multiple reconnect threads.
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java (line 2899)
<https://reviews.apache.org/r/38563/#comment156832>
delete
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java (line 2933)
<https://reviews.apache.org/r/38563/#comment156828>
This isn't a reconnect-thread at this point. It's a disconnect thread. The InternalDistributedSystem will decide whether to proceed with reconnect, and at that point the threads name should be changed to "Reconnect Thread".
- Bruce Schuchardt
On Sept. 21, 2015, 6:04 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38563/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 6:04 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Jason Huynh, and Lynn Gallinat.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Original review request: https://reviews.apache.org/r/38384/
>
> Somehow I cannot update the diff, so create this new one.
>
> Patch from Jason.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 3ed9607
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java 9382d9c
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/JoinLeave.java 7bf35ec
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Manager.java 4539909
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Messenger.java d01dcd8
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java f88e1c0
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSPingPonger.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumChecker.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 1bf0213
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java d58bef1
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumCheckerJUnitTest.java PRE-CREATION
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java 3b1c1dc
>
> Diff: https://reviews.apache.org/r/38563/diff/
>
>
> Testing
> -------
>
> Included JUnit test and ReconnectDUnitTest
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 38563: Auto Reconnect changes for GEODE-77
(sub-task GEODE-205)
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38563/#review100029
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On Sept. 21, 2015, 11:23 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38563/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 11:23 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Jason Huynh, and Lynn Gallinat.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Original review request: https://reviews.apache.org/r/38384/
>
> Somehow I cannot update the diff, so create this new one.
>
> Patch from Jason.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 3ed9607
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java 9382d9c
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/JoinLeave.java 7bf35ec
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Manager.java 4539909
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Messenger.java d01dcd8
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java f88e1c0
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSPingPonger.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumChecker.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 1bf0213
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java d58bef1
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumCheckerJUnitTest.java PRE-CREATION
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java 3b1c1dc
>
> Diff: https://reviews.apache.org/r/38563/diff/
>
>
> Testing
> -------
>
> Included JUnit test and ReconnectDUnitTest
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 38563: Auto Reconnect changes for GEODE-77
(sub-task GEODE-205)
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38563/
-----------------------------------------------------------
(Updated Sept. 21, 2015, 11:23 p.m.)
Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Jason Huynh, and Lynn Gallinat.
Changes
-------
Changes per review
Repository: geode
Description
-------
Original review request: https://reviews.apache.org/r/38384/
Somehow I cannot update the diff, so create this new one.
Patch from Jason.
Diffs (updated)
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 3ed9607
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java 9382d9c
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/JoinLeave.java 7bf35ec
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Manager.java 4539909
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Messenger.java d01dcd8
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java f88e1c0
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSPingPonger.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumChecker.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 1bf0213
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java d58bef1
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumCheckerJUnitTest.java PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java 3b1c1dc
Diff: https://reviews.apache.org/r/38563/diff/
Testing
-------
Included JUnit test and ReconnectDUnitTest
Thanks,
Jianxia Chen