You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by hulk <hu...@gmail.com> on 2022/07/21 10:35:34 UTC
How to claim the license in Kvrocks release
Hi, all
In the vote thread of Kvrocks 2.1.0:
https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll.
JB and Xiaoqiao reminded us that we should also declare licenses for
Kvrocks dependencies.
But I'm not sure how can we declare since we only fetch them when building
the binary,
and didn't bundle them directly in source codes.
--
Best Regards,
- *Hulk Lin*
Re: How to claim the license in Kvrocks release
Posted by hulk <hu...@gmail.com>.
Thanks, JB.
I have changed according to suggestions, and appreciate help from everyone.
On Sat, 23 Jul 2022 at 00:53, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> That's my preferred approach as well: I prefer to keep the LICENSE
> file just for ASF and summarize third party licenses in the NOTICE
> file.
>
> Regards
> JB
>
> On Fri, Jul 22, 2022 at 5:39 PM hulk <hu...@gmail.com> wrote:
> >
> > Thanks for tison input.
> >
> > I think it will be better than declaring them in one place. I will move
> all
> > dependencies license into NOTICE and keep LICENSE clean.
> >
> > On Fri, 22 Jul 2022 at 23:30, tison <wa...@gmail.com> wrote:
> >
> > > FYI Flink puts all related notices in the NOTICE file and keeps the
> LICENSE
> > > file contains only Apache 2.0 License content.
> > >
> > > Apache Incubator doesn't use any TLP example as a rule but you may
> think of
> > > whether such approach is good for Kvrocks.
> > >
> > > Best,
> > > tison.
> > >
> > >
> > > hulk <hu...@gmail.com> 于2022年7月22日周五 23:26写道：
> > >
> > > > Hi, JB
> > > >
> > > > Thanks for your suggestion. I didn't summarize them now, will update.
> > > >
> > > > On Fri, 22 Jul 2022 at 21:40, Jean-Baptiste Onofré <jb...@nanthrax.net>
> > > > wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > It's a good approach.
> > > > >
> > > > > Don't forget to summarize the different licenses and projects used
> in
> > > > > the NOTICE file as well.
> > > > >
> > > > > Thanks !
> > > > >
> > > > > Regards
> > > > > JB
> > > > >
> > > > > On Fri, Jul 22, 2022 at 8:33 AM hulk <hu...@gmail.com>
> wrote:
> > > > > >
> > > > > > Thanks, Twice
> > > > > >
> > > > > > Yes, I saw most projects put those licenses after the License
> file,
> > > so
> > > > I
> > > > > > follow them.
> > > > > >
> > > > > > On Thu, 21 Jul 2022 at 23:46, Twice <tw...@gmail.com>
> wrote:
> > > > > >
> > > > > > > Hi Hulk,
> > > > > > >
> > > > > > > I thought we can put it next to `licenses/LICENSE.redis`
> before,
> > > > > > > but it seems some Apache projects did append these dependency
> > > > licenses
> > > > > > > directly to LICENSE,
> > > > > > > so it is good for me now.
> > > > > > >
> > > > > > > Twice
> > > > > > >
> > > > > > > On Thu, Jul 21, 2022 at 10:48 PM hulk <hu...@gmail.com>
> > > > wrote:
> > > > > > >
> > > > > > > > I tried to add the license notice for dependencies in the
> below
> > > PR:
> > > > > > > >
> > > > > > > > https://github.com/apache/incubator-kvrocks/pull/744/files
> > > > > > > >
> > > > > > > > Does this look good to you?
> > > > > > > >
> > > > > > > > On Thu, 21 Jul 2022 at 18:35, hulk <hu...@gmail.com>
> > > wrote:
> > > > > > > >
> > > > > > > > > Hi, all
> > > > > > > > >
> > > > > > > > > In the vote thread of Kvrocks 2.1.0:
> > > > > > > > >
> > > https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll
> > > > .
> > > > > > > > >
> > > > > > > > > JB and Xiaoqiao reminded us that we should also declare
> > > licenses
> > > > > for
> > > > > > > > > Kvrocks dependencies.
> > > > > > > > > But I'm not sure how can we declare since we only fetch
> them
> > > when
> > > > > > > > building
> > > > > > > > > the binary,
> > > > > > > > > and didn't bundle them directly in source codes.
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Best Regards,
> > > > > > > > > - *Hulk Lin*
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Best Regards,
> > > > > > > > - *Hulk Lin*
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Best Regards,
> > > > > > - *Hulk Lin*
> > > > >
> > > >
> > > >
> > > > --
> > > > Best Regards,
> > > > - *Hulk Lin*
> > > >
> > >
> >
> >
> > --
> > Best Regards,
> > - *Hulk Lin*
>
--
Best Regards,
- *Hulk Lin*
Re: How to claim the license in Kvrocks release
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
That's my preferred approach as well: I prefer to keep the LICENSE
file just for ASF and summarize third party licenses in the NOTICE
file.
Regards
JB
On Fri, Jul 22, 2022 at 5:39 PM hulk <hu...@gmail.com> wrote:
>
> Thanks for tison input.
>
> I think it will be better than declaring them in one place. I will move all
> dependencies license into NOTICE and keep LICENSE clean.
>
> On Fri, 22 Jul 2022 at 23:30, tison <wa...@gmail.com> wrote:
>
> > FYI Flink puts all related notices in the NOTICE file and keeps the LICENSE
> > file contains only Apache 2.0 License content.
> >
> > Apache Incubator doesn't use any TLP example as a rule but you may think of
> > whether such approach is good for Kvrocks.
> >
> > Best,
> > tison.
> >
> >
> > hulk <hu...@gmail.com> 于2022年7月22日周五 23:26写道：
> >
> > > Hi, JB
> > >
> > > Thanks for your suggestion. I didn't summarize them now, will update.
> > >
> > > On Fri, 22 Jul 2022 at 21:40, Jean-Baptiste Onofré <jb...@nanthrax.net>
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > It's a good approach.
> > > >
> > > > Don't forget to summarize the different licenses and projects used in
> > > > the NOTICE file as well.
> > > >
> > > > Thanks !
> > > >
> > > > Regards
> > > > JB
> > > >
> > > > On Fri, Jul 22, 2022 at 8:33 AM hulk <hu...@gmail.com> wrote:
> > > > >
> > > > > Thanks, Twice
> > > > >
> > > > > Yes, I saw most projects put those licenses after the License file,
> > so
> > > I
> > > > > follow them.
> > > > >
> > > > > On Thu, 21 Jul 2022 at 23:46, Twice <tw...@gmail.com> wrote:
> > > > >
> > > > > > Hi Hulk,
> > > > > >
> > > > > > I thought we can put it next to `licenses/LICENSE.redis` before,
> > > > > > but it seems some Apache projects did append these dependency
> > > licenses
> > > > > > directly to LICENSE,
> > > > > > so it is good for me now.
> > > > > >
> > > > > > Twice
> > > > > >
> > > > > > On Thu, Jul 21, 2022 at 10:48 PM hulk <hu...@gmail.com>
> > > wrote:
> > > > > >
> > > > > > > I tried to add the license notice for dependencies in the below
> > PR:
> > > > > > >
> > > > > > > https://github.com/apache/incubator-kvrocks/pull/744/files
> > > > > > >
> > > > > > > Does this look good to you?
> > > > > > >
> > > > > > > On Thu, 21 Jul 2022 at 18:35, hulk <hu...@gmail.com>
> > wrote:
> > > > > > >
> > > > > > > > Hi, all
> > > > > > > >
> > > > > > > > In the vote thread of Kvrocks 2.1.0:
> > > > > > > >
> > https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll
> > > .
> > > > > > > >
> > > > > > > > JB and Xiaoqiao reminded us that we should also declare
> > licenses
> > > > for
> > > > > > > > Kvrocks dependencies.
> > > > > > > > But I'm not sure how can we declare since we only fetch them
> > when
> > > > > > > building
> > > > > > > > the binary,
> > > > > > > > and didn't bundle them directly in source codes.
> > > > > > > >
> > > > > > > > --
> > > > > > > > Best Regards,
> > > > > > > > - *Hulk Lin*
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Best Regards,
> > > > > > > - *Hulk Lin*
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Best Regards,
> > > > > - *Hulk Lin*
> > > >
> > >
> > >
> > > --
> > > Best Regards,
> > > - *Hulk Lin*
> > >
> >
>
>
> --
> Best Regards,
> - *Hulk Lin*
Re: How to claim the license in Kvrocks release
Posted by hulk <hu...@gmail.com>.
Thanks for tison input.
I think it will be better than declaring them in one place. I will move all
dependencies license into NOTICE and keep LICENSE clean.
On Fri, 22 Jul 2022 at 23:30, tison <wa...@gmail.com> wrote:
> FYI Flink puts all related notices in the NOTICE file and keeps the LICENSE
> file contains only Apache 2.0 License content.
>
> Apache Incubator doesn't use any TLP example as a rule but you may think of
> whether such approach is good for Kvrocks.
>
> Best,
> tison.
>
>
> hulk <hu...@gmail.com> 于2022年7月22日周五 23:26写道：
>
> > Hi, JB
> >
> > Thanks for your suggestion. I didn't summarize them now, will update.
> >
> > On Fri, 22 Jul 2022 at 21:40, Jean-Baptiste Onofré <jb...@nanthrax.net>
> > wrote:
> >
> > > Hi,
> > >
> > > It's a good approach.
> > >
> > > Don't forget to summarize the different licenses and projects used in
> > > the NOTICE file as well.
> > >
> > > Thanks !
> > >
> > > Regards
> > > JB
> > >
> > > On Fri, Jul 22, 2022 at 8:33 AM hulk <hu...@gmail.com> wrote:
> > > >
> > > > Thanks, Twice
> > > >
> > > > Yes, I saw most projects put those licenses after the License file,
> so
> > I
> > > > follow them.
> > > >
> > > > On Thu, 21 Jul 2022 at 23:46, Twice <tw...@gmail.com> wrote:
> > > >
> > > > > Hi Hulk,
> > > > >
> > > > > I thought we can put it next to `licenses/LICENSE.redis` before,
> > > > > but it seems some Apache projects did append these dependency
> > licenses
> > > > > directly to LICENSE,
> > > > > so it is good for me now.
> > > > >
> > > > > Twice
> > > > >
> > > > > On Thu, Jul 21, 2022 at 10:48 PM hulk <hu...@gmail.com>
> > wrote:
> > > > >
> > > > > > I tried to add the license notice for dependencies in the below
> PR:
> > > > > >
> > > > > > https://github.com/apache/incubator-kvrocks/pull/744/files
> > > > > >
> > > > > > Does this look good to you?
> > > > > >
> > > > > > On Thu, 21 Jul 2022 at 18:35, hulk <hu...@gmail.com>
> wrote:
> > > > > >
> > > > > > > Hi, all
> > > > > > >
> > > > > > > In the vote thread of Kvrocks 2.1.0:
> > > > > > >
> https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll
> > .
> > > > > > >
> > > > > > > JB and Xiaoqiao reminded us that we should also declare
> licenses
> > > for
> > > > > > > Kvrocks dependencies.
> > > > > > > But I'm not sure how can we declare since we only fetch them
> when
> > > > > > building
> > > > > > > the binary,
> > > > > > > and didn't bundle them directly in source codes.
> > > > > > >
> > > > > > > --
> > > > > > > Best Regards,
> > > > > > > - *Hulk Lin*
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Best Regards,
> > > > > > - *Hulk Lin*
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Best Regards,
> > > > - *Hulk Lin*
> > >
> >
> >
> > --
> > Best Regards,
> > - *Hulk Lin*
> >
>
--
Best Regards,
- *Hulk Lin*
Re: How to claim the license in Kvrocks release
Posted by tison <wa...@gmail.com>.
FYI Flink puts all related notices in the NOTICE file and keeps the LICENSE
file contains only Apache 2.0 License content.
Apache Incubator doesn't use any TLP example as a rule but you may think of
whether such approach is good for Kvrocks.
Best,
tison.
hulk <hu...@gmail.com> 于2022年7月22日周五 23:26写道：
> Hi, JB
>
> Thanks for your suggestion. I didn't summarize them now, will update.
>
> On Fri, 22 Jul 2022 at 21:40, Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
>
> > Hi,
> >
> > It's a good approach.
> >
> > Don't forget to summarize the different licenses and projects used in
> > the NOTICE file as well.
> >
> > Thanks !
> >
> > Regards
> > JB
> >
> > On Fri, Jul 22, 2022 at 8:33 AM hulk <hu...@gmail.com> wrote:
> > >
> > > Thanks, Twice
> > >
> > > Yes, I saw most projects put those licenses after the License file, so
> I
> > > follow them.
> > >
> > > On Thu, 21 Jul 2022 at 23:46, Twice <tw...@gmail.com> wrote:
> > >
> > > > Hi Hulk,
> > > >
> > > > I thought we can put it next to `licenses/LICENSE.redis` before,
> > > > but it seems some Apache projects did append these dependency
> licenses
> > > > directly to LICENSE,
> > > > so it is good for me now.
> > > >
> > > > Twice
> > > >
> > > > On Thu, Jul 21, 2022 at 10:48 PM hulk <hu...@gmail.com>
> wrote:
> > > >
> > > > > I tried to add the license notice for dependencies in the below PR:
> > > > >
> > > > > https://github.com/apache/incubator-kvrocks/pull/744/files
> > > > >
> > > > > Does this look good to you?
> > > > >
> > > > > On Thu, 21 Jul 2022 at 18:35, hulk <hu...@gmail.com> wrote:
> > > > >
> > > > > > Hi, all
> > > > > >
> > > > > > In the vote thread of Kvrocks 2.1.0:
> > > > > > https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll
> .
> > > > > >
> > > > > > JB and Xiaoqiao reminded us that we should also declare licenses
> > for
> > > > > > Kvrocks dependencies.
> > > > > > But I'm not sure how can we declare since we only fetch them when
> > > > > building
> > > > > > the binary,
> > > > > > and didn't bundle them directly in source codes.
> > > > > >
> > > > > > --
> > > > > > Best Regards,
> > > > > > - *Hulk Lin*
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Best Regards,
> > > > > - *Hulk Lin*
> > > > >
> > > >
> > >
> > >
> > > --
> > > Best Regards,
> > > - *Hulk Lin*
> >
>
>
> --
> Best Regards,
> - *Hulk Lin*
>
Re: How to claim the license in Kvrocks release
Posted by hulk <hu...@gmail.com>.
Hi, JB
Thanks for your suggestion. I didn't summarize them now, will update.
On Fri, 22 Jul 2022 at 21:40, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Hi,
>
> It's a good approach.
>
> Don't forget to summarize the different licenses and projects used in
> the NOTICE file as well.
>
> Thanks !
>
> Regards
> JB
>
> On Fri, Jul 22, 2022 at 8:33 AM hulk <hu...@gmail.com> wrote:
> >
> > Thanks, Twice
> >
> > Yes, I saw most projects put those licenses after the License file, so I
> > follow them.
> >
> > On Thu, 21 Jul 2022 at 23:46, Twice <tw...@gmail.com> wrote:
> >
> > > Hi Hulk,
> > >
> > > I thought we can put it next to `licenses/LICENSE.redis` before,
> > > but it seems some Apache projects did append these dependency licenses
> > > directly to LICENSE,
> > > so it is good for me now.
> > >
> > > Twice
> > >
> > > On Thu, Jul 21, 2022 at 10:48 PM hulk <hu...@gmail.com> wrote:
> > >
> > > > I tried to add the license notice for dependencies in the below PR:
> > > >
> > > > https://github.com/apache/incubator-kvrocks/pull/744/files
> > > >
> > > > Does this look good to you?
> > > >
> > > > On Thu, 21 Jul 2022 at 18:35, hulk <hu...@gmail.com> wrote:
> > > >
> > > > > Hi, all
> > > > >
> > > > > In the vote thread of Kvrocks 2.1.0:
> > > > > https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll.
> > > > >
> > > > > JB and Xiaoqiao reminded us that we should also declare licenses
> for
> > > > > Kvrocks dependencies.
> > > > > But I'm not sure how can we declare since we only fetch them when
> > > > building
> > > > > the binary,
> > > > > and didn't bundle them directly in source codes.
> > > > >
> > > > > --
> > > > > Best Regards,
> > > > > - *Hulk Lin*
> > > > >
> > > >
> > > >
> > > > --
> > > > Best Regards,
> > > > - *Hulk Lin*
> > > >
> > >
> >
> >
> > --
> > Best Regards,
> > - *Hulk Lin*
>
--
Best Regards,
- *Hulk Lin*
Re: How to claim the license in Kvrocks release
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi,
It's a good approach.
Don't forget to summarize the different licenses and projects used in
the NOTICE file as well.
Thanks !
Regards
JB
On Fri, Jul 22, 2022 at 8:33 AM hulk <hu...@gmail.com> wrote:
>
> Thanks, Twice
>
> Yes, I saw most projects put those licenses after the License file, so I
> follow them.
>
> On Thu, 21 Jul 2022 at 23:46, Twice <tw...@gmail.com> wrote:
>
> > Hi Hulk,
> >
> > I thought we can put it next to `licenses/LICENSE.redis` before,
> > but it seems some Apache projects did append these dependency licenses
> > directly to LICENSE,
> > so it is good for me now.
> >
> > Twice
> >
> > On Thu, Jul 21, 2022 at 10:48 PM hulk <hu...@gmail.com> wrote:
> >
> > > I tried to add the license notice for dependencies in the below PR:
> > >
> > > https://github.com/apache/incubator-kvrocks/pull/744/files
> > >
> > > Does this look good to you?
> > >
> > > On Thu, 21 Jul 2022 at 18:35, hulk <hu...@gmail.com> wrote:
> > >
> > > > Hi, all
> > > >
> > > > In the vote thread of Kvrocks 2.1.0:
> > > > https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll.
> > > >
> > > > JB and Xiaoqiao reminded us that we should also declare licenses for
> > > > Kvrocks dependencies.
> > > > But I'm not sure how can we declare since we only fetch them when
> > > building
> > > > the binary,
> > > > and didn't bundle them directly in source codes.
> > > >
> > > > --
> > > > Best Regards,
> > > > - *Hulk Lin*
> > > >
> > >
> > >
> > > --
> > > Best Regards,
> > > - *Hulk Lin*
> > >
> >
>
>
> --
> Best Regards,
> - *Hulk Lin*
Re: How to claim the license in Kvrocks release
Posted by hulk <hu...@gmail.com>.
Thanks, Twice
Yes, I saw most projects put those licenses after the License file, so I
follow them.
On Thu, 21 Jul 2022 at 23:46, Twice <tw...@gmail.com> wrote:
> Hi Hulk,
>
> I thought we can put it next to `licenses/LICENSE.redis` before,
> but it seems some Apache projects did append these dependency licenses
> directly to LICENSE,
> so it is good for me now.
>
> Twice
>
> On Thu, Jul 21, 2022 at 10:48 PM hulk <hu...@gmail.com> wrote:
>
> > I tried to add the license notice for dependencies in the below PR:
> >
> > https://github.com/apache/incubator-kvrocks/pull/744/files
> >
> > Does this look good to you?
> >
> > On Thu, 21 Jul 2022 at 18:35, hulk <hu...@gmail.com> wrote:
> >
> > > Hi, all
> > >
> > > In the vote thread of Kvrocks 2.1.0:
> > > https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll.
> > >
> > > JB and Xiaoqiao reminded us that we should also declare licenses for
> > > Kvrocks dependencies.
> > > But I'm not sure how can we declare since we only fetch them when
> > building
> > > the binary,
> > > and didn't bundle them directly in source codes.
> > >
> > > --
> > > Best Regards,
> > > - *Hulk Lin*
> > >
> >
> >
> > --
> > Best Regards,
> > - *Hulk Lin*
> >
>
--
Best Regards,
- *Hulk Lin*
Re: How to claim the license in Kvrocks release
Posted by Twice <tw...@gmail.com>.
Hi Hulk,
I thought we can put it next to `licenses/LICENSE.redis` before,
but it seems some Apache projects did append these dependency licenses
directly to LICENSE,
so it is good for me now.
Twice
On Thu, Jul 21, 2022 at 10:48 PM hulk <hu...@gmail.com> wrote:
> I tried to add the license notice for dependencies in the below PR:
>
> https://github.com/apache/incubator-kvrocks/pull/744/files
>
> Does this look good to you?
>
> On Thu, 21 Jul 2022 at 18:35, hulk <hu...@gmail.com> wrote:
>
> > Hi, all
> >
> > In the vote thread of Kvrocks 2.1.0:
> > https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll.
> >
> > JB and Xiaoqiao reminded us that we should also declare licenses for
> > Kvrocks dependencies.
> > But I'm not sure how can we declare since we only fetch them when
> building
> > the binary,
> > and didn't bundle them directly in source codes.
> >
> > --
> > Best Regards,
> > - *Hulk Lin*
> >
>
>
> --
> Best Regards,
> - *Hulk Lin*
>
Re: How to claim the license in Kvrocks release
Posted by hulk <hu...@gmail.com>.
I tried to add the license notice for dependencies in the below PR:
https://github.com/apache/incubator-kvrocks/pull/744/files
Does this look good to you?
On Thu, 21 Jul 2022 at 18:35, hulk <hu...@gmail.com> wrote:
> Hi, all
>
> In the vote thread of Kvrocks 2.1.0:
> https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll.
>
> JB and Xiaoqiao reminded us that we should also declare licenses for
> Kvrocks dependencies.
> But I'm not sure how can we declare since we only fetch them when building
> the binary,
> and didn't bundle them directly in source codes.
>
> --
> Best Regards,
> - *Hulk Lin*
>
--
Best Regards,
- *Hulk Lin*