Re: [PR] [FLINK-36578][MySQL] Add table information of binlog offsets when checkpointing added modified JsonStringFormatter [flink-cdc]

["SML0127 (via GitHub)" <gi...@apache.org>]

SML0127 commented on code in PR #3658:
URL: https://github.com/apache/flink-cdc/pull/3658#discussion_r1845337807


##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlFullTypesITCase.java:
##########
@@ -412,7 +412,7 @@ private void testCommonDataTypes(UniqueDatabase database) throws Exception {
 
         expectedSnapshot[30] = null;
         // The json string from binlog will remove useless space
-        expectedSnapshot[44] = BinaryStringData.fromString("{\"key1\":\"value1\"}");
+        expectedSnapshot[44] = BinaryStringData.fromString("{\"key1\": \"value1\"}");

Review Comment:
   Resolved



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org