You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/06 16:38:48 UTC

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10529: fix: misaligned LimitControl buttons and port jsx->tsx

mistercrunch commented on a change in pull request #10529:
URL: https://github.com/apache/incubator-superset/pull/10529#discussion_r466541595



##########
File path: superset-frontend/src/SqlLab/components/LimitControl.tsx
##########
@@ -99,18 +110,21 @@ export default class LimitControl extends React.PureComponent {
               value={textValue}
               placeholder={t(`Max: ${this.props.maxRow}`)}
               bsSize="small"
-              onChange={e => this.setState({ textValue: e.target.value })}
+              // @ts-ignore

Review comment:
       Following the pattern in other files `src/explore/components/PropertiesModal.tsx`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org