You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by po...@apache.org on 2026/10/25 18:03:57 UTC

(magpie) branch main updated: docs(setup): keep the old checker until the new copy works (#1747)

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/magpie.git


The following commit(s) were added to refs/heads/main by this push:
     new 58d5093ae docs(setup): keep the old checker until the new copy works (#1747)
58d5093ae is described below

commit 58d5093ae7079f3f1bcd6c203175e1be8419c52b
Author: Eldho Thomas <el...@gmail.com>
AuthorDate: Sun Oct 25 14:03:52 2026 -0400

    docs(setup): keep the old checker until the new copy works (#1747)
    
    * docs(setup): check the new pre-flight package before replacing the old one
    
    * docs(setup): clarify safe preflight refresh in sandboxed installs
    
    * docs(setup): keep marketplace refresh instructions runnable
    
    * docs(setup): contain refresh failures in a subshell
---
 plugins/magpie-setup/skills/setup/upgrade.md | 30 ++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/plugins/magpie-setup/skills/setup/upgrade.md b/plugins/magpie-setup/skills/setup/upgrade.md
index b2f9fb529..7bb72b5b8 100644
--- a/plugins/magpie-setup/skills/setup/upgrade.md
+++ b/plugins/magpie-setup/skills/setup/upgrade.md
@@ -419,6 +419,36 @@ Copy the files, not a link to them.
 same package, so a plain `cp -R` from it leaves a link in the personal
 layer that points nowhere.
 Copy from the skill's directory, or follow the link with `cp -RL`.
+For marketplace installs, use the `setup_preflight/` directory next
+to this skill in the installed plugin. Get the destination from
+`python3 -m setup_preflight.layers` as in
+[`config` Step 0](config.md#step-0--pre-flight).
+The marketplace cache under `~/.claude/plugins/cache/` is read-denied
+to a sandboxed shell. For a marketplace install, ask the user to run
+the following commands in their own terminal, outside the sandbox.
+For a readable snapshot install, the commands can run in the sandbox.
+
+Set `source_dir` to that installed skill's `setup_preflight/` directory
+and `personal_dir` to the directory reported by `setup_preflight.layers`
+before running the commands. Use their actual paths, not placeholders.
+Check the new copy before replacing the old one:
+
+```bash
+(
+  target="$personal_dir/setup_preflight"
+
+  if [ -e "$target" ] || [ -L "$target" ]; then
+    temp="$(mktemp -d "$personal_dir/.preflight.XXXXXX")" || exit 1
+    cp -RL "$source_dir" "$temp/setup_preflight" &&
+      PYTHONPATH="$temp" python3 -P -m setup_preflight --skill magpie-setup --no-welcome ||
+      { rm -rf "$temp"; exit 1; }
+    mv "$target" "$temp/old" || { rm -rf "$temp"; exit 1; }
+    mv "$temp/setup_preflight" "$target" ||
+      { mv "$temp/old" "$target"; exit 1; }
+    rm -rf "$temp"
+  fi
+)
+```
 
 The fresh copy also carries the new version's isolated-setup
 fingerprint. When the secure-setup files changed in this upgrade, the