You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David Glasser <gl...@davidglasser.net> on 2007/11/07 19:23:08 UTC
hook security
Do you think it's worth adding explicit notes to the comments in the
hook templates the fact that the argument values should always be
"$QUOTED" in the hook script?
This is especially the case for the PROPNAME arguments to the revprop
change scripts, which are essentially passed through blindly from the
client. (There is a *client-side* validity check, which is
irrelevant, and a check that it isn't an svn:wc: or svn:entry: prop;
and perhaps mod_dav_svn imposes other restrictions that I'm not
familiar with, but at least with svnserve a custom RA-driving client
could totally set the "foo; rm -rf /;" property.
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: hook security
Posted by Karl Fogel <kf...@red-bean.com>.
Blair Zajac <bl...@orcaware.com> writes:
> David Glasser wrote:
>> Do you think it's worth adding explicit notes to the comments in the
>> hook templates the fact that the argument values should always be
>> "$QUOTED" in the hook script?
>>
>> This is especially the case for the PROPNAME arguments to the revprop
>> change scripts, which are essentially passed through blindly from the
>> client. (There is a *client-side* validity check, which is
>> irrelevant, and a check that it isn't an svn:wc: or svn:entry: prop;
>> and perhaps mod_dav_svn imposes other restrictions that I'm not
>> familiar with, but at least with svnserve a custom RA-driving client
>> could totally set the "foo; rm -rf /;" property.
>>
>> --dave
>
> +1.
+1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: hook security
Posted by Blair Zajac <bl...@orcaware.com>.
David Glasser wrote:
> Do you think it's worth adding explicit notes to the comments in the
> hook templates the fact that the argument values should always be
> "$QUOTED" in the hook script?
>
> This is especially the case for the PROPNAME arguments to the revprop
> change scripts, which are essentially passed through blindly from the
> client. (There is a *client-side* validity check, which is
> irrelevant, and a check that it isn't an svn:wc: or svn:entry: prop;
> and perhaps mod_dav_svn imposes other restrictions that I'm not
> familiar with, but at least with svnserve a custom RA-driving client
> could totally set the "foo; rm -rf /;" property.
>
> --dave
+1.
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org