You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by Oz M <oz...@gmail.com> on 2013/06/04 02:25:54 UTC

Adding unit tests to org.apache.tomee.util.SimpleTomEEFormatter

Hello,

It is my very first e-mail to that group and I am sorry if I am asking
newbies questions.

I noticed that there are no unit tests to SimpleTomEEFormatter class.
I decided to start simple (as recommended in the project site) and I wrote
unit tests for it.
During the tests creation I noticed that I can even make a small change
that makes SimpleTomEEFormatter#format() a little bit less verbose keeping
the same functionality.

*My questions are:*
Should I raise a JIRA for that with my patch?
How can I make sure that  there is no JIRA in regard to the class's unit
tests?
How do I follow the progress status until the changes will be committed
successfully?

*A patch which reflects both changes is attached.*

Thank you very much and sorry for being verbose myself ;)
Oz Molaim

Re: Adding unit tests to org.apache.tomee.util.SimpleTomEEFormatter

Posted by Romain Manni-Bucau <rm...@gmail.com>.

We take the jar extract the class and run a java command so we need to
ensure this clzss doesnt depend on sthg not in the classpath
Le 5 juin 2013 00:33, "Oz M" <oz...@gmail.com> a écrit :

> *Romain,*
> *Thank you very much for committing the unit tests.*
> *
> *
> Just for general knowledge, what is the reason we cannot use dependencies
> in SimpleTomEEFormatter class.
> I did not understand exactly what you have said in the JIRA (- '...enrich
> sometimes...').
>
> Oz Molaim
>
>
>
> O
>
> 2013/6/4 Oz M <oz...@gmail.com>
>
> > ... Now attached ;)
> >
> >
> > 2013/6/4 Oz M <oz...@gmail.com>
> >
> >> Thank you very much Romain.
> >> I am attaching the updated patch with your comment included.
> >>
> >> I also updated the JIRA with the new file.
> >>
> >> Please refer only to the new file.
> >>
> >> Thank you for the review,
> >> Oz Molaim
> >>
> >>
> >> 2013/6/4 Romain Manni-Bucau <rm...@gmail.com>
> >>
> >>> Please dont rely on commons-lang (can be removed), you can rely on
> >>> commons-lang3
> >>> Le 4 juin 2013 08:53, "Oz M" <oz...@gmail.com> a écrit :
> >>>
> >>> > I have raised a JIRA witch contains a patch about it:
> >>> > https://issues.apache.org/jira/browse/TOMEE-961
> >>> >
> >>> > Thank you,
> >>> > Oz Molaim
> >>> >
> >>> > 2013/6/4 Oz M <oz...@gmail.com>
> >>> >
> >>> > >  The patch is now attached.
> >>> > >
> >>> > >
> >>> > >
> >>> > >  2013/6/4 Romain Manni-Bucau <rm...@gmail.com>
> >>> > >
> >>> > >> Hi
> >>> > >>
> >>> > >> I dont see the attached file but feel free to attach a jira. You
> >>> will be
> >>> > >> notified by mail of the status of the issues.
> >>> > >>
> >>> > >> Note: not sure what less verbose means for you here but typically
> >>> > removing
> >>> > >> "final" or brackets is not one thing making less verbose the code
> >>> (it is
> >>> > >> error prone then)
> >>> > >> Le 4 juin 2013 02:26, "Oz M" <oz...@gmail.com> a écrit :
> >>> > >>
> >>> > >> > Hello,
> >>> > >> >
> >>> > >> > It is my very first e-mail to that group and I am sorry if I am
> >>> asking
> >>> > >> > newbies questions.
> >>> > >> >
> >>> > >> > I noticed that there are no unit tests to SimpleTomEEFormatter
> >>> class.
> >>> > >> > I decided to start simple (as recommended in the project site)
> >>> and I
> >>> > >> wrote
> >>> > >> > unit tests for it.
> >>> > >> > During the tests creation I noticed that I can even make a small
> >>> > change
> >>> > >> > that makes SimpleTomEEFormatter#format() a little bit less
> verbose
> >>> > >> keeping
> >>> > >> > the same functionality.
> >>> > >> >
> >>> > >> > *My questions are:*
> >>> > >> > Should I raise a JIRA for that with my patch?
> >>> > >> > How can I make sure that  there is no JIRA in regard to the
> >>> class's
> >>> > unit
> >>> > >> > tests?
> >>> > >> > How do I follow the progress status until the changes will be
> >>> > committed
> >>> > >> > successfully?
> >>> > >> >
> >>> > >> > *A patch which reflects both changes is attached.*
> >>> > >>  >
> >>> > >> > Thank you very much and sorry for being verbose myself ;)
> >>> > >> > Oz Molaim
> >>> > >> >
> >>> > >> >
> >>> > >> >
> >>> > >> >
> >>> > >> >
> >>> > >>
> >>> > >
> >>> > >
> >>> > >
> >>> > > --
> >>> > > בברכה,
> >>> > > עוז מולאים
> >>> > >
> >>> > >
> >>> >
> >>> > --
> >>> > בבר
> >>>
> >>
>