You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "HolyLow (via GitHub)" <gi...@apache.org> on 2025/05/09 08:16:35 UTC

[PR] [CELEBORN-1978][CIP-14] Add code style checking for cppClient [celeborn]

HolyLow opened a new pull request, #3252:
URL: https://github.com/apache/celeborn/pull/3252

   ### What changes were proposed in this pull request?
   This PR adds code style checking in github action for cppClient.
   
   ### Why are the changes needed?
   To keep the cpp code style consistent.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   By github action procedure.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1978][CIP-14] Add code style checking for cppClient [celeborn]

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #3252: [CELEBORN-1978][CIP-14] Add code style checking for cppClient
URL: https://github.com/apache/celeborn/pull/3252


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1978][CIP-14] Add code style checking for cppClient [celeborn]

Posted by "HolyLow (via GitHub)" <gi...@apache.org>.
HolyLow commented on PR #3252:
URL: https://github.com/apache/celeborn/pull/3252#issuecomment-2865850700

   @FMX @RexXiong Could you kindly help review this PR? Thanks a lot.
   
   Note that the dev image is updated to `holylow/celeborn-cpp-dev:0.3` to support clang-format within the dev container.
   
   Any suggestion is welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org