[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #760: [Issue #655] Adding send message constraints for message size and batch size

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #760:
URL: https://github.com/apache/incubator-eventmesh/pull/760#discussion_r804831554



##########
File path: eventmesh-runtime/conf/eventmesh.properties
##########
@@ -39,6 +39,9 @@ eventMesh.server.tcp.msgReqnumPerSecond=15000
 eventMesh.server.http.msgReqnumPerSecond=15000
 eventMesh.server.session.upstreamBufferSize=20
 
+eventmesh.server.eventSize=1000
+eventmesh.server.eventBatchSize=10

Review comment:
       Maybe it's better to change to 
   ```
   eventmesh.server.maxEventPerLength=1000
   eventmesh.server.maxEventBatchSize=10
   ```
   And add some comments on this config can help user easy to understand.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org