You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Lavkesh Lahngir <la...@gmail.com> on 2016/09/15 10:07:21 UTC
Review Request 51907: limiting max scheduled job per user
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51907/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1320
https://issues.apache.org/jira/browse/LENS-1320
Repository: lens
Description
-------
It's a part of checking validity of submitted job.
Diffs
-----
lens-api/src/main/resources/lens-errors.conf 162fb1de8b296ea42704e09039e8a90684956054
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8f1983ee10e9e4a429dc1c8ceb5d4a65bab975c1
lens-server/src/main/java/org/apache/lens/server/error/LensSchedulerErrorCode.java 12c48519ffb1e0d02a63a702315a443558434b79
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java b924167fb819b3baae6be14efbb085fe72f99f54
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 969d7403ddc0cb2a8bfa59ffde64ea249714a08e
lens-server/src/main/resources/lensserver-default.xml 84ff9f9e42015da570eae94bf9748aa090417bae
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java 16a6c78ba5b36e3a164646fec6c2aca9f032d03e
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java de364994ebf70ba92692f1745bf254b1c0046d79
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java aa5c89712b0c090f2d7eb66f001744634727e76a
lens-server/src/test/resources/lens-site.xml 7d72928a1f3c9478e5256defa524d53fc8c89432
src/site/apt/admin/config.apt 24d5fd6e9bcfc38b6543ffc8ac16a32a025d70c5
Diff: https://reviews.apache.org/r/51907/diff/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 51907: limiting max scheduled job per user
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51907/#review149637
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Sept. 19, 2016, 3:30 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51907/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 3:30 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1320
> https://issues.apache.org/jira/browse/LENS-1320
>
>
> Repository: lens
>
>
> Description
> -------
>
> It's a part of checking validity of submitted job.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 162fb1d
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8f1983e
> lens-server/src/main/java/org/apache/lens/server/error/LensSchedulerErrorCode.java 12c4851
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java b924167
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 969d740
> lens-server/src/main/resources/lensserver-default.xml 84ff9f9
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java 16a6c78
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java de36499
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java aa5c897
> lens-server/src/test/resources/lens-site.xml 7d72928
> src/site/apt/admin/config.apt 24d5fd6
>
> Diff: https://reviews.apache.org/r/51907/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 51907: limiting max scheduled job per user
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51907/
-----------------------------------------------------------
(Updated Sept. 19, 2016, 3:30 p.m.)
Review request for lens.
Bugs: LENS-1320
https://issues.apache.org/jira/browse/LENS-1320
Repository: lens
Description
-------
It's a part of checking validity of submitted job.
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 162fb1d
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8f1983e
lens-server/src/main/java/org/apache/lens/server/error/LensSchedulerErrorCode.java 12c4851
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java b924167
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 969d740
lens-server/src/main/resources/lensserver-default.xml 84ff9f9
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java 16a6c78
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java de36499
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java aa5c897
lens-server/src/test/resources/lens-site.xml 7d72928
src/site/apt/admin/config.apt 24d5fd6
Diff: https://reviews.apache.org/r/51907/diff/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 51907: limiting max scheduled job per user
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51907/#review149043
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java (line 497)
<https://reviews.apache.org/r/51907/#comment216585>
Should we make it IN clause instead of OR ?
- Amareshwari Sriramadasu
On Sept. 15, 2016, 10:07 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51907/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2016, 10:07 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1320
> https://issues.apache.org/jira/browse/LENS-1320
>
>
> Repository: lens
>
>
> Description
> -------
>
> It's a part of checking validity of submitted job.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 162fb1de8b296ea42704e09039e8a90684956054
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8f1983ee10e9e4a429dc1c8ceb5d4a65bab975c1
> lens-server/src/main/java/org/apache/lens/server/error/LensSchedulerErrorCode.java 12c48519ffb1e0d02a63a702315a443558434b79
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java b924167fb819b3baae6be14efbb085fe72f99f54
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 969d7403ddc0cb2a8bfa59ffde64ea249714a08e
> lens-server/src/main/resources/lensserver-default.xml 84ff9f9e42015da570eae94bf9748aa090417bae
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java 16a6c78ba5b36e3a164646fec6c2aca9f032d03e
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java de364994ebf70ba92692f1745bf254b1c0046d79
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java aa5c89712b0c090f2d7eb66f001744634727e76a
> lens-server/src/test/resources/lens-site.xml 7d72928a1f3c9478e5256defa524d53fc8c89432
> src/site/apt/admin/config.apt 24d5fd6e9bcfc38b6543ffc8ac16a32a025d70c5
>
> Diff: https://reviews.apache.org/r/51907/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>