[GitHub] [accumulo] cradal commented on a change in pull request #1637: #1618 Investigate TODO in exception message in new Bulk Import

[GitBox <gi...@apache.org>]

cradal commented on a change in pull request #1637:
URL: https://github.com/apache/accumulo/pull/1637#discussion_r450954434



##########
File path: core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java
##########
@@ -616,7 +616,9 @@ private Text toText(byte[] row) {
         if (containsPrevRow && containsEndRow) {
           mappings.get(ke).merge(mappings.remove(oke));
         } else {
-          throw new RuntimeException("TODO handle merges");
+          throw new RuntimeException("Unable to execute merge. Key extent "
+                  + oke.toString() + " extends beyond the range of Key extent "
+                  + ke.toString() + ". Out of range data would be lost.");

Review comment:
       @keith-turner I agree this is better than the original. We can remove the 2 booleans from lines 611-614, making things more succinct. I will update the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org