You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/28 14:26:18 UTC
[GitHub] [arrow] rok opened a new pull request #12732: ARROW-15665: [C++] Add error handling option to StrptimeOptions - follow up
rok opened a new pull request #12732:
URL: https://github.com/apache/arrow/pull/12732
As reported by @dragosmg the following:
```
std::string input2 = R"(["5-1-2020", "12/13/1900"])";
std::string output2 = R"([null, "1900-12-13"])";
Strptime(input2)
```
Would cause:
```
Expected:
[
null,
1900-12-13 00:00:00.000000
]
Actual:
[
null,
1970-01-01 00:00:00.000000
]
```
This was due to out_data pointer not updating on failed parsing.
This change fixes the issue and adds a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12732: ARROW-15665: [C++] Fix error_is_null in strptime with invalid inputs
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12732:
URL: https://github.com/apache/arrow/pull/12732#issuecomment-1081189309
Benchmark runs are scheduled for baseline = f4dfd6c37731eb0cd5056618e8e547066bcbfe70 and contender = 6a0770ccae33d471cf26d06f21b74bc0e7ef5b5d. 6a0770ccae33d471cf26d06f21b74bc0e7ef5b5d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0393bade894c45c98a6178ee87a35921...d5348128d9ac43b29659dc97cbceeb4f/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9a5ecb3b3b7749fa98373e6c3ffe870b...439dd74ec37243f5bb8981be1bd336ce/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/22dd2f8eccb74dd584e174c6eaafafbe...ede0c1941d4f4897a7c73b4ad4945e8b/)
[Finished :arrow_down:1.02% :arrow_up:0.3%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/14fa3b149d6b4cebb2b834c3647c9433...8551d59e4fb542948923d7714337b9ab/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12732: ARROW-15665: [C++] Fix error_is_null in strptime with invalid inputs
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12732:
URL: https://github.com/apache/arrow/pull/12732#issuecomment-1081189309
Benchmark runs are scheduled for baseline = f4dfd6c37731eb0cd5056618e8e547066bcbfe70 and contender = 6a0770ccae33d471cf26d06f21b74bc0e7ef5b5d. 6a0770ccae33d471cf26d06f21b74bc0e7ef5b5d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0393bade894c45c98a6178ee87a35921...d5348128d9ac43b29659dc97cbceeb4f/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9a5ecb3b3b7749fa98373e6c3ffe870b...439dd74ec37243f5bb8981be1bd336ce/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/22dd2f8eccb74dd584e174c6eaafafbe...ede0c1941d4f4897a7c73b4ad4945e8b/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/14fa3b149d6b4cebb2b834c3647c9433...8551d59e4fb542948923d7714337b9ab/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12732: ARROW-15665: [C++] Add error handling option to StrptimeOptions - follow up
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12732:
URL: https://github.com/apache/arrow/pull/12732#issuecomment-1080725850
@lidavidm I'm a bit embarrassed by this one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12732: ARROW-15665: [C++] Fix error_is_null in strptime with invalid inputs
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12732:
URL: https://github.com/apache/arrow/pull/12732#issuecomment-1081189309
Benchmark runs are scheduled for baseline = f4dfd6c37731eb0cd5056618e8e547066bcbfe70 and contender = 6a0770ccae33d471cf26d06f21b74bc0e7ef5b5d. 6a0770ccae33d471cf26d06f21b74bc0e7ef5b5d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0393bade894c45c98a6178ee87a35921...d5348128d9ac43b29659dc97cbceeb4f/)
[Finished :arrow_down:0.38% :arrow_up:0.13%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9a5ecb3b3b7749fa98373e6c3ffe870b...439dd74ec37243f5bb8981be1bd336ce/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/22dd2f8eccb74dd584e174c6eaafafbe...ede0c1941d4f4897a7c73b4ad4945e8b/)
[Finished :arrow_down:1.02% :arrow_up:0.3%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/14fa3b149d6b4cebb2b834c3647c9433...8551d59e4fb542948923d7714337b9ab/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12732: ARROW-15665: [C++] Add error handling option to StrptimeOptions - follow up
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12732:
URL: https://github.com/apache/arrow/pull/12732#issuecomment-1080943505
https://issues.apache.org/jira/browse/ARROW-15665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12732: ARROW-15665: [C++] Fix error_is_null in strptime with invalid inputs
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12732:
URL: https://github.com/apache/arrow/pull/12732#issuecomment-1081189309
Benchmark runs are scheduled for baseline = f4dfd6c37731eb0cd5056618e8e547066bcbfe70 and contender = 6a0770ccae33d471cf26d06f21b74bc0e7ef5b5d. 6a0770ccae33d471cf26d06f21b74bc0e7ef5b5d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0393bade894c45c98a6178ee87a35921...d5348128d9ac43b29659dc97cbceeb4f/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9a5ecb3b3b7749fa98373e6c3ffe870b...439dd74ec37243f5bb8981be1bd336ce/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/22dd2f8eccb74dd584e174c6eaafafbe...ede0c1941d4f4897a7c73b4ad4945e8b/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/14fa3b149d6b4cebb2b834c3647c9433...8551d59e4fb542948923d7714337b9ab/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12732: ARROW-15665: [C++] Fix error_is_null in strptime with invalid inputs
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12732:
URL: https://github.com/apache/arrow/pull/12732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12732: ARROW-15665: [C++] Fix error_is_null in strptime with invalid inputs
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12732:
URL: https://github.com/apache/arrow/pull/12732#issuecomment-1081189309
Benchmark runs are scheduled for baseline = f4dfd6c37731eb0cd5056618e8e547066bcbfe70 and contender = 6a0770ccae33d471cf26d06f21b74bc0e7ef5b5d. 6a0770ccae33d471cf26d06f21b74bc0e7ef5b5d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0393bade894c45c98a6178ee87a35921...d5348128d9ac43b29659dc97cbceeb4f/)
[Finished :arrow_down:0.38% :arrow_up:0.13%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9a5ecb3b3b7749fa98373e6c3ffe870b...439dd74ec37243f5bb8981be1bd336ce/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/22dd2f8eccb74dd584e174c6eaafafbe...ede0c1941d4f4897a7c73b4ad4945e8b/)
[Finished :arrow_down:1.02% :arrow_up:0.3%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/14fa3b149d6b4cebb2b834c3647c9433...8551d59e4fb542948923d7714337b9ab/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org