You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/23 11:14:18 UTC
[GitHub] [inlong-website] bluewang opened a new pull request, #449: [INLONG-447] Standardized Version Variables
bluewang opened a new pull request, #449:
URL: https://github.com/apache/inlong-website/pull/449
Fixes https://github.com/apache/inlong-website/issues/447
where *XYZ* should be replaced by the actual issue number.
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] dockerzhang merged pull request #449: [INLONG-447] Standardized Version Variables
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #449:
URL: https://github.com/apache/inlong-website/pull/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] gong commented on a diff in pull request #449: [INLONG-447] Standardized Version Variables
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #449:
URL: https://github.com/apache/inlong-website/pull/449#discussion_r905916764
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/version.js:
##########
@@ -0,0 +1,3 @@
+export const siteVariables = {
+ inLongVersion: '1.3.0-SNAPSHOT中c',
Review Comment:
Is it right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] gong commented on a diff in pull request #449: [INLONG-447] Standardized Version Variables
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #449:
URL: https://github.com/apache/inlong-website/pull/449#discussion_r905910532
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/data_node/load_node/sqlserver.md:
##########
@@ -15,18 +17,18 @@ sidebar_position: 14
## 依赖
-为了设置 SQLServer Load 节点, 下面提供了使用构建自动化工具（例如 Maven 或 SBT）和带有 Sort Connector JAR 包的 SQL 客户端的两个项目的依赖关系信息。
+为了设置 SQLServer Load 节点, 下面提供了使用构建自动化工具（例如 Maven 或 version）和带有 Sort Connector JAR 包的 SQL 客户端的两个项目的依赖关系信息。
Review Comment:
You should not change SBT to version. SBT is a build tool like maven
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] gong commented on a diff in pull request #449: [INLONG-447] Standardized Version Variables
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #449:
URL: https://github.com/apache/inlong-website/pull/449#discussion_r905909822
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/data_node/load_node/oracle.md:
##########
@@ -15,18 +17,18 @@ sidebar_position: 12
## 依赖
-为了设置 Oracle Load 节点, 下面提供了使用构建自动化工具（例如 Maven 或 SBT）和带有 Sort Connector JAR 包的 SQL 客户端的两个项目的依赖关系信息。
+为了设置 Oracle Load 节点, 下面提供了使用构建自动化工具（例如 Maven 或 version）和带有 Sort Connector JAR 包的 SQL 客户端的两个项目的依赖关系信息。
Review Comment:
You should not change `SBT` to `version`. `SBT` is a build tool like `maven`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] leezng commented on a diff in pull request #449: [INLONG-447] Standardized Version Variables
Posted by GitBox <gi...@apache.org>.
leezng commented on code in PR #449:
URL: https://github.com/apache/inlong-website/pull/449#discussion_r905745278
##########
docs/version.js:
##########
@@ -0,0 +1,3 @@
+export const siteVariables = {
+ inLongVersion: '1.3.0-SNAPSHOT[[[[[[',
Review Comment:
is it ok?
##########
versioned_docs/version-1.2.0/version.js:
##########
@@ -0,0 +1,3 @@
+export const siteVariables = {
+ inLongVersion: '1.2.0-incubating}}}}}}}}',
Review Comment:
as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] gong commented on a diff in pull request #449: [INLONG-447] Standardized Version Variables
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #449:
URL: https://github.com/apache/inlong-website/pull/449#discussion_r905910359
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/data_node/load_node/postgresql.md:
##########
@@ -16,18 +18,18 @@ sidebar_position: 13
## 依赖
-为了设置 PostgreSQL Load 节点, 下面提供了使用构建自动化工具（例如 Maven 或 SBT）和带有 Sort Connector JAR 包的 SQL 客户端的两个项目的依赖关系信息。
+为了设置 PostgreSQL Load 节点, 下面提供了使用构建自动化工具（例如 Maven 或 version）和带有 Sort Connector JAR 包的 SQL 客户端的两个项目的依赖关系信息。
Review Comment:
You should not change SBT to version. SBT is a build tool like maven
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] gong commented on a diff in pull request #449: [INLONG-447] Standardized Version Variables
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #449:
URL: https://github.com/apache/inlong-website/pull/449#discussion_r905913308
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/data_node/load_node/tdsql-postgresql.md:
##########
@@ -15,18 +17,18 @@ sidebar_position: 15
## 依赖
-为了设置 TDSQL-PostgreSQL Load 节点, 下面提供了使用构建自动化工具（例如 Maven 或 SBT）和带有 Sort Connector JAR 包的 SQL 客户端的两个项目的依赖关系信息。
+为了设置 TDSQL-PostgreSQL Load 节点, 下面提供了使用构建自动化工具（例如 Maven 或 version）和带有 Sort Connector JAR 包的 SQL 客户端的两个项目的依赖关系信息。
Review Comment:
You should not change `SBT` to `version`. `SBT` is a build tool like `Maven`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] gong commented on a diff in pull request #449: [INLONG-447] Standardized Version Variables
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #449:
URL: https://github.com/apache/inlong-website/pull/449#discussion_r905915434
##########
i18n/zh-CN/docusaurus-plugin-content-docs/version-1.2.0/version.js:
##########
@@ -0,0 +1,3 @@
+export const siteVariables = {
+ inLongVersion: '1.2.0-incubating中2',
Review Comment:
Is it right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org