You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/08/18 14:48:18 UTC
[10/41] hbase-site git commit: Published site at
d159b1f8bb9a29f7786a96c910157e12583768a2.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/7cafc412/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.RegionSplitter.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.RegionSplitter.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.RegionSplitter.html
index 740e531..7aea77c 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.RegionSplitter.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.RegionSplitter.html
@@ -32,411 +32,519 @@
<span class="sourceLineNo">024</span>import java.io.IOException;<a name="line.24"></a>
<span class="sourceLineNo">025</span>import java.util.ArrayList;<a name="line.25"></a>
<span class="sourceLineNo">026</span>import java.util.List;<a name="line.26"></a>
-<span class="sourceLineNo">027</span>import java.util.Random;<a name="line.27"></a>
-<span class="sourceLineNo">028</span>import java.util.Set;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import java.util.TreeSet;<a name="line.29"></a>
-<span class="sourceLineNo">030</span>import java.util.stream.Collectors;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import org.apache.commons.io.IOUtils;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import org.apache.hadoop.conf.Configuration;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.ChoreService;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.HConstants;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.HRegionLocation;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.MetaTableAccessor;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.NotServingRegionException;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.ScheduledChore;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.Stoppable;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.TableName;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.client.Admin;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.client.Connection;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.client.ConnectionFactory;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.client.Get;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.client.Put;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.48"></a>
-<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.client.RegionLocator;<a name="line.49"></a>
-<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.client.Result;<a name="line.50"></a>
-<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.client.Table;<a name="line.51"></a>
-<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.testclassification.LargeTests;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.53"></a>
-<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.util.Pair;<a name="line.54"></a>
-<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.util.PairOfSameType;<a name="line.55"></a>
-<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.util.StoppableImplementation;<a name="line.56"></a>
-<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.util.Threads;<a name="line.57"></a>
-<span class="sourceLineNo">058</span>import org.junit.AfterClass;<a name="line.58"></a>
-<span class="sourceLineNo">059</span>import org.junit.BeforeClass;<a name="line.59"></a>
-<span class="sourceLineNo">060</span>import org.junit.ClassRule;<a name="line.60"></a>
-<span class="sourceLineNo">061</span>import org.junit.Rule;<a name="line.61"></a>
-<span class="sourceLineNo">062</span>import org.junit.Test;<a name="line.62"></a>
-<span class="sourceLineNo">063</span>import org.junit.experimental.categories.Category;<a name="line.63"></a>
-<span class="sourceLineNo">064</span>import org.junit.rules.TestName;<a name="line.64"></a>
-<span class="sourceLineNo">065</span>import org.slf4j.Logger;<a name="line.65"></a>
-<span class="sourceLineNo">066</span>import org.slf4j.LoggerFactory;<a name="line.66"></a>
-<span class="sourceLineNo">067</span><a name="line.67"></a>
-<span class="sourceLineNo">068</span>import org.apache.hbase.thirdparty.com.google.common.collect.Iterators;<a name="line.68"></a>
-<span class="sourceLineNo">069</span><a name="line.69"></a>
-<span class="sourceLineNo">070</span>@Category(LargeTests.class)<a name="line.70"></a>
-<span class="sourceLineNo">071</span>public class TestEndToEndSplitTransaction {<a name="line.71"></a>
-<span class="sourceLineNo">072</span><a name="line.72"></a>
-<span class="sourceLineNo">073</span> @ClassRule<a name="line.73"></a>
-<span class="sourceLineNo">074</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.74"></a>
-<span class="sourceLineNo">075</span> HBaseClassTestRule.forClass(TestEndToEndSplitTransaction.class);<a name="line.75"></a>
-<span class="sourceLineNo">076</span><a name="line.76"></a>
-<span class="sourceLineNo">077</span> private static final Logger LOG = LoggerFactory.getLogger(TestEndToEndSplitTransaction.class);<a name="line.77"></a>
-<span class="sourceLineNo">078</span> private static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.78"></a>
-<span class="sourceLineNo">079</span> private static final Configuration CONF = TEST_UTIL.getConfiguration();<a name="line.79"></a>
-<span class="sourceLineNo">080</span><a name="line.80"></a>
-<span class="sourceLineNo">081</span> @Rule<a name="line.81"></a>
-<span class="sourceLineNo">082</span> public TestName name = new TestName();<a name="line.82"></a>
-<span class="sourceLineNo">083</span><a name="line.83"></a>
-<span class="sourceLineNo">084</span> @BeforeClass<a name="line.84"></a>
-<span class="sourceLineNo">085</span> public static void beforeAllTests() throws Exception {<a name="line.85"></a>
-<span class="sourceLineNo">086</span> TEST_UTIL.getConfiguration().setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 5);<a name="line.86"></a>
-<span class="sourceLineNo">087</span> TEST_UTIL.startMiniCluster();<a name="line.87"></a>
-<span class="sourceLineNo">088</span> }<a name="line.88"></a>
+<span class="sourceLineNo">027</span>import java.util.Map;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import java.util.Random;<a name="line.28"></a>
+<span class="sourceLineNo">029</span>import java.util.Set;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import java.util.TreeSet;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import java.util.concurrent.TimeUnit;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import java.util.stream.Collectors;<a name="line.32"></a>
+<span class="sourceLineNo">033</span><a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.commons.io.IOUtils;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.conf.Configuration;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.ChoreService;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.HConstants;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.HRegionLocation;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.MetaTableAccessor;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.NotServingRegionException;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.ScheduledChore;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.Stoppable;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.TableName;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.client.Admin;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.client.CompactionState;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.client.Connection;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.client.ConnectionFactory;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.client.Get;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.client.Put;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.client.RegionLocator;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.client.Result;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.client.Table;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.client.TableDescriptor;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import org.apache.hadoop.hbase.client.TableDescriptorBuilder;<a name="line.58"></a>
+<span class="sourceLineNo">059</span>import org.apache.hadoop.hbase.testclassification.LargeTests;<a name="line.59"></a>
+<span class="sourceLineNo">060</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.60"></a>
+<span class="sourceLineNo">061</span>import org.apache.hadoop.hbase.util.Pair;<a name="line.61"></a>
+<span class="sourceLineNo">062</span>import org.apache.hadoop.hbase.util.PairOfSameType;<a name="line.62"></a>
+<span class="sourceLineNo">063</span>import org.apache.hadoop.hbase.util.RetryCounter;<a name="line.63"></a>
+<span class="sourceLineNo">064</span>import org.apache.hadoop.hbase.util.StoppableImplementation;<a name="line.64"></a>
+<span class="sourceLineNo">065</span>import org.apache.hadoop.hbase.util.Threads;<a name="line.65"></a>
+<span class="sourceLineNo">066</span>import org.apache.hbase.thirdparty.com.google.common.collect.Iterators;<a name="line.66"></a>
+<span class="sourceLineNo">067</span>import org.apache.hbase.thirdparty.com.google.common.collect.Maps;<a name="line.67"></a>
+<span class="sourceLineNo">068</span>import org.junit.AfterClass;<a name="line.68"></a>
+<span class="sourceLineNo">069</span>import org.junit.Assert;<a name="line.69"></a>
+<span class="sourceLineNo">070</span>import org.junit.BeforeClass;<a name="line.70"></a>
+<span class="sourceLineNo">071</span>import org.junit.ClassRule;<a name="line.71"></a>
+<span class="sourceLineNo">072</span>import org.junit.Rule;<a name="line.72"></a>
+<span class="sourceLineNo">073</span>import org.junit.Test;<a name="line.73"></a>
+<span class="sourceLineNo">074</span>import org.junit.experimental.categories.Category;<a name="line.74"></a>
+<span class="sourceLineNo">075</span>import org.junit.rules.TestName;<a name="line.75"></a>
+<span class="sourceLineNo">076</span>import org.slf4j.Logger;<a name="line.76"></a>
+<span class="sourceLineNo">077</span>import org.slf4j.LoggerFactory;<a name="line.77"></a>
+<span class="sourceLineNo">078</span><a name="line.78"></a>
+<span class="sourceLineNo">079</span>@Category(LargeTests.class)<a name="line.79"></a>
+<span class="sourceLineNo">080</span>public class TestEndToEndSplitTransaction {<a name="line.80"></a>
+<span class="sourceLineNo">081</span><a name="line.81"></a>
+<span class="sourceLineNo">082</span> @ClassRule<a name="line.82"></a>
+<span class="sourceLineNo">083</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.83"></a>
+<span class="sourceLineNo">084</span> HBaseClassTestRule.forClass(TestEndToEndSplitTransaction.class);<a name="line.84"></a>
+<span class="sourceLineNo">085</span><a name="line.85"></a>
+<span class="sourceLineNo">086</span> private static final Logger LOG = LoggerFactory.getLogger(TestEndToEndSplitTransaction.class);<a name="line.86"></a>
+<span class="sourceLineNo">087</span> private static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.87"></a>
+<span class="sourceLineNo">088</span> private static final Configuration CONF = TEST_UTIL.getConfiguration();<a name="line.88"></a>
<span class="sourceLineNo">089</span><a name="line.89"></a>
-<span class="sourceLineNo">090</span> @AfterClass<a name="line.90"></a>
-<span class="sourceLineNo">091</span> public static void afterAllTests() throws Exception {<a name="line.91"></a>
-<span class="sourceLineNo">092</span> TEST_UTIL.shutdownMiniCluster();<a name="line.92"></a>
-<span class="sourceLineNo">093</span> }<a name="line.93"></a>
-<span class="sourceLineNo">094</span><a name="line.94"></a>
-<span class="sourceLineNo">095</span> /**<a name="line.95"></a>
-<span class="sourceLineNo">096</span> * Tests that the client sees meta table changes as atomic during splits<a name="line.96"></a>
-<span class="sourceLineNo">097</span> */<a name="line.97"></a>
-<span class="sourceLineNo">098</span> @Test<a name="line.98"></a>
-<span class="sourceLineNo">099</span> public void testFromClientSideWhileSplitting() throws Throwable {<a name="line.99"></a>
-<span class="sourceLineNo">100</span> LOG.info("Starting testFromClientSideWhileSplitting");<a name="line.100"></a>
-<span class="sourceLineNo">101</span> final TableName tableName = TableName.valueOf(name.getMethodName());<a name="line.101"></a>
-<span class="sourceLineNo">102</span> final byte[] FAMILY = Bytes.toBytes("family");<a name="line.102"></a>
+<span class="sourceLineNo">090</span> @Rule<a name="line.90"></a>
+<span class="sourceLineNo">091</span> public TestName name = new TestName();<a name="line.91"></a>
+<span class="sourceLineNo">092</span><a name="line.92"></a>
+<span class="sourceLineNo">093</span> @BeforeClass<a name="line.93"></a>
+<span class="sourceLineNo">094</span> public static void beforeAllTests() throws Exception {<a name="line.94"></a>
+<span class="sourceLineNo">095</span> TEST_UTIL.getConfiguration().setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 5);<a name="line.95"></a>
+<span class="sourceLineNo">096</span> TEST_UTIL.startMiniCluster();<a name="line.96"></a>
+<span class="sourceLineNo">097</span> }<a name="line.97"></a>
+<span class="sourceLineNo">098</span><a name="line.98"></a>
+<span class="sourceLineNo">099</span> @AfterClass<a name="line.99"></a>
+<span class="sourceLineNo">100</span> public static void afterAllTests() throws Exception {<a name="line.100"></a>
+<span class="sourceLineNo">101</span> TEST_UTIL.shutdownMiniCluster();<a name="line.101"></a>
+<span class="sourceLineNo">102</span> }<a name="line.102"></a>
<span class="sourceLineNo">103</span><a name="line.103"></a>
-<span class="sourceLineNo">104</span> //SplitTransaction will update the meta table by offlining the parent region, and adding info<a name="line.104"></a>
-<span class="sourceLineNo">105</span> //for daughters.<a name="line.105"></a>
-<span class="sourceLineNo">106</span> Table table = TEST_UTIL.createTable(tableName, FAMILY);<a name="line.106"></a>
-<span class="sourceLineNo">107</span><a name="line.107"></a>
-<span class="sourceLineNo">108</span> Stoppable stopper = new StoppableImplementation();<a name="line.108"></a>
-<span class="sourceLineNo">109</span> RegionSplitter regionSplitter = new RegionSplitter(table);<a name="line.109"></a>
-<span class="sourceLineNo">110</span> RegionChecker regionChecker = new RegionChecker(CONF, stopper, tableName);<a name="line.110"></a>
-<span class="sourceLineNo">111</span> final ChoreService choreService = new ChoreService("TEST_SERVER");<a name="line.111"></a>
-<span class="sourceLineNo">112</span><a name="line.112"></a>
-<span class="sourceLineNo">113</span> choreService.scheduleChore(regionChecker);<a name="line.113"></a>
-<span class="sourceLineNo">114</span> regionSplitter.start();<a name="line.114"></a>
-<span class="sourceLineNo">115</span><a name="line.115"></a>
-<span class="sourceLineNo">116</span> //wait until the splitter is finished<a name="line.116"></a>
-<span class="sourceLineNo">117</span> regionSplitter.join();<a name="line.117"></a>
-<span class="sourceLineNo">118</span> stopper.stop(null);<a name="line.118"></a>
+<span class="sourceLineNo">104</span><a name="line.104"></a>
+<span class="sourceLineNo">105</span> /*<a name="line.105"></a>
+<span class="sourceLineNo">106</span> * This is the test for : HBASE-20940 This test will split the region and try to open an reference<a name="line.106"></a>
+<span class="sourceLineNo">107</span> * over store file. Once store file has any reference, it makes sure that region can't be split<a name="line.107"></a>
+<span class="sourceLineNo">108</span> * @throws Exception<a name="line.108"></a>
+<span class="sourceLineNo">109</span> */<a name="line.109"></a>
+<span class="sourceLineNo">110</span> @Test<a name="line.110"></a>
+<span class="sourceLineNo">111</span> public void testCanSplitJustAfterASplit() throws Exception {<a name="line.111"></a>
+<span class="sourceLineNo">112</span> LOG.info("Starting testCanSplitJustAfterASplit");<a name="line.112"></a>
+<span class="sourceLineNo">113</span> byte[] fam = Bytes.toBytes("cf_split");<a name="line.113"></a>
+<span class="sourceLineNo">114</span><a name="line.114"></a>
+<span class="sourceLineNo">115</span> TableName tableName = TableName.valueOf("CanSplitTable");<a name="line.115"></a>
+<span class="sourceLineNo">116</span> Table source = TEST_UTIL.getConnection().getTable(tableName);<a name="line.116"></a>
+<span class="sourceLineNo">117</span> Admin admin = TEST_UTIL.getAdmin();<a name="line.117"></a>
+<span class="sourceLineNo">118</span> Map<String, StoreFileReader> scanner = Maps.newHashMap();<a name="line.118"></a>
<span class="sourceLineNo">119</span><a name="line.119"></a>
-<span class="sourceLineNo">120</span> if (regionChecker.ex != null) {<a name="line.120"></a>
-<span class="sourceLineNo">121</span> throw new AssertionError("regionChecker", regionChecker.ex);<a name="line.121"></a>
-<span class="sourceLineNo">122</span> }<a name="line.122"></a>
+<span class="sourceLineNo">120</span> try {<a name="line.120"></a>
+<span class="sourceLineNo">121</span> TableDescriptor htd = TableDescriptorBuilder.newBuilder(tableName)<a name="line.121"></a>
+<span class="sourceLineNo">122</span> .setColumnFamily(ColumnFamilyDescriptorBuilder.of(fam)).build();<a name="line.122"></a>
<span class="sourceLineNo">123</span><a name="line.123"></a>
-<span class="sourceLineNo">124</span> if (regionSplitter.ex != null) {<a name="line.124"></a>
-<span class="sourceLineNo">125</span> throw new AssertionError("regionSplitter", regionSplitter.ex);<a name="line.125"></a>
-<span class="sourceLineNo">126</span> }<a name="line.126"></a>
-<span class="sourceLineNo">127</span><a name="line.127"></a>
-<span class="sourceLineNo">128</span> //one final check<a name="line.128"></a>
-<span class="sourceLineNo">129</span> regionChecker.verify();<a name="line.129"></a>
-<span class="sourceLineNo">130</span> }<a name="line.130"></a>
-<span class="sourceLineNo">131</span><a name="line.131"></a>
-<span class="sourceLineNo">132</span> static class RegionSplitter extends Thread {<a name="line.132"></a>
-<span class="sourceLineNo">133</span> final Connection connection;<a name="line.133"></a>
-<span class="sourceLineNo">134</span> Throwable ex;<a name="line.134"></a>
-<span class="sourceLineNo">135</span> Table table;<a name="line.135"></a>
-<span class="sourceLineNo">136</span> TableName tableName;<a name="line.136"></a>
-<span class="sourceLineNo">137</span> byte[] family;<a name="line.137"></a>
-<span class="sourceLineNo">138</span> Admin admin;<a name="line.138"></a>
-<span class="sourceLineNo">139</span> HRegionServer rs;<a name="line.139"></a>
-<span class="sourceLineNo">140</span><a name="line.140"></a>
-<span class="sourceLineNo">141</span> RegionSplitter(Table table) throws IOException {<a name="line.141"></a>
-<span class="sourceLineNo">142</span> this.table = table;<a name="line.142"></a>
-<span class="sourceLineNo">143</span> this.tableName = table.getName();<a name="line.143"></a>
-<span class="sourceLineNo">144</span> this.family = table.getTableDescriptor().getFamiliesKeys().iterator().next();<a name="line.144"></a>
-<span class="sourceLineNo">145</span> admin = TEST_UTIL.getAdmin();<a name="line.145"></a>
-<span class="sourceLineNo">146</span> rs = TEST_UTIL.getMiniHBaseCluster().getRegionServer(0);<a name="line.146"></a>
-<span class="sourceLineNo">147</span> connection = TEST_UTIL.getConnection();<a name="line.147"></a>
-<span class="sourceLineNo">148</span> }<a name="line.148"></a>
-<span class="sourceLineNo">149</span><a name="line.149"></a>
-<span class="sourceLineNo">150</span> @Override<a name="line.150"></a>
-<span class="sourceLineNo">151</span> public void run() {<a name="line.151"></a>
-<span class="sourceLineNo">152</span> try {<a name="line.152"></a>
-<span class="sourceLineNo">153</span> Random random = new Random();<a name="line.153"></a>
-<span class="sourceLineNo">154</span> for (int i= 0; i< 5; i++) {<a name="line.154"></a>
-<span class="sourceLineNo">155</span> List<RegionInfo> regions =<a name="line.155"></a>
-<span class="sourceLineNo">156</span> MetaTableAccessor.getTableRegions(connection, tableName, true);<a name="line.156"></a>
-<span class="sourceLineNo">157</span> if (regions.isEmpty()) {<a name="line.157"></a>
-<span class="sourceLineNo">158</span> continue;<a name="line.158"></a>
-<span class="sourceLineNo">159</span> }<a name="line.159"></a>
-<span class="sourceLineNo">160</span> int regionIndex = random.nextInt(regions.size());<a name="line.160"></a>
-<span class="sourceLineNo">161</span><a name="line.161"></a>
-<span class="sourceLineNo">162</span> //pick a random region and split it into two<a name="line.162"></a>
-<span class="sourceLineNo">163</span> RegionInfo region = Iterators.get(regions.iterator(), regionIndex);<a name="line.163"></a>
-<span class="sourceLineNo">164</span><a name="line.164"></a>
-<span class="sourceLineNo">165</span> //pick the mid split point<a name="line.165"></a>
-<span class="sourceLineNo">166</span> int start = 0, end = Integer.MAX_VALUE;<a name="line.166"></a>
-<span class="sourceLineNo">167</span> if (region.getStartKey().length > 0) {<a name="line.167"></a>
-<span class="sourceLineNo">168</span> start = Bytes.toInt(region.getStartKey());<a name="line.168"></a>
-<span class="sourceLineNo">169</span> }<a name="line.169"></a>
-<span class="sourceLineNo">170</span> if (region.getEndKey().length > 0) {<a name="line.170"></a>
-<span class="sourceLineNo">171</span> end = Bytes.toInt(region.getEndKey());<a name="line.171"></a>
-<span class="sourceLineNo">172</span> }<a name="line.172"></a>
-<span class="sourceLineNo">173</span> int mid = start + ((end - start) / 2);<a name="line.173"></a>
-<span class="sourceLineNo">174</span> byte[] splitPoint = Bytes.toBytes(mid);<a name="line.174"></a>
+<span class="sourceLineNo">124</span> admin.createTable(htd);<a name="line.124"></a>
+<span class="sourceLineNo">125</span> TEST_UTIL.loadTable(source, fam);<a name="line.125"></a>
+<span class="sourceLineNo">126</span> List<HRegion> regions = TEST_UTIL.getHBaseCluster().getRegions(tableName);<a name="line.126"></a>
+<span class="sourceLineNo">127</span> regions.get(0).forceSplit(null);<a name="line.127"></a>
+<span class="sourceLineNo">128</span> admin.split(tableName);<a name="line.128"></a>
+<span class="sourceLineNo">129</span><a name="line.129"></a>
+<span class="sourceLineNo">130</span> while (regions.size() <= 1) {<a name="line.130"></a>
+<span class="sourceLineNo">131</span> regions = TEST_UTIL.getHBaseCluster().getRegions(tableName);<a name="line.131"></a>
+<span class="sourceLineNo">132</span> regions.stream()<a name="line.132"></a>
+<span class="sourceLineNo">133</span> .forEach(r -> r.getStores().get(0).getStorefiles().stream()<a name="line.133"></a>
+<span class="sourceLineNo">134</span> .filter(<a name="line.134"></a>
+<span class="sourceLineNo">135</span> s -> s.isReference() && !scanner.containsKey(r.getRegionInfo().getEncodedName()))<a name="line.135"></a>
+<span class="sourceLineNo">136</span> .forEach(sf -> {<a name="line.136"></a>
+<span class="sourceLineNo">137</span> StoreFileReader reader = ((HStoreFile) sf).getReader();<a name="line.137"></a>
+<span class="sourceLineNo">138</span> reader.getStoreFileScanner(true, false, false, 0, 0, false);<a name="line.138"></a>
+<span class="sourceLineNo">139</span> scanner.put(r.getRegionInfo().getEncodedName(), reader);<a name="line.139"></a>
+<span class="sourceLineNo">140</span> LOG.info("Got reference to file = " + sf.getPath() + ",for region = "<a name="line.140"></a>
+<span class="sourceLineNo">141</span> + r.getRegionInfo().getEncodedName());<a name="line.141"></a>
+<span class="sourceLineNo">142</span> }));<a name="line.142"></a>
+<span class="sourceLineNo">143</span> }<a name="line.143"></a>
+<span class="sourceLineNo">144</span><a name="line.144"></a>
+<span class="sourceLineNo">145</span> Assert.assertTrue("Regions did not split properly", regions.size() > 1);<a name="line.145"></a>
+<span class="sourceLineNo">146</span> Assert.assertTrue("Could not get reference any of the store file", scanner.size() > 1);<a name="line.146"></a>
+<span class="sourceLineNo">147</span><a name="line.147"></a>
+<span class="sourceLineNo">148</span> RetryCounter retrier = new RetryCounter(30, 1, TimeUnit.SECONDS);<a name="line.148"></a>
+<span class="sourceLineNo">149</span> while (CompactionState.NONE != admin.getCompactionState(tableName) && retrier.shouldRetry()) {<a name="line.149"></a>
+<span class="sourceLineNo">150</span> retrier.sleepUntilNextRetry();<a name="line.150"></a>
+<span class="sourceLineNo">151</span> }<a name="line.151"></a>
+<span class="sourceLineNo">152</span><a name="line.152"></a>
+<span class="sourceLineNo">153</span> Assert.assertEquals("Compaction did not complete in 30 secs", CompactionState.NONE,<a name="line.153"></a>
+<span class="sourceLineNo">154</span> admin.getCompactionState(tableName));<a name="line.154"></a>
+<span class="sourceLineNo">155</span><a name="line.155"></a>
+<span class="sourceLineNo">156</span> regions.stream()<a name="line.156"></a>
+<span class="sourceLineNo">157</span> .filter(region -> scanner.containsKey(region.getRegionInfo().getEncodedName()))<a name="line.157"></a>
+<span class="sourceLineNo">158</span> .forEach(r -> Assert.assertTrue("Contains an open file reference which can be split",<a name="line.158"></a>
+<span class="sourceLineNo">159</span> !r.getStores().get(0).canSplit()));<a name="line.159"></a>
+<span class="sourceLineNo">160</span> } finally {<a name="line.160"></a>
+<span class="sourceLineNo">161</span> scanner.values().stream().forEach(s -> {<a name="line.161"></a>
+<span class="sourceLineNo">162</span> try {<a name="line.162"></a>
+<span class="sourceLineNo">163</span> s.close(true);<a name="line.163"></a>
+<span class="sourceLineNo">164</span> } catch (IOException ioe) {<a name="line.164"></a>
+<span class="sourceLineNo">165</span> LOG.error("Failed while closing store file", ioe);<a name="line.165"></a>
+<span class="sourceLineNo">166</span> }<a name="line.166"></a>
+<span class="sourceLineNo">167</span> });<a name="line.167"></a>
+<span class="sourceLineNo">168</span> scanner.clear();<a name="line.168"></a>
+<span class="sourceLineNo">169</span> if (source != null) {<a name="line.169"></a>
+<span class="sourceLineNo">170</span> source.close();<a name="line.170"></a>
+<span class="sourceLineNo">171</span> }<a name="line.171"></a>
+<span class="sourceLineNo">172</span> TEST_UTIL.deleteTableIfAny(tableName);<a name="line.172"></a>
+<span class="sourceLineNo">173</span> }<a name="line.173"></a>
+<span class="sourceLineNo">174</span> }<a name="line.174"></a>
<span class="sourceLineNo">175</span><a name="line.175"></a>
-<span class="sourceLineNo">176</span> //put some rows to the regions<a name="line.176"></a>
-<span class="sourceLineNo">177</span> addData(start);<a name="line.177"></a>
-<span class="sourceLineNo">178</span> addData(mid);<a name="line.178"></a>
-<span class="sourceLineNo">179</span><a name="line.179"></a>
-<span class="sourceLineNo">180</span> flushAndBlockUntilDone(admin, rs, region.getRegionName());<a name="line.180"></a>
-<span class="sourceLineNo">181</span> compactAndBlockUntilDone(admin, rs, region.getRegionName());<a name="line.181"></a>
-<span class="sourceLineNo">182</span><a name="line.182"></a>
-<span class="sourceLineNo">183</span> log("Initiating region split for:" + region.getRegionNameAsString());<a name="line.183"></a>
-<span class="sourceLineNo">184</span> try {<a name="line.184"></a>
-<span class="sourceLineNo">185</span> admin.splitRegion(region.getRegionName(), splitPoint);<a name="line.185"></a>
-<span class="sourceLineNo">186</span> //wait until the split is complete<a name="line.186"></a>
-<span class="sourceLineNo">187</span> blockUntilRegionSplit(CONF, 50000, region.getRegionName(), true);<a name="line.187"></a>
+<span class="sourceLineNo">176</span> /**<a name="line.176"></a>
+<span class="sourceLineNo">177</span> * Tests that the client sees meta table changes as atomic during splits<a name="line.177"></a>
+<span class="sourceLineNo">178</span> */<a name="line.178"></a>
+<span class="sourceLineNo">179</span> @Test<a name="line.179"></a>
+<span class="sourceLineNo">180</span> public void testFromClientSideWhileSplitting() throws Throwable {<a name="line.180"></a>
+<span class="sourceLineNo">181</span> LOG.info("Starting testFromClientSideWhileSplitting");<a name="line.181"></a>
+<span class="sourceLineNo">182</span> final TableName tableName = TableName.valueOf(name.getMethodName());<a name="line.182"></a>
+<span class="sourceLineNo">183</span> final byte[] FAMILY = Bytes.toBytes("family");<a name="line.183"></a>
+<span class="sourceLineNo">184</span><a name="line.184"></a>
+<span class="sourceLineNo">185</span> //SplitTransaction will update the meta table by offlining the parent region, and adding info<a name="line.185"></a>
+<span class="sourceLineNo">186</span> //for daughters.<a name="line.186"></a>
+<span class="sourceLineNo">187</span> Table table = TEST_UTIL.createTable(tableName, FAMILY);<a name="line.187"></a>
<span class="sourceLineNo">188</span><a name="line.188"></a>
-<span class="sourceLineNo">189</span> } catch (NotServingRegionException ex) {<a name="line.189"></a>
-<span class="sourceLineNo">190</span> //ignore<a name="line.190"></a>
-<span class="sourceLineNo">191</span> }<a name="line.191"></a>
-<span class="sourceLineNo">192</span> }<a name="line.192"></a>
-<span class="sourceLineNo">193</span> } catch (Throwable ex) {<a name="line.193"></a>
-<span class="sourceLineNo">194</span> this.ex = ex;<a name="line.194"></a>
-<span class="sourceLineNo">195</span> }<a name="line.195"></a>
-<span class="sourceLineNo">196</span> }<a name="line.196"></a>
-<span class="sourceLineNo">197</span><a name="line.197"></a>
-<span class="sourceLineNo">198</span> void addData(int start) throws IOException {<a name="line.198"></a>
-<span class="sourceLineNo">199</span> List<Put> puts = new ArrayList<>();<a name="line.199"></a>
-<span class="sourceLineNo">200</span> for (int i=start; i< start + 100; i++) {<a name="line.200"></a>
-<span class="sourceLineNo">201</span> Put put = new Put(Bytes.toBytes(i));<a name="line.201"></a>
-<span class="sourceLineNo">202</span> put.addColumn(family, family, Bytes.toBytes(i));<a name="line.202"></a>
-<span class="sourceLineNo">203</span> puts.add(put);<a name="line.203"></a>
-<span class="sourceLineNo">204</span> }<a name="line.204"></a>
-<span class="sourceLineNo">205</span> table.put(puts);<a name="line.205"></a>
-<span class="sourceLineNo">206</span> }<a name="line.206"></a>
-<span class="sourceLineNo">207</span> }<a name="line.207"></a>
+<span class="sourceLineNo">189</span> Stoppable stopper = new StoppableImplementation();<a name="line.189"></a>
+<span class="sourceLineNo">190</span> RegionSplitter regionSplitter = new RegionSplitter(table);<a name="line.190"></a>
+<span class="sourceLineNo">191</span> RegionChecker regionChecker = new RegionChecker(CONF, stopper, tableName);<a name="line.191"></a>
+<span class="sourceLineNo">192</span> final ChoreService choreService = new ChoreService("TEST_SERVER");<a name="line.192"></a>
+<span class="sourceLineNo">193</span><a name="line.193"></a>
+<span class="sourceLineNo">194</span> choreService.scheduleChore(regionChecker);<a name="line.194"></a>
+<span class="sourceLineNo">195</span> regionSplitter.start();<a name="line.195"></a>
+<span class="sourceLineNo">196</span><a name="line.196"></a>
+<span class="sourceLineNo">197</span> //wait until the splitter is finished<a name="line.197"></a>
+<span class="sourceLineNo">198</span> regionSplitter.join();<a name="line.198"></a>
+<span class="sourceLineNo">199</span> stopper.stop(null);<a name="line.199"></a>
+<span class="sourceLineNo">200</span><a name="line.200"></a>
+<span class="sourceLineNo">201</span> if (regionChecker.ex != null) {<a name="line.201"></a>
+<span class="sourceLineNo">202</span> throw new AssertionError("regionChecker", regionChecker.ex);<a name="line.202"></a>
+<span class="sourceLineNo">203</span> }<a name="line.203"></a>
+<span class="sourceLineNo">204</span><a name="line.204"></a>
+<span class="sourceLineNo">205</span> if (regionSplitter.ex != null) {<a name="line.205"></a>
+<span class="sourceLineNo">206</span> throw new AssertionError("regionSplitter", regionSplitter.ex);<a name="line.206"></a>
+<span class="sourceLineNo">207</span> }<a name="line.207"></a>
<span class="sourceLineNo">208</span><a name="line.208"></a>
-<span class="sourceLineNo">209</span> /**<a name="line.209"></a>
-<span class="sourceLineNo">210</span> * Checks regions using MetaTableAccessor and HTable methods<a name="line.210"></a>
-<span class="sourceLineNo">211</span> */<a name="line.211"></a>
-<span class="sourceLineNo">212</span> static class RegionChecker extends ScheduledChore {<a name="line.212"></a>
-<span class="sourceLineNo">213</span> Connection connection;<a name="line.213"></a>
-<span class="sourceLineNo">214</span> Configuration conf;<a name="line.214"></a>
-<span class="sourceLineNo">215</span> TableName tableName;<a name="line.215"></a>
-<span class="sourceLineNo">216</span> Throwable ex;<a name="line.216"></a>
-<span class="sourceLineNo">217</span><a name="line.217"></a>
-<span class="sourceLineNo">218</span> RegionChecker(Configuration conf, Stoppable stopper, TableName tableName) throws IOException {<a name="line.218"></a>
-<span class="sourceLineNo">219</span> super("RegionChecker", stopper, 10);<a name="line.219"></a>
-<span class="sourceLineNo">220</span> this.conf = conf;<a name="line.220"></a>
-<span class="sourceLineNo">221</span> this.tableName = tableName;<a name="line.221"></a>
-<span class="sourceLineNo">222</span><a name="line.222"></a>
-<span class="sourceLineNo">223</span> this.connection = ConnectionFactory.createConnection(conf);<a name="line.223"></a>
-<span class="sourceLineNo">224</span> }<a name="line.224"></a>
-<span class="sourceLineNo">225</span><a name="line.225"></a>
-<span class="sourceLineNo">226</span> /** verify region boundaries obtained from MetaScanner */<a name="line.226"></a>
-<span class="sourceLineNo">227</span> void verifyRegionsUsingMetaTableAccessor() throws Exception {<a name="line.227"></a>
-<span class="sourceLineNo">228</span> List<RegionInfo> regionList = MetaTableAccessor.getTableRegions(connection, tableName, true);<a name="line.228"></a>
-<span class="sourceLineNo">229</span> verifyTableRegions(regionList.stream().collect(Collectors.toCollection(() -> new TreeSet<>(RegionInfo.COMPARATOR))));<a name="line.229"></a>
-<span class="sourceLineNo">230</span> regionList = MetaTableAccessor.getAllRegions(connection, true);<a name="line.230"></a>
-<span class="sourceLineNo">231</span> verifyTableRegions(regionList.stream().collect(Collectors.toCollection(() -> new TreeSet<>(RegionInfo.COMPARATOR))));<a name="line.231"></a>
-<span class="sourceLineNo">232</span> }<a name="line.232"></a>
-<span class="sourceLineNo">233</span><a name="line.233"></a>
-<span class="sourceLineNo">234</span> /** verify region boundaries obtained from HTable.getStartEndKeys() */<a name="line.234"></a>
-<span class="sourceLineNo">235</span> void verifyRegionsUsingHTable() throws IOException {<a name="line.235"></a>
-<span class="sourceLineNo">236</span> Table table = null;<a name="line.236"></a>
-<span class="sourceLineNo">237</span> try {<a name="line.237"></a>
-<span class="sourceLineNo">238</span> //HTable.getStartEndKeys()<a name="line.238"></a>
-<span class="sourceLineNo">239</span> table = connection.getTable(tableName);<a name="line.239"></a>
-<span class="sourceLineNo">240</span><a name="line.240"></a>
-<span class="sourceLineNo">241</span> try(RegionLocator rl = connection.getRegionLocator(tableName)) {<a name="line.241"></a>
-<span class="sourceLineNo">242</span> Pair<byte[][], byte[][]> keys = rl.getStartEndKeys();<a name="line.242"></a>
-<span class="sourceLineNo">243</span> verifyStartEndKeys(keys);<a name="line.243"></a>
+<span class="sourceLineNo">209</span> //one final check<a name="line.209"></a>
+<span class="sourceLineNo">210</span> regionChecker.verify();<a name="line.210"></a>
+<span class="sourceLineNo">211</span> }<a name="line.211"></a>
+<span class="sourceLineNo">212</span><a name="line.212"></a>
+<span class="sourceLineNo">213</span> static class RegionSplitter extends Thread {<a name="line.213"></a>
+<span class="sourceLineNo">214</span> final Connection connection;<a name="line.214"></a>
+<span class="sourceLineNo">215</span> Throwable ex;<a name="line.215"></a>
+<span class="sourceLineNo">216</span> Table table;<a name="line.216"></a>
+<span class="sourceLineNo">217</span> TableName tableName;<a name="line.217"></a>
+<span class="sourceLineNo">218</span> byte[] family;<a name="line.218"></a>
+<span class="sourceLineNo">219</span> Admin admin;<a name="line.219"></a>
+<span class="sourceLineNo">220</span> HRegionServer rs;<a name="line.220"></a>
+<span class="sourceLineNo">221</span><a name="line.221"></a>
+<span class="sourceLineNo">222</span> RegionSplitter(Table table) throws IOException {<a name="line.222"></a>
+<span class="sourceLineNo">223</span> this.table = table;<a name="line.223"></a>
+<span class="sourceLineNo">224</span> this.tableName = table.getName();<a name="line.224"></a>
+<span class="sourceLineNo">225</span> this.family = table.getTableDescriptor().getFamiliesKeys().iterator().next();<a name="line.225"></a>
+<span class="sourceLineNo">226</span> admin = TEST_UTIL.getAdmin();<a name="line.226"></a>
+<span class="sourceLineNo">227</span> rs = TEST_UTIL.getMiniHBaseCluster().getRegionServer(0);<a name="line.227"></a>
+<span class="sourceLineNo">228</span> connection = TEST_UTIL.getConnection();<a name="line.228"></a>
+<span class="sourceLineNo">229</span> }<a name="line.229"></a>
+<span class="sourceLineNo">230</span><a name="line.230"></a>
+<span class="sourceLineNo">231</span> @Override<a name="line.231"></a>
+<span class="sourceLineNo">232</span> public void run() {<a name="line.232"></a>
+<span class="sourceLineNo">233</span> try {<a name="line.233"></a>
+<span class="sourceLineNo">234</span> Random random = new Random();<a name="line.234"></a>
+<span class="sourceLineNo">235</span> for (int i = 0; i < 5; i++) {<a name="line.235"></a>
+<span class="sourceLineNo">236</span> List<RegionInfo> regions = MetaTableAccessor.getTableRegions(connection, tableName, true);<a name="line.236"></a>
+<span class="sourceLineNo">237</span> if (regions.isEmpty()) {<a name="line.237"></a>
+<span class="sourceLineNo">238</span> continue;<a name="line.238"></a>
+<span class="sourceLineNo">239</span> }<a name="line.239"></a>
+<span class="sourceLineNo">240</span> int regionIndex = random.nextInt(regions.size());<a name="line.240"></a>
+<span class="sourceLineNo">241</span><a name="line.241"></a>
+<span class="sourceLineNo">242</span> // pick a random region and split it into two<a name="line.242"></a>
+<span class="sourceLineNo">243</span> RegionInfo region = Iterators.get(regions.iterator(), regionIndex);<a name="line.243"></a>
<span class="sourceLineNo">244</span><a name="line.244"></a>
-<span class="sourceLineNo">245</span> Set<RegionInfo> regions = new TreeSet<>(RegionInfo.COMPARATOR);<a name="line.245"></a>
-<span class="sourceLineNo">246</span> for (HRegionLocation loc : rl.getAllRegionLocations()) {<a name="line.246"></a>
-<span class="sourceLineNo">247</span> regions.add(loc.getRegionInfo());<a name="line.247"></a>
-<span class="sourceLineNo">248</span> }<a name="line.248"></a>
-<span class="sourceLineNo">249</span> verifyTableRegions(regions);<a name="line.249"></a>
-<span class="sourceLineNo">250</span> }<a name="line.250"></a>
-<span class="sourceLineNo">251</span><a name="line.251"></a>
-<span class="sourceLineNo">252</span> } finally {<a name="line.252"></a>
-<span class="sourceLineNo">253</span> IOUtils.closeQuietly(table);<a name="line.253"></a>
-<span class="sourceLineNo">254</span> }<a name="line.254"></a>
-<span class="sourceLineNo">255</span> }<a name="line.255"></a>
-<span class="sourceLineNo">256</span><a name="line.256"></a>
-<span class="sourceLineNo">257</span> void verify() throws Exception {<a name="line.257"></a>
-<span class="sourceLineNo">258</span> verifyRegionsUsingMetaTableAccessor();<a name="line.258"></a>
-<span class="sourceLineNo">259</span> verifyRegionsUsingHTable();<a name="line.259"></a>
-<span class="sourceLineNo">260</span> }<a name="line.260"></a>
-<span class="sourceLineNo">261</span><a name="line.261"></a>
-<span class="sourceLineNo">262</span> void verifyTableRegions(Set<RegionInfo> regions) {<a name="line.262"></a>
-<span class="sourceLineNo">263</span> log("Verifying " + regions.size() + " regions: " + regions);<a name="line.263"></a>
-<span class="sourceLineNo">264</span><a name="line.264"></a>
-<span class="sourceLineNo">265</span> byte[][] startKeys = new byte[regions.size()][];<a name="line.265"></a>
-<span class="sourceLineNo">266</span> byte[][] endKeys = new byte[regions.size()][];<a name="line.266"></a>
-<span class="sourceLineNo">267</span><a name="line.267"></a>
-<span class="sourceLineNo">268</span> int i=0;<a name="line.268"></a>
-<span class="sourceLineNo">269</span> for (RegionInfo region : regions) {<a name="line.269"></a>
-<span class="sourceLineNo">270</span> startKeys[i] = region.getStartKey();<a name="line.270"></a>
-<span class="sourceLineNo">271</span> endKeys[i] = region.getEndKey();<a name="line.271"></a>
-<span class="sourceLineNo">272</span> i++;<a name="line.272"></a>
-<span class="sourceLineNo">273</span> }<a name="line.273"></a>
-<span class="sourceLineNo">274</span><a name="line.274"></a>
-<span class="sourceLineNo">275</span> Pair<byte[][], byte[][]> keys = new Pair<>(startKeys, endKeys);<a name="line.275"></a>
-<span class="sourceLineNo">276</span> verifyStartEndKeys(keys);<a name="line.276"></a>
-<span class="sourceLineNo">277</span> }<a name="line.277"></a>
-<span class="sourceLineNo">278</span><a name="line.278"></a>
-<span class="sourceLineNo">279</span> void verifyStartEndKeys(Pair<byte[][], byte[][]> keys) {<a name="line.279"></a>
-<span class="sourceLineNo">280</span> byte[][] startKeys = keys.getFirst();<a name="line.280"></a>
-<span class="sourceLineNo">281</span> byte[][] endKeys = keys.getSecond();<a name="line.281"></a>
-<span class="sourceLineNo">282</span> assertEquals(startKeys.length, endKeys.length);<a name="line.282"></a>
-<span class="sourceLineNo">283</span> assertTrue("Found 0 regions for the table", startKeys.length > 0);<a name="line.283"></a>
-<span class="sourceLineNo">284</span><a name="line.284"></a>
-<span class="sourceLineNo">285</span> assertArrayEquals("Start key for the first region is not byte[0]",<a name="line.285"></a>
-<span class="sourceLineNo">286</span> HConstants.EMPTY_START_ROW, startKeys[0]);<a name="line.286"></a>
-<span class="sourceLineNo">287</span> byte[] prevEndKey = HConstants.EMPTY_START_ROW;<a name="line.287"></a>
+<span class="sourceLineNo">245</span> // pick the mid split point<a name="line.245"></a>
+<span class="sourceLineNo">246</span> int start = 0, end = Integer.MAX_VALUE;<a name="line.246"></a>
+<span class="sourceLineNo">247</span> if (region.getStartKey().length > 0) {<a name="line.247"></a>
+<span class="sourceLineNo">248</span> start = Bytes.toInt(region.getStartKey());<a name="line.248"></a>
+<span class="sourceLineNo">249</span> }<a name="line.249"></a>
+<span class="sourceLineNo">250</span> if (region.getEndKey().length > 0) {<a name="line.250"></a>
+<span class="sourceLineNo">251</span> end = Bytes.toInt(region.getEndKey());<a name="line.251"></a>
+<span class="sourceLineNo">252</span> }<a name="line.252"></a>
+<span class="sourceLineNo">253</span> int mid = start + ((end - start) / 2);<a name="line.253"></a>
+<span class="sourceLineNo">254</span> byte[] splitPoint = Bytes.toBytes(mid);<a name="line.254"></a>
+<span class="sourceLineNo">255</span><a name="line.255"></a>
+<span class="sourceLineNo">256</span> // put some rows to the regions<a name="line.256"></a>
+<span class="sourceLineNo">257</span> addData(start);<a name="line.257"></a>
+<span class="sourceLineNo">258</span> addData(mid);<a name="line.258"></a>
+<span class="sourceLineNo">259</span><a name="line.259"></a>
+<span class="sourceLineNo">260</span> flushAndBlockUntilDone(admin, rs, region.getRegionName());<a name="line.260"></a>
+<span class="sourceLineNo">261</span> compactAndBlockUntilDone(admin, rs, region.getRegionName());<a name="line.261"></a>
+<span class="sourceLineNo">262</span><a name="line.262"></a>
+<span class="sourceLineNo">263</span> log("Initiating region split for:" + region.getRegionNameAsString());<a name="line.263"></a>
+<span class="sourceLineNo">264</span> try {<a name="line.264"></a>
+<span class="sourceLineNo">265</span> admin.splitRegion(region.getRegionName(), splitPoint);<a name="line.265"></a>
+<span class="sourceLineNo">266</span> // wait until the split is complete<a name="line.266"></a>
+<span class="sourceLineNo">267</span> blockUntilRegionSplit(CONF, 50000, region.getRegionName(), true);<a name="line.267"></a>
+<span class="sourceLineNo">268</span><a name="line.268"></a>
+<span class="sourceLineNo">269</span> } catch (NotServingRegionException ex) {<a name="line.269"></a>
+<span class="sourceLineNo">270</span> // ignore<a name="line.270"></a>
+<span class="sourceLineNo">271</span> }<a name="line.271"></a>
+<span class="sourceLineNo">272</span> }<a name="line.272"></a>
+<span class="sourceLineNo">273</span> } catch (Throwable ex) {<a name="line.273"></a>
+<span class="sourceLineNo">274</span> this.ex = ex;<a name="line.274"></a>
+<span class="sourceLineNo">275</span> }<a name="line.275"></a>
+<span class="sourceLineNo">276</span> }<a name="line.276"></a>
+<span class="sourceLineNo">277</span><a name="line.277"></a>
+<span class="sourceLineNo">278</span> void addData(int start) throws IOException {<a name="line.278"></a>
+<span class="sourceLineNo">279</span> List<Put> puts = new ArrayList<>();<a name="line.279"></a>
+<span class="sourceLineNo">280</span> for (int i=start; i< start + 100; i++) {<a name="line.280"></a>
+<span class="sourceLineNo">281</span> Put put = new Put(Bytes.toBytes(i));<a name="line.281"></a>
+<span class="sourceLineNo">282</span> put.addColumn(family, family, Bytes.toBytes(i));<a name="line.282"></a>
+<span class="sourceLineNo">283</span> puts.add(put);<a name="line.283"></a>
+<span class="sourceLineNo">284</span> }<a name="line.284"></a>
+<span class="sourceLineNo">285</span> table.put(puts);<a name="line.285"></a>
+<span class="sourceLineNo">286</span> }<a name="line.286"></a>
+<span class="sourceLineNo">287</span> }<a name="line.287"></a>
<span class="sourceLineNo">288</span><a name="line.288"></a>
-<span class="sourceLineNo">289</span> // ensure that we do not have any gaps<a name="line.289"></a>
-<span class="sourceLineNo">290</span> for (int i=0; i<startKeys.length; i++) {<a name="line.290"></a>
-<span class="sourceLineNo">291</span> assertArrayEquals(<a name="line.291"></a>
-<span class="sourceLineNo">292</span> "Hole in hbase:meta is detected. prevEndKey=" + Bytes.toStringBinary(prevEndKey)<a name="line.292"></a>
-<span class="sourceLineNo">293</span> + " ,regionStartKey=" + Bytes.toStringBinary(startKeys[i]), prevEndKey,<a name="line.293"></a>
-<span class="sourceLineNo">294</span> startKeys[i]);<a name="line.294"></a>
-<span class="sourceLineNo">295</span> prevEndKey = endKeys[i];<a name="line.295"></a>
-<span class="sourceLineNo">296</span> }<a name="line.296"></a>
-<span class="sourceLineNo">297</span> assertArrayEquals("End key for the last region is not byte[0]", HConstants.EMPTY_END_ROW,<a name="line.297"></a>
-<span class="sourceLineNo">298</span> endKeys[endKeys.length - 1]);<a name="line.298"></a>
-<span class="sourceLineNo">299</span> }<a name="line.299"></a>
-<span class="sourceLineNo">300</span><a name="line.300"></a>
-<span class="sourceLineNo">301</span> @Override<a name="line.301"></a>
-<span class="sourceLineNo">302</span> protected void chore() {<a name="line.302"></a>
-<span class="sourceLineNo">303</span> try {<a name="line.303"></a>
-<span class="sourceLineNo">304</span> verify();<a name="line.304"></a>
-<span class="sourceLineNo">305</span> } catch (Throwable ex) {<a name="line.305"></a>
-<span class="sourceLineNo">306</span> this.ex = ex;<a name="line.306"></a>
-<span class="sourceLineNo">307</span> getStopper().stop("caught exception");<a name="line.307"></a>
-<span class="sourceLineNo">308</span> }<a name="line.308"></a>
-<span class="sourceLineNo">309</span> }<a name="line.309"></a>
-<span class="sourceLineNo">310</span> }<a name="line.310"></a>
-<span class="sourceLineNo">311</span><a name="line.311"></a>
-<span class="sourceLineNo">312</span> public static void log(String msg) {<a name="line.312"></a>
-<span class="sourceLineNo">313</span> LOG.info(msg);<a name="line.313"></a>
-<span class="sourceLineNo">314</span> }<a name="line.314"></a>
+<span class="sourceLineNo">289</span> /**<a name="line.289"></a>
+<span class="sourceLineNo">290</span> * Checks regions using MetaTableAccessor and HTable methods<a name="line.290"></a>
+<span class="sourceLineNo">291</span> */<a name="line.291"></a>
+<span class="sourceLineNo">292</span> static class RegionChecker extends ScheduledChore {<a name="line.292"></a>
+<span class="sourceLineNo">293</span> Connection connection;<a name="line.293"></a>
+<span class="sourceLineNo">294</span> Configuration conf;<a name="line.294"></a>
+<span class="sourceLineNo">295</span> TableName tableName;<a name="line.295"></a>
+<span class="sourceLineNo">296</span> Throwable ex;<a name="line.296"></a>
+<span class="sourceLineNo">297</span><a name="line.297"></a>
+<span class="sourceLineNo">298</span> RegionChecker(Configuration conf, Stoppable stopper, TableName tableName) throws IOException {<a name="line.298"></a>
+<span class="sourceLineNo">299</span> super("RegionChecker", stopper, 10);<a name="line.299"></a>
+<span class="sourceLineNo">300</span> this.conf = conf;<a name="line.300"></a>
+<span class="sourceLineNo">301</span> this.tableName = tableName;<a name="line.301"></a>
+<span class="sourceLineNo">302</span><a name="line.302"></a>
+<span class="sourceLineNo">303</span> this.connection = ConnectionFactory.createConnection(conf);<a name="line.303"></a>
+<span class="sourceLineNo">304</span> }<a name="line.304"></a>
+<span class="sourceLineNo">305</span><a name="line.305"></a>
+<span class="sourceLineNo">306</span> /** verify region boundaries obtained from MetaScanner */<a name="line.306"></a>
+<span class="sourceLineNo">307</span> void verifyRegionsUsingMetaTableAccessor() throws Exception {<a name="line.307"></a>
+<span class="sourceLineNo">308</span> List<RegionInfo> regionList = MetaTableAccessor.getTableRegions(connection, tableName, true);<a name="line.308"></a>
+<span class="sourceLineNo">309</span> verifyTableRegions(regionList.stream()<a name="line.309"></a>
+<span class="sourceLineNo">310</span> .collect(Collectors.toCollection(() -> new TreeSet<>(RegionInfo.COMPARATOR))));<a name="line.310"></a>
+<span class="sourceLineNo">311</span> regionList = MetaTableAccessor.getAllRegions(connection, true);<a name="line.311"></a>
+<span class="sourceLineNo">312</span> verifyTableRegions(regionList.stream()<a name="line.312"></a>
+<span class="sourceLineNo">313</span> .collect(Collectors.toCollection(() -> new TreeSet<>(RegionInfo.COMPARATOR))));<a name="line.313"></a>
+<span class="sourceLineNo">314</span> }<a name="line.314"></a>
<span class="sourceLineNo">315</span><a name="line.315"></a>
-<span class="sourceLineNo">316</span> /* some utility methods for split tests */<a name="line.316"></a>
-<span class="sourceLineNo">317</span><a name="line.317"></a>
-<span class="sourceLineNo">318</span> public static void flushAndBlockUntilDone(Admin admin, HRegionServer rs, byte[] regionName)<a name="line.318"></a>
-<span class="sourceLineNo">319</span> throws IOException, InterruptedException {<a name="line.319"></a>
-<span class="sourceLineNo">320</span> log("flushing region: " + Bytes.toStringBinary(regionName));<a name="line.320"></a>
-<span class="sourceLineNo">321</span> admin.flushRegion(regionName);<a name="line.321"></a>
-<span class="sourceLineNo">322</span> log("blocking until flush is complete: " + Bytes.toStringBinary(regionName));<a name="line.322"></a>
-<span class="sourceLineNo">323</span> Threads.sleepWithoutInterrupt(500);<a name="line.323"></a>
-<span class="sourceLineNo">324</span> while (rs.getOnlineRegion(regionName).getMemStoreDataSize() > 0) {<a name="line.324"></a>
-<span class="sourceLineNo">325</span> Threads.sleep(50);<a name="line.325"></a>
-<span class="sourceLineNo">326</span> }<a name="line.326"></a>
-<span class="sourceLineNo">327</span> }<a name="line.327"></a>
-<span class="sourceLineNo">328</span><a name="line.328"></a>
-<span class="sourceLineNo">329</span> public static void compactAndBlockUntilDone(Admin admin, HRegionServer rs, byte[] regionName)<a name="line.329"></a>
-<span class="sourceLineNo">330</span> throws IOException, InterruptedException {<a name="line.330"></a>
-<span class="sourceLineNo">331</span> log("Compacting region: " + Bytes.toStringBinary(regionName));<a name="line.331"></a>
-<span class="sourceLineNo">332</span> admin.majorCompactRegion(regionName);<a name="line.332"></a>
-<span class="sourceLineNo">333</span> log("blocking until compaction is complete: " + Bytes.toStringBinary(regionName));<a name="line.333"></a>
-<span class="sourceLineNo">334</span> Threads.sleepWithoutInterrupt(500);<a name="line.334"></a>
-<span class="sourceLineNo">335</span> outer: for (;;) {<a name="line.335"></a>
-<span class="sourceLineNo">336</span> for (Store store : rs.getOnlineRegion(regionName).getStores()) {<a name="line.336"></a>
-<span class="sourceLineNo">337</span> if (store.getStorefilesCount() > 1) {<a name="line.337"></a>
-<span class="sourceLineNo">338</span> Threads.sleep(50);<a name="line.338"></a>
-<span class="sourceLineNo">339</span> continue outer;<a name="line.339"></a>
-<span class="sourceLineNo">340</span> }<a name="line.340"></a>
-<span class="sourceLineNo">341</span> }<a name="line.341"></a>
-<span class="sourceLineNo">342</span> break;<a name="line.342"></a>
-<span class="sourceLineNo">343</span> }<a name="line.343"></a>
-<span class="sourceLineNo">344</span> }<a name="line.344"></a>
-<span class="sourceLineNo">345</span><a name="line.345"></a>
-<span class="sourceLineNo">346</span> /** Blocks until the region split is complete in hbase:meta and region server opens the daughters */<a name="line.346"></a>
-<span class="sourceLineNo">347</span> public static void blockUntilRegionSplit(Configuration conf, long timeout,<a name="line.347"></a>
-<span class="sourceLineNo">348</span> final byte[] regionName, boolean waitForDaughters)<a name="line.348"></a>
-<span class="sourceLineNo">349</span> throws IOException, InterruptedException {<a name="line.349"></a>
-<span class="sourceLineNo">350</span> long start = System.currentTimeMillis();<a name="line.350"></a>
-<span class="sourceLineNo">351</span> log("blocking until region is split:" + Bytes.toStringBinary(regionName));<a name="line.351"></a>
-<span class="sourceLineNo">352</span> RegionInfo daughterA = null, daughterB = null;<a name="line.352"></a>
-<span class="sourceLineNo">353</span> try (Connection conn = ConnectionFactory.createConnection(conf);<a name="line.353"></a>
-<span class="sourceLineNo">354</span> Table metaTable = conn.getTable(TableName.META_TABLE_NAME)) {<a name="line.354"></a>
-<span class="sourceLineNo">355</span> Result result = null;<a name="line.355"></a>
-<span class="sourceLineNo">356</span> RegionInfo region = null;<a name="line.356"></a>
-<span class="sourceLineNo">357</span> while ((System.currentTimeMillis() - start) < timeout) {<a name="line.357"></a>
-<span class="sourceLineNo">358</span> result = metaTable.get(new Get(regionName));<a name="line.358"></a>
-<span class="sourceLineNo">359</span> if (result == null) {<a name="line.359"></a>
-<span class="sourceLineNo">360</span> break;<a name="line.360"></a>
-<span class="sourceLineNo">361</span> }<a name="line.361"></a>
-<span class="sourceLineNo">362</span><a name="line.362"></a>
-<span class="sourceLineNo">363</span> region = MetaTableAccessor.getRegionInfo(result);<a name="line.363"></a>
-<span class="sourceLineNo">364</span> if (region.isSplitParent()) {<a name="line.364"></a>
-<span class="sourceLineNo">365</span> log("found parent region: " + region.toString());<a name="line.365"></a>
-<span class="sourceLineNo">366</span> PairOfSameType<RegionInfo> pair = MetaTableAccessor.getDaughterRegions(result);<a name="line.366"></a>
-<span class="sourceLineNo">367</span> daughterA = pair.getFirst();<a name="line.367"></a>
-<span class="sourceLineNo">368</span> daughterB = pair.getSecond();<a name="line.368"></a>
-<span class="sourceLineNo">369</span> break;<a name="line.369"></a>
-<span class="sourceLineNo">370</span> }<a name="line.370"></a>
-<span class="sourceLineNo">371</span> Threads.sleep(100);<a name="line.371"></a>
-<span class="sourceLineNo">372</span> }<a name="line.372"></a>
-<span class="sourceLineNo">373</span> if (daughterA == null || daughterB == null) {<a name="line.373"></a>
-<span class="sourceLineNo">374</span> throw new IOException("Failed to get daughters, daughterA=" + daughterA + ", daughterB=" +<a name="line.374"></a>
-<span class="sourceLineNo">375</span> daughterB + ", timeout=" + timeout + ", result=" + result + ", regionName=" +<a name="line.375"></a>
-<span class="sourceLineNo">376</span> Bytes.toString(regionName) + ", region=" + region);<a name="line.376"></a>
-<span class="sourceLineNo">377</span> }<a name="line.377"></a>
-<span class="sourceLineNo">378</span><a name="line.378"></a>
-<span class="sourceLineNo">379</span> //if we are here, this means the region split is complete or timed out<a name="line.379"></a>
-<span class="sourceLineNo">380</span> if (waitForDaughters) {<a name="line.380"></a>
-<span class="sourceLineNo">381</span> long rem = timeout - (System.currentTimeMillis() - start);<a name="line.381"></a>
-<span class="sourceLineNo">382</span> blockUntilRegionIsInMeta(conn, rem, daughterA);<a name="line.382"></a>
-<span class="sourceLineNo">383</span><a name="line.383"></a>
-<span class="sourceLineNo">384</span> rem = timeout - (System.currentTimeMillis() - start);<a name="line.384"></a>
-<span class="sourceLineNo">385</span> blockUntilRegionIsInMeta(conn, rem, daughterB);<a name="line.385"></a>
-<span class="sourceLineNo">386</span><a name="line.386"></a>
-<span class="sourceLineNo">387</span> rem = timeout - (System.currentTimeMillis() - start);<a name="line.387"></a>
-<span class="sourceLineNo">388</span> blockUntilRegionIsOpened(conf, rem, daughterA);<a name="line.388"></a>
-<span class="sourceLineNo">389</span><a name="line.389"></a>
-<span class="sourceLineNo">390</span> rem = timeout - (System.currentTimeMillis() - start);<a name="line.390"></a>
-<span class="sourceLineNo">391</span> blockUntilRegionIsOpened(conf, rem, daughterB);<a name="line.391"></a>
-<span class="sourceLineNo">392</span> }<a name="line.392"></a>
-<span class="sourceLineNo">393</span> }<a name="line.393"></a>
-<span class="sourceLineNo">394</span> }<a name="line.394"></a>
-<span class="sourceLineNo">395</span><a name="line.395"></a>
-<span class="sourceLineNo">396</span> public static void blockUntilRegionIsInMeta(Connection conn, long timeout, RegionInfo hri)<a name="line.396"></a>
-<span class="sourceLineNo">397</span> throws IOException, InterruptedException {<a name="line.397"></a>
-<span class="sourceLineNo">398</span> log("blocking until region is in META: " + hri.getRegionNameAsString());<a name="line.398"></a>
-<span class="sourceLineNo">399</span> long start = System.currentTimeMillis();<a name="line.399"></a>
-<span class="sourceLineNo">400</span> while (System.currentTimeMillis() - start < timeout) {<a name="line.400"></a>
-<span class="sourceLineNo">401</span> HRegionLocation loc = MetaTableAccessor.getRegionLocation(conn, hri);<a name="line.401"></a>
-<span class="sourceLineNo">402</span> if (loc != null && !loc.getRegionInfo().isOffline()) {<a name="line.402"></a>
-<span class="sourceLineNo">403</span> log("found region in META: " + hri.getRegionNameAsString());<a name="line.403"></a>
-<span class="sourceLineNo">404</span> break;<a name="line.404"></a>
-<span class="sourceLineNo">405</span> }<a name="line.405"></a>
-<span class="sourceLineNo">406</span> Threads.sleep(10);<a name="line.406"></a>
-<span class="sourceLineNo">407</span> }<a name="line.407"></a>
-<span class="sourceLineNo">408</span> }<a name="line.408"></a>
-<span class="sourceLineNo">409</span><a name="line.409"></a>
-<span class="sourceLineNo">410</span> public static void blockUntilRegionIsOpened(Configuration conf, long timeout, RegionInfo hri)<a name="line.410"></a>
-<span class="sourceLineNo">411</span> throws IOException, InterruptedException {<a name="line.411"></a>
-<span class="sourceLineNo">412</span> log("blocking until region is opened for reading:" + hri.getRegionNameAsString());<a name="line.412"></a>
-<span class="sourceLineNo">413</span> long start = System.currentTimeMillis();<a name="line.413"></a>
-<span class="sourceLineNo">414</span> try (Connection conn = ConnectionFactory.createConnection(conf);<a name="line.414"></a>
-<span class="sourceLineNo">415</span> Table table = conn.getTable(hri.getTable())) {<a name="line.415"></a>
-<span class="sourceLineNo">416</span> byte[] row = hri.getStartKey();<a name="line.416"></a>
-<span class="sourceLineNo">417</span> // Check for null/empty row. If we find one, use a key that is likely to be in first region.<a name="line.417"></a>
-<span class="sourceLineNo">418</span> if (row == null || row.length <= 0) row = new byte[] { '0' };<a name="line.418"></a>
-<span class="sourceLineNo">419</span> Get get = new Get(row);<a name="line.419"></a>
-<span class="sourceLineNo">420</span> while (System.currentTimeMillis() - start < timeout) {<a name="line.420"></a>
-<span class="sourceLineNo">421</span> try {<a name="line.421"></a>
-<span class="sourceLineNo">422</span> table.get(get);<a name="line.422"></a>
-<span class="sourceLineNo">423</span> break;<a name="line.423"></a>
-<span class="sourceLineNo">424</span> } catch (IOException ex) {<a name="line.424"></a>
-<span class="sourceLineNo">425</span> // wait some more<a name="line.425"></a>
-<span class="sourceLineNo">426</span> }<a name="line.426"></a>
-<span class="sourceLineNo">427</span> Threads.sleep(10);<a name="line.427"></a>
-<span class="sourceLineNo">428</span> }<a name="line.428"></a>
-<span class="sourceLineNo">429</span> }<a name="line.429"></a>
-<span class="sourceLineNo">430</span> }<a name="line.430"></a>
-<span class="sourceLineNo">431</span>}<a name="line.431"></a>
+<span class="sourceLineNo">316</span> /** verify region boundaries obtained from HTable.getStartEndKeys() */<a name="line.316"></a>
+<span class="sourceLineNo">317</span> void verifyRegionsUsingHTable() throws IOException {<a name="line.317"></a>
+<span class="sourceLineNo">318</span> Table table = null;<a name="line.318"></a>
+<span class="sourceLineNo">319</span> try {<a name="line.319"></a>
+<span class="sourceLineNo">320</span> //HTable.getStartEndKeys()<a name="line.320"></a>
+<span class="sourceLineNo">321</span> table = connection.getTable(tableName);<a name="line.321"></a>
+<span class="sourceLineNo">322</span><a name="line.322"></a>
+<span class="sourceLineNo">323</span> try(RegionLocator rl = connection.getRegionLocator(tableName)) {<a name="line.323"></a>
+<span class="sourceLineNo">324</span> Pair<byte[][], byte[][]> keys = rl.getStartEndKeys();<a name="line.324"></a>
+<span class="sourceLineNo">325</span> verifyStartEndKeys(keys);<a name="line.325"></a>
+<span class="sourceLineNo">326</span><a name="line.326"></a>
+<span class="sourceLineNo">327</span> Set<RegionInfo> regions = new TreeSet<>(RegionInfo.COMPARATOR);<a name="line.327"></a>
+<span class="sourceLineNo">328</span> for (HRegionLocation loc : rl.getAllRegionLocations()) {<a name="line.328"></a>
+<span class="sourceLineNo">329</span> regions.add(loc.getRegionInfo());<a name="line.329"></a>
+<span class="sourceLineNo">330</span> }<a name="line.330"></a>
+<span class="sourceLineNo">331</span> verifyTableRegions(regions);<a name="line.331"></a>
+<span class="sourceLineNo">332</span> }<a name="line.332"></a>
+<span class="sourceLineNo">333</span><a name="line.333"></a>
+<span class="sourceLineNo">334</span> } finally {<a name="line.334"></a>
+<span class="sourceLineNo">335</span> IOUtils.closeQuietly(table);<a name="line.335"></a>
+<span class="sourceLineNo">336</span> }<a name="line.336"></a>
+<span class="sourceLineNo">337</span> }<a name="line.337"></a>
+<span class="sourceLineNo">338</span><a name="line.338"></a>
+<span class="sourceLineNo">339</span> void verify() throws Exception {<a name="line.339"></a>
+<span class="sourceLineNo">340</span> verifyRegionsUsingMetaTableAccessor();<a name="line.340"></a>
+<span class="sourceLineNo">341</span> verifyRegionsUsingHTable();<a name="line.341"></a>
+<span class="sourceLineNo">342</span> }<a name="line.342"></a>
+<span class="sourceLineNo">343</span><a name="line.343"></a>
+<span class="sourceLineNo">344</span> void verifyTableRegions(Set<RegionInfo> regions) {<a name="line.344"></a>
+<span class="sourceLineNo">345</span> log("Verifying " + regions.size() + " regions: " + regions);<a name="line.345"></a>
+<span class="sourceLineNo">346</span><a name="line.346"></a>
+<span class="sourceLineNo">347</span> byte[][] startKeys = new byte[regions.size()][];<a name="line.347"></a>
+<span class="sourceLineNo">348</span> byte[][] endKeys = new byte[regions.size()][];<a name="line.348"></a>
+<span class="sourceLineNo">349</span><a name="line.349"></a>
+<span class="sourceLineNo">350</span> int i=0;<a name="line.350"></a>
+<span class="sourceLineNo">351</span> for (RegionInfo region : regions) {<a name="line.351"></a>
+<span class="sourceLineNo">352</span> startKeys[i] = region.getStartKey();<a name="line.352"></a>
+<span class="sourceLineNo">353</span> endKeys[i] = region.getEndKey();<a name="line.353"></a>
+<span class="sourceLineNo">354</span> i++;<a name="line.354"></a>
+<span class="sourceLineNo">355</span> }<a name="line.355"></a>
+<span class="sourceLineNo">356</span><a name="line.356"></a>
+<span class="sourceLineNo">357</span> Pair<byte[][], byte[][]> keys = new Pair<>(startKeys, endKeys);<a name="line.357"></a>
+<span class="sourceLineNo">358</span> verifyStartEndKeys(keys);<a name="line.358"></a>
+<span class="sourceLineNo">359</span> }<a name="line.359"></a>
+<span class="sourceLineNo">360</span><a name="line.360"></a>
+<span class="sourceLineNo">361</span> void verifyStartEndKeys(Pair<byte[][], byte[][]> keys) {<a name="line.361"></a>
+<span class="sourceLineNo">362</span> byte[][] startKeys = keys.getFirst();<a name="line.362"></a>
+<span class="sourceLineNo">363</span> byte[][] endKeys = keys.getSecond();<a name="line.363"></a>
+<span class="sourceLineNo">364</span> assertEquals(startKeys.length, endKeys.length);<a name="line.364"></a>
+<span class="sourceLineNo">365</span> assertTrue("Found 0 regions for the table", startKeys.length > 0);<a name="line.365"></a>
+<span class="sourceLineNo">366</span><a name="line.366"></a>
+<span class="sourceLineNo">367</span> assertArrayEquals("Start key for the first region is not byte[0]",<a name="line.367"></a>
+<span class="sourceLineNo">368</span> HConstants.EMPTY_START_ROW, startKeys[0]);<a name="line.368"></a>
+<span class="sourceLineNo">369</span> byte[] prevEndKey = HConstants.EMPTY_START_ROW;<a name="line.369"></a>
+<span class="sourceLineNo">370</span><a name="line.370"></a>
+<span class="sourceLineNo">371</span> // ensure that we do not have any gaps<a name="line.371"></a>
+<span class="sourceLineNo">372</span> for (int i=0; i<startKeys.length; i++) {<a name="line.372"></a>
+<span class="sourceLineNo">373</span> assertArrayEquals(<a name="line.373"></a>
+<span class="sourceLineNo">374</span> "Hole in hbase:meta is detected. prevEndKey=" + Bytes.toStringBinary(prevEndKey)<a name="line.374"></a>
+<span class="sourceLineNo">375</span> + " ,regionStartKey=" + Bytes.toStringBinary(startKeys[i]), prevEndKey,<a name="line.375"></a>
+<span class="sourceLineNo">376</span> startKeys[i]);<a name="line.376"></a>
+<span class="sourceLineNo">377</span> prevEndKey = endKeys[i];<a name="line.377"></a>
+<span class="sourceLineNo">378</span> }<a name="line.378"></a>
+<span class="sourceLineNo">379</span> assertArrayEquals("End key for the last region is not byte[0]", HConstants.EMPTY_END_ROW,<a name="line.379"></a>
+<span class="sourceLineNo">380</span> endKeys[endKeys.length - 1]);<a name="line.380"></a>
+<span class="sourceLineNo">381</span> }<a name="line.381"></a>
+<span class="sourceLineNo">382</span><a name="line.382"></a>
+<span class="sourceLineNo">383</span> @Override<a name="line.383"></a>
+<span class="sourceLineNo">384</span> protected void chore() {<a name="line.384"></a>
+<span class="sourceLineNo">385</span> try {<a name="line.385"></a>
+<span class="sourceLineNo">386</span> verify();<a name="line.386"></a>
+<span class="sourceLineNo">387</span> } catch (Throwable ex) {<a name="line.387"></a>
+<span class="sourceLineNo">388</span> this.ex = ex;<a name="line.388"></a>
+<span class="sourceLineNo">389</span> getStopper().stop("caught exception");<a name="line.389"></a>
+<span class="sourceLineNo">390</span> }<a name="line.390"></a>
+<span class="sourceLineNo">391</span> }<a name="line.391"></a>
+<span class="sourceLineNo">392</span> }<a name="line.392"></a>
+<span class="sourceLineNo">393</span><a name="line.393"></a>
+<span class="sourceLineNo">394</span> public static void log(String msg) {<a name="line.394"></a>
+<span class="sourceLineNo">395</span> LOG.info(msg);<a name="line.395"></a>
+<span class="sourceLineNo">396</span> }<a name="line.396"></a>
+<span class="sourceLineNo">397</span><a name="line.397"></a>
+<span class="sourceLineNo">398</span> /* some utility methods for split tests */<a name="line.398"></a>
+<span class="sourceLineNo">399</span><a name="line.399"></a>
+<span class="sourceLineNo">400</span> public static void flushAndBlockUntilDone(Admin admin, HRegionServer rs, byte[] regionName)<a name="line.400"></a>
+<span class="sourceLineNo">401</span> throws IOException, InterruptedException {<a name="line.401"></a>
+<span class="sourceLineNo">402</span> log("flushing region: " + Bytes.toStringBinary(regionName));<a name="line.402"></a>
+<span class="sourceLineNo">403</span> admin.flushRegion(regionName);<a name="line.403"></a>
+<span class="sourceLineNo">404</span> log("blocking until flush is complete: " + Bytes.toStringBinary(regionName));<a name="line.404"></a>
+<span class="sourceLineNo">405</span> Threads.sleepWithoutInterrupt(500);<a name="line.405"></a>
+<span class="sourceLineNo">406</span> while (rs.getOnlineRegion(regionName).getMemStoreDataSize() > 0) {<a name="line.406"></a>
+<span class="sourceLineNo">407</span> Threads.sleep(50);<a name="line.407"></a>
+<span class="sourceLineNo">408</span> }<a name="line.408"></a>
+<span class="sourceLineNo">409</span> }<a name="line.409"></a>
+<span class="sourceLineNo">410</span><a name="line.410"></a>
+<span class="sourceLineNo">411</span> public static void compactAndBlockUntilDone(Admin admin, HRegionServer rs, byte[] regionName)<a name="line.411"></a>
+<span class="sourceLineNo">412</span> throws IOException, InterruptedException {<a name="line.412"></a>
+<span class="sourceLineNo">413</span> log("Compacting region: " + Bytes.toStringBinary(regionName));<a name="line.413"></a>
+<span class="sourceLineNo">414</span> admin.majorCompactRegion(regionName);<a name="line.414"></a>
+<span class="sourceLineNo">415</span> log("blocking until compaction is complete: " + Bytes.toStringBinary(regionName));<a name="line.415"></a>
+<span class="sourceLineNo">416</span> Threads.sleepWithoutInterrupt(500);<a name="line.416"></a>
+<span class="sourceLineNo">417</span> outer: for (;;) {<a name="line.417"></a>
+<span class="sourceLineNo">418</span> for (Store store : rs.getOnlineRegion(regionName).getStores()) {<a name="line.418"></a>
+<span class="sourceLineNo">419</span> if (store.getStorefilesCount() > 1) {<a name="line.419"></a>
+<span class="sourceLineNo">420</span> Threads.sleep(50);<a name="line.420"></a>
+<span class="sourceLineNo">421</span> continue outer;<a name="line.421"></a>
+<span class="sourceLineNo">422</span> }<a name="line.422"></a>
+<span class="sourceLineNo">423</span> }<a name="line.423"></a>
+<span class="sourceLineNo">424</span> break;<a name="line.424"></a>
+<span class="sourceLineNo">425</span> }<a name="line.425"></a>
+<span class="sourceLineNo">426</span> }<a name="line.426"></a>
+<span class="sourceLineNo">427</span><a name="line.427"></a>
+<span class="sourceLineNo">428</span> /**<a name="line.428"></a>
+<span class="sourceLineNo">429</span> * Blocks until the region split is complete in hbase:meta and region server opens the daughters<a name="line.429"></a>
+<span class="sourceLineNo">430</span> */<a name="line.430"></a>
+<span class="sourceLineNo">431</span> public static void blockUntilRegionSplit(Configuration conf, long timeout,<a name="line.431"></a>
+<span class="sourceLineNo">432</span> final byte[] regionName, boolean waitForDaughters)<a name="line.432"></a>
+<span class="sourceLineNo">433</span> throws IOException, InterruptedException {<a name="line.433"></a>
+<span class="sourceLineNo">434</span> long start = System.currentTimeMillis();<a name="line.434"></a>
+<span class="sourceLineNo">435</span> log("blocking until region is split:" + Bytes.toStringBinary(regionName));<a name="line.435"></a>
+<span class="sourceLineNo">436</span> RegionInfo daughterA = null, daughterB = null;<a name="line.436"></a>
+<span class="sourceLineNo">437</span> try (Connection conn = ConnectionFactory.createConnection(conf);<a name="line.437"></a>
+<span class="sourceLineNo">438</span> Table metaTable = conn.getTable(TableName.META_TABLE_NAME)) {<a name="line.438"></a>
+<span class="sourceLineNo">439</span> Result result = null;<a name="line.439"></a>
+<span class="sourceLineNo">440</span> RegionInfo region = null;<a name="line.440"></a>
+<span class="sourceLineNo">441</span> while ((System.currentTimeMillis() - start) < timeout) {<a name="line.441"></a>
+<span class="sourceLineNo">442</span> result = metaTable.get(new Get(regionName));<a name="line.442"></a>
+<span class="sourceLineNo">443</span> if (result == null) {<a name="line.443"></a>
+<span class="sourceLineNo">444</span> break;<a name="line.444"></a>
+<span class="sourceLineNo">445</span> }<a name="line.445"></a>
+<span class="sourceLineNo">446</span><a name="line.446"></a>
+<span class="sourceLineNo">447</span> region = MetaTableAccessor.getRegionInfo(result);<a name="line.447"></a>
+<span class="sourceLineNo">448</span> if (region.isSplitParent()) {<a name="line.448"></a>
+<span class="sourceLineNo">449</span> log("found parent region: " + region.toString());<a name="line.449"></a>
+<span class="sourceLineNo">450</span> PairOfSameType<RegionInfo> pair = MetaTableAccessor.getDaughterRegions(result);<a name="line.450"></a>
+<span class="sourceLineNo">451</span> daughterA = pair.getFirst();<a name="line.451"></a>
+<span class="sourceLineNo">452</span> daughterB = pair.getSecond();<a name="line.452"></a>
+<span class="sourceLineNo">453</span> break;<a name="line.453"></a>
+<span class="sourceLineNo">454</span> }<a name="line.454"></a>
+<span class="sourceLineNo">455</span> Threads.sleep(100);<a name="line.455"></a>
+<span class="sourceLineNo">456</span> }<a name="line.456"></a>
+<span class="sourceLineNo">457</span> if (daughterA == null || daughterB == null) {<a name="line.457"></a>
+<span class="sourceLineNo">458</span> throw new IOException("Failed to get daughters, daughterA=" + daughterA + ", daughterB=" +<a name="line.458"></a>
+<span class="sourceLineNo">459</span> daughterB + ", timeout=" + timeout + ", result=" + result + ", regionName=" +<a name="line.459"></a>
+<span class="sourceLineNo">460</span> Bytes.toString(regionName) + ", region=" + region);<a name="line.460"></a>
+<span class="sourceLineNo">461</span> }<a name="line.461"></a>
+<span class="sourceLineNo">462</span><a name="line.462"></a>
+<span class="sourceLineNo">463</span> //if we are here, this means the region split is complete or timed out<a name="line.463"></a>
+<span class="sourceLineNo">464</span> if (waitForDaughters) {<a name="line.464"></a>
+<span class="sourceLineNo">465</span> long rem = timeout - (System.currentTimeMillis() - start);<a name="line.465"></a>
+<span class="sourceLineNo">466</span> blockUntilRegionIsInMeta(conn, rem, daughterA);<a name="line.466"></a>
+<span class="sourceLineNo">467</span><a name="line.467"></a>
+<span class="sourceLineNo">468</span> rem = timeout - (System.currentTimeMillis() - start);<a name="line.468"></a>
+<span class="sourceLineNo">469</span> blockUntilRegionIsInMeta(conn, rem, daughterB);<a name="line.469"></a>
+<span class="sourceLineNo">470</span><a name="line.470"></a>
+<span class="sourceLineNo">471</span> rem = timeout - (System.currentTimeMillis() - start);<a name="line.471"></a>
+<span class="sourceLineNo">472</span> blockUntilRegionIsOpened(conf, rem, daughterA);<a name="line.472"></a>
+<span class="sourceLineNo">473</span><a name="line.473"></a>
+<span class="sourceLineNo">474</span> rem = timeout - (System.currentTimeMillis() - start);<a name="line.474"></a>
+<span class="sourceLineNo">475</span> blockUntilRegionIsOpened(conf, rem, daughterB);<a name="line.475"></a>
+<span class="sourceLineNo">476</span><a name="line.476"></a>
+<span class="sourceLineNo">477</span> // Compacting the new region to make sure references can be cleaned up<a name="line.477"></a>
+<span class="sourceLineNo">478</span> compactAndBlockUntilDone(TEST_UTIL.getAdmin(),<a name="line.478"></a>
+<span class="sourceLineNo">479</span> TEST_UTIL.getMiniHBaseCluster().getRegionServer(0), daughterA.getRegionName());<a name="line.479"></a>
+<span class="sourceLineNo">480</span> compactAndBlockUntilDone(TEST_UTIL.getAdmin(),<a name="line.480"></a>
+<span class="sourceLineNo">481</span> TEST_UTIL.getMiniHBaseCluster().getRegionServer(0), daughterB.getRegionName());<a name="line.481"></a>
+<span class="sourceLineNo">482</span><a name="line.482"></a>
+<span class="sourceLineNo">483</span> removeCompactedFiles(conn, timeout, daughterA);<a name="line.483"></a>
+<span class="sourceLineNo">484</span> removeCompactedFiles(conn, timeout, daughterB);<a name="line.484"></a>
+<span class="sourceLineNo">485</span> }<a name="line.485"></a>
+<span class="sourceLineNo">486</span> }<a name="line.486"></a>
+<span class="sourceLineNo">487</span> }<a name="line.487"></a>
+<span class="sourceLineNo">488</span><a name="line.488"></a>
+<span class="sourceLineNo">489</span> public static void removeCompactedFiles(Connection conn, long timeout, RegionInfo hri)<a name="line.489"></a>
+<span class="sourceLineNo">490</span> throws IOException, InterruptedException {<a name="line.490"></a>
+<span class="sourceLineNo">491</span> log("remove compacted files for : " + hri.getRegionNameAsString());<a name="line.491"></a>
+<span class="sourceLineNo">492</span> List<HRegion> regions = TEST_UTIL.getHBaseCluster().getRegions(hri.getTable());<a name="line.492"></a>
+<span class="sourceLineNo">493</span> regions.stream().forEach(r -> {<a name="line.493"></a>
+<span class="sourceLineNo">494</span> try {<a name="line.494"></a>
+<span class="sourceLineNo">495</span> r.getStores().get(0).closeAndArchiveCompactedFiles();<a name="line.495"></a>
+<span class="sourceLineNo">496</span> } catch (IOException ioe) {<a name="line.496"></a>
+<span class="sourceLineNo">497</span> LOG.error("failed in removing compacted file", ioe);<a name="line.497"></a>
+<span class="sourceLineNo">498</span> }<a name="line.498"></a>
+<span class="sourceLineNo">499</span> });<a name="line.499"></a>
+<span class="sourceLineNo">500</span> }<a name="line.500"></a>
+<span class="sourceLineNo">501</span><a name="line.501"></a>
+<span class="sourceLineNo">502</span> public static void blockUntilRegionIsInMeta(Connection conn, long timeout, RegionInfo hri)<a name="line.502"></a>
+<span class="sourceLineNo">503</span> throws IOException, InterruptedException {<a name="line.503"></a>
+<span class="sourceLineNo">504</span> log("blocking until region is in META: " + hri.getRegionNameAsString());<a name="line.504"></a>
+<span class="sourceLineNo">505</span> long start = System.currentTimeMillis();<a name="line.505"></a>
+<span class="sourceLineNo">506</span> while (System.currentTimeMillis() - start < timeout) {<a name="line.506"></a>
+<span class="sourceLineNo">507</span> HRegionLocation loc = MetaTableAccessor.getRegionLocation(conn, hri);<a name="line.507"></a>
+<span class="sourceLineNo">508</span> if (loc != null && !loc.getRegionInfo().isOffline()) {<a name="line.508"></a>
+<span class="sourceLineNo">509</span> log("found region in META: " + hri.getRegionNameAsString());<a name="line.509"></a>
+<span class="sourceLineNo">510</span> break;<a name="line.510"></a>
+<span class="sourceLineNo">511</span> }<a name="line.511"></a>
+<span class="sourceLineNo">512</span> Threads.sleep(10);<a name="line.512"></a>
+<span class="sourceLineNo">513</span> }<a name="line.513"></a>
+<span class="sourceLineNo">514</span> }<a name="line.514"></a>
+<span class="sourceLineNo">515</span><a name="line.515"></a>
+<span class="sourceLineNo">516</span> public static void blockUntilRegionIsOpened(Configuration conf, long timeout, RegionInfo hri)<a name="line.516"></a>
+<span class="sourceLineNo">517</span> throws IOException, InterruptedException {<a name="line.517"></a>
+<span class="sourceLineNo">518</span> log("blocking until region is opened for reading:" + hri.getRegionNameAsString());<a name="line.518"></a>
+<span class="sourceLineNo">519</span> long start = System.currentTimeMillis();<a name="line.519"></a>
+<span class="sourceLineNo">520</span> try (Connection conn = ConnectionFactory.createConnection(conf);<a name="line.520"></a>
+<span class="sourceLineNo">521</span> Table table = conn.getTable(hri.getTable())) {<a name="line.521"></a>
+<span class="sourceLineNo">522</span> byte[] row = hri.getStartKey();<a name="line.522"></a>
+<span class="sourceLineNo">523</span> // Check for null/empty row. If we find one, use a key that is likely to be in first region.<a name="line.523"></a>
+<span class="sourceLineNo">524</span> if (row == null || row.length <= 0) {<a name="line.524"></a>
+<span class="sourceLineNo">525</span> row = new byte[] { '0' };<a name="line.525"></a>
+<span class="sourceLineNo">526</span> }<a name="line.526"></a>
+<span class="sourceLineNo">527</span> Get get = new Get(row);<a name="line.527"></a>
+<span class="sourceLineNo">528</span> while (System.currentTimeMillis() - start < timeout) {<a name="line.528"></a
<TRUNCATED>