You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/19 12:27:36 UTC
[GitHub] [arrow] vertexclique opened a new pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
vertexclique opened a new pull request #9261:
URL: https://github.com/apache/arrow/pull/9261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
vertexclique commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764560085
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#discussion_r560240967
##########
File path: .github/workflows/rust.yml
##########
@@ -226,6 +226,37 @@ jobs:
cd rust
cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
+ miri-checks:
+ name: Miri Checks
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ arch: [amd64]
+ rust: [stable]
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.cargo/registry
+ ~/.cargo/git
+ target
+ key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
+ - name: Install
+ uses: actions-rs/toolchain@v1
Review comment:
This action is blocked by infra. Could you try using one of the commands on the other steps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764691368
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=h1) Report
> Merging [#9261](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=desc) (ce18ab7) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9261 +/- ##
========================================
Coverage 81.61% 81.61%
========================================
Files 215 215
Lines 51867 52508 +641
========================================
+ Hits 42329 42854 +525
- Misses 9538 9654 +116
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.67% <100.00%> (+0.17%)` | :arrow_up: |
| [rust/datafusion/src/sql/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zcWwvdXRpbHMucnM=) | `39.43% <0.00%> (-14.50%)` | :arrow_down: |
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `83.21% <0.00%> (-9.89%)` | :arrow_down: |
| [rust/datafusion/src/optimizer/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvdXRpbHMucnM=) | `49.01% <0.00%> (-9.17%)` | :arrow_down: |
| [rust/datafusion/src/datasource/memory.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL21lbW9yeS5ycw==) | `79.75% <0.00%> (-6.52%)` | :arrow_down: |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `6.97% <0.00%> (-5.22%)` | :arrow_down: |
| [rust/arrow/src/bytes.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnl0ZXMucnM=) | `53.12% <0.00%> (-5.21%)` | :arrow_down: |
| [rust/arrow/src/memory.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvbWVtb3J5LnJz) | `93.02% <0.00%> (-5.13%)` | :arrow_down: |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `95.00% <0.00%> (-5.00%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/common.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvbW1vbi5ycw==) | `74.28% <0.00%> (-4.51%)` | :arrow_down: |
| ... and [91 more](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=footer). Last update [903b41c...ce18ab7](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique commented on a change in pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
vertexclique commented on a change in pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#discussion_r560246006
##########
File path: .github/workflows/rust.yml
##########
@@ -226,6 +226,37 @@ jobs:
cd rust
cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
+ miri-checks:
+ name: Miri Checks
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ arch: [amd64]
+ rust: [stable]
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.cargo/registry
+ ~/.cargo/git
+ target
+ key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
+ - name: Install
+ uses: actions-rs/toolchain@v1
Review comment:
Cool, I have changed it. Now it has started.
##########
File path: .github/workflows/rust.yml
##########
@@ -226,6 +226,37 @@ jobs:
cd rust
cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
+ miri-checks:
+ name: Miri Checks
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ arch: [amd64]
+ rust: [stable]
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.cargo/registry
+ ~/.cargo/git
+ target
+ key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
+ - name: Install
+ uses: actions-rs/toolchain@v1
Review comment:
Cool, I have changed it. Now it has started. Thanks 🥳
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764604319
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#discussion_r562040108
##########
File path: .github/workflows/rust.yml
##########
@@ -226,6 +226,40 @@ jobs:
cd rust
cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
+ miri-checks:
+ name: Miri Checks
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ arch: [amd64]
+ rust: [nightly-2021-01-19]
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.cargo/registry
+ ~/.cargo/git
+ target
+ key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
+ - name: Setup Rust toolchain
+ run: |
+ rustup toolchain install ${{ matrix.rust }}
+ rustup default ${{ matrix.rust }}
+ rustup component add rustfmt clippy miri
+ - name: Run Miri Checks
+ env:
+ RUST_BACKTRACE: full
+ RUST_LOG: 'trace'
+ run: |
+ export MIRIFLAGS="-Zmiri-disable-isolation"
+ cd rust
+ cargo miri setup
+ cargo clean
+ cargo miri test || true
Review comment:
```suggestion
# Ignore MIRI errors until we can get a clean run
cargo miri test || true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
vertexclique commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764560085
@alamb @jorgecarleitao checks are working right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9261:
URL: https://github.com/apache/arrow/pull/9261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#discussion_r562040108
##########
File path: .github/workflows/rust.yml
##########
@@ -226,6 +226,40 @@ jobs:
cd rust
cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
+ miri-checks:
+ name: Miri Checks
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ arch: [amd64]
+ rust: [nightly-2021-01-19]
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.cargo/registry
+ ~/.cargo/git
+ target
+ key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
+ - name: Setup Rust toolchain
+ run: |
+ rustup toolchain install ${{ matrix.rust }}
+ rustup default ${{ matrix.rust }}
+ rustup component add rustfmt clippy miri
+ - name: Run Miri Checks
+ env:
+ RUST_BACKTRACE: full
+ RUST_LOG: 'trace'
+ run: |
+ export MIRIFLAGS="-Zmiri-disable-isolation"
+ cd rust
+ cargo miri setup
+ cargo clean
+ cargo miri test || true
Review comment:
```suggestion
# Ignore MIRI errors until we can get a clean run
cargo miri test || true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique edited a comment on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
vertexclique edited a comment on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-762892056
If that triggers that would be nice. I will try it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9261:
URL: https://github.com/apache/arrow/pull/9261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
vertexclique commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764612049
I want to merge the checks first then carry on with fixes in different prs as a cooperative effort to not making this pr and ticket complicated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764691368
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=h1) Report
> Merging [#9261](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=desc) (8d10789) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9261 +/- ##
========================================
Coverage 81.61% 81.61%
========================================
Files 215 215
Lines 51867 52508 +641
========================================
+ Hits 42329 42853 +524
- Misses 9538 9655 +117
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.67% <100.00%> (+0.17%)` | :arrow_up: |
| [rust/datafusion/src/sql/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zcWwvdXRpbHMucnM=) | `39.43% <0.00%> (-14.50%)` | :arrow_down: |
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `83.21% <0.00%> (-9.89%)` | :arrow_down: |
| [rust/datafusion/src/optimizer/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvdXRpbHMucnM=) | `49.01% <0.00%> (-9.17%)` | :arrow_down: |
| [rust/datafusion/src/datasource/memory.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL21lbW9yeS5ycw==) | `79.75% <0.00%> (-6.52%)` | :arrow_down: |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `6.97% <0.00%> (-5.22%)` | :arrow_down: |
| [rust/arrow/src/bytes.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnl0ZXMucnM=) | `53.12% <0.00%> (-5.21%)` | :arrow_down: |
| [rust/arrow/src/memory.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvbWVtb3J5LnJz) | `93.02% <0.00%> (-5.13%)` | :arrow_down: |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `95.00% <0.00%> (-5.00%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/common.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvbW1vbi5ycw==) | `74.28% <0.00%> (-4.51%)` | :arrow_down: |
| ... and [91 more](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=footer). Last update [903b41c...8d10789](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
vertexclique commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764709219
@alamb fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764691368
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=h1) Report
> Merging [#9261](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=desc) (8d10789) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9261 +/- ##
========================================
Coverage 81.61% 81.61%
========================================
Files 215 215
Lines 51867 52508 +641
========================================
+ Hits 42329 42853 +524
- Misses 9538 9655 +117
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.67% <100.00%> (+0.17%)` | :arrow_up: |
| [rust/datafusion/src/sql/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zcWwvdXRpbHMucnM=) | `39.43% <0.00%> (-14.50%)` | :arrow_down: |
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `83.21% <0.00%> (-9.89%)` | :arrow_down: |
| [rust/datafusion/src/optimizer/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvdXRpbHMucnM=) | `49.01% <0.00%> (-9.17%)` | :arrow_down: |
| [rust/datafusion/src/datasource/memory.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL21lbW9yeS5ycw==) | `79.75% <0.00%> (-6.52%)` | :arrow_down: |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `6.97% <0.00%> (-5.22%)` | :arrow_down: |
| [rust/arrow/src/bytes.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnl0ZXMucnM=) | `53.12% <0.00%> (-5.21%)` | :arrow_down: |
| [rust/arrow/src/memory.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvbWVtb3J5LnJz) | `93.02% <0.00%> (-5.13%)` | :arrow_down: |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `95.00% <0.00%> (-5.00%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/common.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvbW1vbi5ycw==) | `74.28% <0.00%> (-4.51%)` | :arrow_down: |
| ... and [91 more](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=footer). Last update [903b41c...8d10789](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
vertexclique commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-762829645
Checks are not running in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764617123
@vertexclique merging the checks makes sense -- however, i think we need to figure out how to avoid github signaling a failure (red x) so that we can get clean CI runs
<img width="956" alt="Screen Shot 2021-01-21 at 7 40 31 AM" src="https://user-images.githubusercontent.com/490673/105352478-f1486e80-5bbb-11eb-9e96-734f03864da3.png">
Is there some way to instruct Miri to ignore failures or a known failure list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
vertexclique commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-762892056
If that triggers that would be nice. Can you commit to this branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764604319
@vertexclique -- this is really cool. Thank you
So now I notice that the MIRI check is flagging what is presumably an error. Is that something you are planning to fix? If not I might be able to find some time to do so
https://github.com/apache/arrow/pull/9261/checks?check_run_id=1729267740
```
test array::builder::tests::test_string_dictionary_builder_with_reserved_null_value ... ok
error: Undefined Behavior: trying to reborrow for SharedReadWrite at alloc8703298, but parent tag <23938158> does not have an appropriate item in the borrow stack
--> arrow/src/array/builder.rs:1460:9
|
1460 | self.field_anys[i].downcast_mut::<T>()
| ^^^^^^^^^^^^^^^^^^ trying to reborrow for SharedReadWrite at alloc8703298, but parent tag <23938158> does not have an appropriate item in the borrow stack
|
= help: this indicates a potential bug in the program: it performed an invalid operation, but the rules it violated are still experimental
= help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information
= note: inside `array::builder::StructBuilder::field_builder::<array::builder::GenericStringBuilder<i32>>` at arrow/src/array/builder.rs:1460:9
note: inside `array::builder::tests::test_struct_array_builder` at arrow/src/array/builder.rs:2827:30
--> arrow/src/array/builder.rs:2827:30
|
2827 | let string_builder = builder
| ______________________________^
2828 | | .field_builder::<StringBuilder>(0)
| |______________________________________________^
note: inside closure at arrow/src/array/builder.rs:2813:5
--> arrow/src/array/builder.rs:2813:5
|
2813 | / fn test_struct_array_builder() {
2814 | | let string_builder = StringBuilder::new(4);
2815 | | let int_builder = Int32Builder::new(4);
2816 | |
... |
2892 | | }
2893 | | }
| |_____^
= note: inside `<[closure@arrow/src/array/builder.rs:2813:5: 2893:6] as std::ops::FnOnce<()>>::call_once - shim` at /usr/share/rust/.rustup/toolchains/nightly-2021-01-19-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-762889579
> Checks are not running in this PR.
@vertexclique I wonder if you could trigger the checks by making some minor change to the rust source files (e.g a comment update or something)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-762813872
https://issues.apache.org/jira/browse/ARROW-11141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#issuecomment-764691368
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=h1) Report
> Merging [#9261](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=desc) (ce18ab7) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9261 +/- ##
========================================
Coverage 81.61% 81.61%
========================================
Files 215 215
Lines 51867 52508 +641
========================================
+ Hits 42329 42854 +525
- Misses 9538 9654 +116
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.67% <100.00%> (+0.17%)` | :arrow_up: |
| [rust/datafusion/src/sql/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zcWwvdXRpbHMucnM=) | `39.43% <0.00%> (-14.50%)` | :arrow_down: |
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `83.21% <0.00%> (-9.89%)` | :arrow_down: |
| [rust/datafusion/src/optimizer/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvdXRpbHMucnM=) | `49.01% <0.00%> (-9.17%)` | :arrow_down: |
| [rust/datafusion/src/datasource/memory.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL21lbW9yeS5ycw==) | `79.75% <0.00%> (-6.52%)` | :arrow_down: |
| [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `6.97% <0.00%> (-5.22%)` | :arrow_down: |
| [rust/arrow/src/bytes.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnl0ZXMucnM=) | `53.12% <0.00%> (-5.21%)` | :arrow_down: |
| [rust/arrow/src/memory.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvbWVtb3J5LnJz) | `93.02% <0.00%> (-5.13%)` | :arrow_down: |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `95.00% <0.00%> (-5.00%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/common.rs](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvbW1vbi5ycw==) | `74.28% <0.00%> (-4.51%)` | :arrow_down: |
| ... and [91 more](https://codecov.io/gh/apache/arrow/pull/9261/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=footer). Last update [903b41c...ce18ab7](https://codecov.io/gh/apache/arrow/pull/9261?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org