[jira] [Comment Edited] (THRIFT-2457) fbthrift float

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988148#comment-13988148 ] 

Jens Geyer edited comment on THRIFT-2457 at 5/2/14 7:46 PM:
------------------------------------------------------------

{quote}
A compiler supporting float will provide this warning:
{code}
use Thrift Libraries > 0.9.1 or latest version, they should handle float properly
{code}
a old compiler this:
{code}
thrift -gen cpp Float.thrift
[ERROR:Float.thrift:21] (last token was 'float')
Cannot use reserved language keyword: "float"
{code}
{quote}

Exactly. So the old compiler/library pair does not understand float, and the new compiler/library pair understands and handles it (except for the short time period where not all languages have completed implementation).

Hence, the warning will only makes sense for someone using compiler/library pair with mixed versions. Is that really such a common case?


was (Author: jensg):
{quote}
A compiler supporting float will provide this warning:
{code}
use Thrift Libraries > 0.9.1 or latest version, they should handle float properly
{code}
a old compiler this:
{code}
thrift -gen cpp Float.thrift
[ERROR:Float.thrift:21] (last token was 'float')
Cannot use reserved language keyword: "float"
{code}
{quote}

Exactly. So the old compiler/library pair does not understand float, and the new compiler/library pair understands and handles it (except for the short trime period where not all languages have completed implementation).

Hence, the warning will only makes sense for someone using compiler/library pair with mixed versions. Is that really such a so common case?

> fbthrift float
> --------------
>
>                 Key: THRIFT-2457
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2457
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Build Process, C++ - Compiler, C++ - Library, Test Suite
>            Reporter: Roger Meier
>            Priority: Minor
>             Fix For: 1.0
>
>
> I'm interested into the fbthrift FLOAT data type.
> Which languages are supported?



--
This message was sent by Atlassian JIRA
(v6.2#6252)