You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by sj...@apache.org on 2016/07/13 17:29:43 UTC
[3/5] brooklyn-server git commit: LoopOverGroupMembersTestCase checks
status of entities before deciding success/failure
LoopOverGroupMembersTestCase checks status of entities before deciding success/failure
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/8af60af0
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/8af60af0
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/8af60af0
Branch: refs/heads/master
Commit: 8af60af0b5fcc7abfc4dad76598cd0dddcd4d4a9
Parents: 921a776
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Authored: Mon Jun 20 18:46:23 2016 +0100
Committer: Sam Corbett <sa...@cloudsoftcorp.com>
Committed: Wed Jul 6 12:02:07 2016 +0100
----------------------------------------------------------------------
.../test/framework/LoopOverGroupMembersTestCaseImpl.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/8af60af0/test-framework/src/main/java/org/apache/brooklyn/test/framework/LoopOverGroupMembersTestCaseImpl.java
----------------------------------------------------------------------
diff --git a/test-framework/src/main/java/org/apache/brooklyn/test/framework/LoopOverGroupMembersTestCaseImpl.java b/test-framework/src/main/java/org/apache/brooklyn/test/framework/LoopOverGroupMembersTestCaseImpl.java
index 8a10797..cbde76e 100644
--- a/test-framework/src/main/java/org/apache/brooklyn/test/framework/LoopOverGroupMembersTestCaseImpl.java
+++ b/test-framework/src/main/java/org/apache/brooklyn/test/framework/LoopOverGroupMembersTestCaseImpl.java
@@ -75,7 +75,12 @@ public class LoopOverGroupMembersTestCaseImpl extends TargetableTestComponentImp
try {
TargetableTestComponent targetableTestComponent = this.addChild(testSpecCopy);
targetableTestComponent.start(locations);
- logger.debug("Task of {} successfully run, targetting {}", this, member);
+ if (Lifecycle.RUNNING.equals(targetableTestComponent.sensors().get(Attributes.SERVICE_STATE_ACTUAL))) {
+ logger.debug("Task of {} successfully run, targetting {}", this, member);
+ } else {
+ logger.warn("Problem in child test-case of {}, targetting {}", this, member);
+ allSuccesful = false;
+ }
} catch (Throwable t) {
Exceptions.propagateIfFatal(t);
logger.warn("Problem in child test-case of "+this+", targetting "+member, t);