You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/02 07:52:20 UTC
[GitHub] [flink] nicoweidner opened a new pull request #17114: [FLINK-20427][runtime/checkpointing] Remove prefer-checkpoint-for-recovery setting
nicoweidner opened a new pull request #17114:
URL: https://github.com/apache/flink/pull/17114
## What is the purpose of the change
This PR removes the config option to prefer checkpoints for recovery even if a newer savepoint exists. It was deprecated since Flink 1.12 because it can lead to loss of data.
## Brief change log
- *prefer-checkpoint-for-recovery is removed from code and docs*
- *ZooKeeperCompletedCheckpointStoreMockitoTest was removed after a discussion with @tillrohrmann as it does not reflect the current code base anymore and is superseded by other tests*
## Verifying this change
*This change is already covered by existing tests*.
Tests for the removed config setting were removed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes: checkpointing
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no (removes one config option instead)
- If yes, how is the feature documented? docs (feature was removed from docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17114: [FLINK-20427][runtime/checkpointing] Remove prefer-checkpoint-for-recovery setting
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17114:
URL: https://github.com/apache/flink/pull/17114#issuecomment-911411518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23392",
"triggerID" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"triggerType" : "PUSH"
}, {
"hash" : "2539e1edda2838b797e1e42e0a2722cef39dfb70",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2539e1edda2838b797e1e42e0a2722cef39dfb70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b392ec004ccfb8464f6da508677907e53b15fd2d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23392)
* 2539e1edda2838b797e1e42e0a2722cef39dfb70 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17114: [FLINK-20427][runtime/checkpointing] Remove prefer-checkpoint-for-recovery setting
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17114:
URL: https://github.com/apache/flink/pull/17114#issuecomment-911411518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23392",
"triggerID" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b392ec004ccfb8464f6da508677907e53b15fd2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23392)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #17114: [FLINK-20427][runtime/checkpointing] Remove prefer-checkpoint-for-recovery setting
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #17114:
URL: https://github.com/apache/flink/pull/17114#discussion_r701107733
##########
File path: flink-python/pyflink/datastream/checkpoint_config.py
##########
@@ -255,28 +255,6 @@ def is_externalized_checkpoints_enabled(self) -> bool:
"""
return self._j_checkpoint_config.isExternalizedCheckpointsEnabled()
- def is_prefer_checkpoint_for_recovery(self) -> bool:
- """
- Returns whether a job recovery should fallback to checkpoint when there is a more recent
- savepoint.
-
- :return: ``True`` if a job recovery should fallback to checkpoint, false otherwise.
- """
- return self._j_checkpoint_config.isPreferCheckpointForRecovery()
-
- def set_prefer_checkpoint_for_recovery(
- self,
- prefer_checkpoint_for_recovery: bool) -> 'CheckpointConfig':
- """
- Sets whether a job recovery should fallback to checkpoint when there is a more recent
- savepoint.
-
- :param prefer_checkpoint_for_recovery: ``True`` if a job recovery should fallback to
- checkpoint, false otherwise.
- """
- self._j_checkpoint_config.setPreferCheckpointForRecovery(prefer_checkpoint_for_recovery)
- return self
Review comment:
Nice, I would probably have missed this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17114: [FLINK-20427][runtime/checkpointing] Remove prefer-checkpoint-for-recovery setting
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17114:
URL: https://github.com/apache/flink/pull/17114#issuecomment-911411518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23392",
"triggerID" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"triggerType" : "PUSH"
}, {
"hash" : "2539e1edda2838b797e1e42e0a2722cef39dfb70",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23422",
"triggerID" : "2539e1edda2838b797e1e42e0a2722cef39dfb70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2539e1edda2838b797e1e42e0a2722cef39dfb70 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17114: [FLINK-20427][runtime/checkpointing] Remove prefer-checkpoint-for-recovery setting
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17114:
URL: https://github.com/apache/flink/pull/17114#issuecomment-911411518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23392",
"triggerID" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"triggerType" : "PUSH"
}, {
"hash" : "2539e1edda2838b797e1e42e0a2722cef39dfb70",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23422",
"triggerID" : "2539e1edda2838b797e1e42e0a2722cef39dfb70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b392ec004ccfb8464f6da508677907e53b15fd2d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23392)
* 2539e1edda2838b797e1e42e0a2722cef39dfb70 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #17114: [FLINK-20427][runtime/checkpointing] Remove prefer-checkpoint-for-recovery setting
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #17114:
URL: https://github.com/apache/flink/pull/17114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17114: [FLINK-20427][runtime/checkpointing] Remove prefer-checkpoint-for-recovery setting
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17114:
URL: https://github.com/apache/flink/pull/17114#issuecomment-911341308
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b392ec004ccfb8464f6da508677907e53b15fd2d (Thu Sep 02 07:56:07 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17114: [FLINK-20427][runtime/checkpointing] Remove prefer-checkpoint-for-recovery setting
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17114:
URL: https://github.com/apache/flink/pull/17114#issuecomment-911411518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23392",
"triggerID" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b392ec004ccfb8464f6da508677907e53b15fd2d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23392)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17114: [FLINK-20427][runtime/checkpointing] Remove prefer-checkpoint-for-recovery setting
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17114:
URL: https://github.com/apache/flink/pull/17114#issuecomment-911411518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b392ec004ccfb8464f6da508677907e53b15fd2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b392ec004ccfb8464f6da508677907e53b15fd2d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org