[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8029: ARROW-9464: [Rust] [DataFusion] Remove Partition trait

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #8029:
URL: https://github.com/apache/arrow/pull/8029#discussion_r475168077



##########
File path: rust/datafusion/src/execution/physical_plan/sort.rs
##########
@@ -61,44 +61,28 @@ impl ExecutionPlan for SortExec {
         self.input.schema().clone()
     }
 
-    fn partitions(&self) -> Result<Vec<Arc<dyn Partition>>> {
-        Ok(vec![
-            (Arc::new(SortPartition {
-                input: self.input.partitions()?,
-                expr: self.expr.clone(),
-                schema: self.schema(),
-                concurrency: self.concurrency,
-            })),
-        ])
+    /// Get the output partitioning of this plan
+    fn output_partitioning(&self) -> Partitioning {
+        Partitioning::UnknownPartitioning(1)

Review comment:
       To make sure I am following: this is 1 because we pull everything to the same partition in a sort via `Merge`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org