[GitHub] [geode] jhuynh1 opened pull request #2850: GEODE-5228: Stale status file is deleted before waiting for status re…

["jhuynh1 (GitHub)" <gi...@apache.org>]

…sponse file

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2850 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jhuynh1 closed pull request #2850: GEODE-5228: Stale status file is deleted before waiting for status re…

["jhuynh1 (GitHub)" <gi...@apache.org>]

[ pull request closed by jhuynh1 ]

[ Full content available at: https://github.com/apache/geode/pull/2850 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jhuynh1 commented on pull request #2850: GEODE-5228: Stale status file is deleted before waiting for status re…

["jhuynh1 (GitHub)" <gi...@apache.org>]

Modified, although the call to this method is in a separate thread now, so it logs the exception as a warning.  Maybe it should be info level.

[ Full content available at: https://github.com/apache/geode/pull/2850 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #2850: GEODE-5228: Stale status file is deleted before waiting for status re…

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

I'd suggest using `File.delete(Path)` which will give you the actual exception in case of failure to delete.

[ Full content available at: https://github.com/apache/geode/pull/2850 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2850: GEODE-5228: Stale status file is deleted before waiting for status re…

["kirklund (GitHub)" <gi...@apache.org>]

This fix will also fix GEODE-3506.

[ Full content available at: https://github.com/apache/geode/pull/2850 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org