[GitHub] [fineract] galovics commented on a diff in pull request #3207: FINERACT-1926: Asset transfer to external owner COB business step

["galovics (via GitHub)" <gi...@apache.org>]

galovics commented on code in PR #3207:
URL: https://github.com/apache/fineract/pull/3207#discussion_r1210122162


##########
fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java:
##########
@@ -0,0 +1,180 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.investor.cob.loan;
+
+import java.math.BigDecimal;
+import java.time.LocalDate;
+import java.util.List;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.fineract.cob.loan.LoanCOBBusinessStep;
+import org.apache.fineract.infrastructure.core.service.DateUtils;
+import org.apache.fineract.investor.data.ExternalTransferStatus;
+import org.apache.fineract.investor.data.ExternalTransferSubStatus;
+import org.apache.fineract.investor.domain.ExternalAssetOwnerTransfer;
+import org.apache.fineract.investor.service.ExternalAssetOwnersReadService;
+import org.apache.fineract.investor.service.ExternalAssetOwnersWriteService;
+import org.apache.fineract.portfolio.loanaccount.domain.Loan;
+import org.springframework.stereotype.Component;
+
+@Component
+@RequiredArgsConstructor
+@Slf4j
+public class LoanAccountOwnerTransferBusinessStep implements LoanCOBBusinessStep {
+
+    private final ExternalAssetOwnersReadService externalAssetOwnersReadService;
+    private final ExternalAssetOwnersWriteService externalAssetOwnersWriteService;
+
+    @Override
+    public Loan execute(Loan loan) {
+        Long loanId = loan.getId();
+        log.debug("start processing loan ownership transfer business step for loan with Id [{}]", loanId);
+
+        LocalDate settlementDate = DateUtils.getBusinessLocalDate();
+        List<ExternalAssetOwnerTransfer> transferDataList = externalAssetOwnersReadService.retrieveTransfers(loanId, settlementDate,
+                List.of(ExternalTransferStatus.PENDING, ExternalTransferStatus.ACTIVE, ExternalTransferStatus.BUYBACK));
+        int size = transferDataList.size();
+
+        if (size > 2) {
+            throw new IllegalStateException(

Review Comment:
   I understand the purpose of this, but don't you think it'd be better to catch this when submitting a transfer?



##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteService.java:
##########
@@ -20,10 +20,19 @@
 
 import org.apache.fineract.infrastructure.core.api.JsonCommand;
 import org.apache.fineract.infrastructure.core.data.CommandProcessingResult;
+import org.apache.fineract.investor.domain.ExternalAssetOwnerTransfer;
+import org.apache.fineract.investor.domain.ExternalAssetOwnerTransferLoanMapping;
 
 public interface ExternalAssetOwnersWriteService {
 
     CommandProcessingResult saleLoanByLoanId(JsonCommand command);
 
-    CommandProcessingResult buyBackLoanByLoanId(JsonCommand command);
+    CommandProcessingResult buybackLoanByLoanId(JsonCommand command);
+
+    ExternalAssetOwnerTransfer save(ExternalAssetOwnerTransfer externalAssetOwnerTransfer);

Review Comment:
   Same as above for the read service on boundaries.



##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteService.java:
##########
@@ -20,10 +20,19 @@
 
 import org.apache.fineract.infrastructure.core.api.JsonCommand;
 import org.apache.fineract.infrastructure.core.data.CommandProcessingResult;
+import org.apache.fineract.investor.domain.ExternalAssetOwnerTransfer;
+import org.apache.fineract.investor.domain.ExternalAssetOwnerTransferLoanMapping;
 
 public interface ExternalAssetOwnersWriteService {
 
     CommandProcessingResult saleLoanByLoanId(JsonCommand command);
 
-    CommandProcessingResult buyBackLoanByLoanId(JsonCommand command);
+    CommandProcessingResult buybackLoanByLoanId(JsonCommand command);
+
+    ExternalAssetOwnerTransfer save(ExternalAssetOwnerTransfer externalAssetOwnerTransfer);
+
+    void removeActiveMapping(Long loanId, ExternalAssetOwnerTransfer externalAssetOwnerTransfer);

Review Comment:
   Bonus: here as well since the parameter is an entity.



##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersReadServiceImpl.java:
##########
@@ -48,4 +52,16 @@ public List<ExternalTransferData> retrieveTransferData(Long loanId, String exter
         }
         return result.stream().map(mapper::mapTransfer).toList();
     }
+
+    @Override

Review Comment:
   Let's not let entities past through the transactional boundary (i.e. the service is annotated with Transactional so anything that's coming out of that will be detached) and could cause maintenance issues in the future (just like for the majority of fineract today).



##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java:
##########
@@ -91,6 +94,25 @@ public CommandProcessingResult buyBackLoanByLoanId(JsonCommand command) {
         return buildResponseData(savedExternalAssetOwnerTransfer);
     }
 
+    @Override
+    @Transactional

Review Comment:
   Let's simply annotate the class instead.



##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteService.java:
##########
@@ -20,10 +20,19 @@
 
 import org.apache.fineract.infrastructure.core.api.JsonCommand;
 import org.apache.fineract.infrastructure.core.data.CommandProcessingResult;
+import org.apache.fineract.investor.domain.ExternalAssetOwnerTransfer;
+import org.apache.fineract.investor.domain.ExternalAssetOwnerTransferLoanMapping;
 
 public interface ExternalAssetOwnersWriteService {
 
     CommandProcessingResult saleLoanByLoanId(JsonCommand command);
 
-    CommandProcessingResult buyBackLoanByLoanId(JsonCommand command);
+    CommandProcessingResult buybackLoanByLoanId(JsonCommand command);
+
+    ExternalAssetOwnerTransfer save(ExternalAssetOwnerTransfer externalAssetOwnerTransfer);
+
+    void removeActiveMapping(Long loanId, ExternalAssetOwnerTransfer externalAssetOwnerTransfer);
+
+    ExternalAssetOwnerTransferLoanMapping createActiveMapping(Long loanId, ExternalAssetOwnerTransfer externalAssetOwnerTransfer);

Review Comment:
   Same as above for the read service on boundaries.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org