You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/09/10 22:10:54 UTC
[kudu-CR] [python] Implement Scan Token API
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4367
Change subject: [python] Implement Scan Token API
......................................................................
[python] Implement Scan Token API
First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401. I included several
unit tests, most of which were based on the current scanner unit tests.
Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/requirements.txt
5 files changed, 617 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/1
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
[kudu-CR] [python] Implement Scan Token API
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 7:
Build Started http://104.196.14.100/job/kudu-gerrit/3352/
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] Implement Scan Token API
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4367/5/python/kudu/tests/test_scantoken.py
File python/kudu/tests/test_scantoken.py:
Line 77: input = self._package_input(builder.build())
> Cant move it to _get_scan_token_results since I need to serialize the token
beyond just creating the tokens, it looks like spinning up the thread pool, collecting results, and comparing against the expected set is all in common. Could that all be collapsed together?
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [python] Implement Scan Token API
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/3341/
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [python] Implement Scan Token API
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [python] Implement Scan Token API
......................................................................
[python] Implement Scan Token API
First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401. I included several
unit tests, most of which were based on the current scanner unit tests.
Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Reviewed-on: http://gerrit.cloudera.org:8080/4367
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@cloudera.com>
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/setup.py
5 files changed, 604 insertions(+), 8 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] Implement Scan Token API
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4367
to look at the new patch set (#7).
Change subject: [python] Implement Scan Token API
......................................................................
[python] Implement Scan Token API
First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401. I included several
unit tests, most of which were based on the current scanner unit tests.
Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/setup.py
5 files changed, 623 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/7
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] Implement Scan Token API
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4367
to look at the new patch set (#8).
Change subject: [python] Implement Scan Token API
......................................................................
[python] Implement Scan Token API
First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401. I included several
unit tests, most of which were based on the current scanner unit tests.
Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/setup.py
5 files changed, 604 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/8
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] Implement Scan Token API
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4367
to look at the new patch set (#3).
Change subject: [python] Implement Scan Token API
......................................................................
[python] Implement Scan Token API
First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401. I included several
unit tests, most of which were based on the current scanner unit tests.
Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/requirements.txt
5 files changed, 611 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/3
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [python] Implement Scan Token API
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 6:
Build Started http://104.196.14.100/job/kudu-gerrit/3350/
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] Implement Scan Token API
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 5:
Build Started http://104.196.14.100/job/kudu-gerrit/3347/
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] Implement Scan Token API
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 8:
Build Started http://104.196.14.100/job/kudu-gerrit/3375/
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] Implement Scan Token API
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3340/
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [python] Implement Scan Token API
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4367
to look at the new patch set (#4).
Change subject: [python] Implement Scan Token API
......................................................................
[python] Implement Scan Token API
First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401. I included several
unit tests, most of which were based on the current scanner unit tests.
Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/requirements.txt
5 files changed, 608 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/4
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [python] Implement Scan Token API
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 6:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4367/5/python/kudu/tests/test_scantoken.py
File python/kudu/tests/test_scantoken.py:
Line 35: Stolen from the the test scanner given the similarity in
> Stolen & Similarity are mispelled
Done
Line 77: builder = self.table.scan_token_builder()
> It looks like this line and below is repeated for the three tests, could yo
Cant move it to _get_scan_token_results since I need to serialize the tokens in the main thread before shipping to the new threads. However, I did create a helper function within the class to clean this up a bit.
http://gerrit.cloudera.org:8080/#/c/4367/5/python/requirements.txt
File python/requirements.txt:
Line 6
> This is a test-only dependency, right? Is there anyway to express that wit
Good point, i moved this to setup.py in the tests_require list.
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [python] Implement Scan Token API
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4367
to look at the new patch set (#6).
Change subject: [python] Implement Scan Token API
......................................................................
[python] Implement Scan Token API
First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401. I included several
unit tests, most of which were based on the current scanner unit tests.
Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/setup.py
5 files changed, 627 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/6
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] Implement Scan Token API
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] Implement Scan Token API
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3339/
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [python] Implement Scan Token API
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4367
to look at the new patch set (#2).
Change subject: [python] Implement Scan Token API
......................................................................
[python] Implement Scan Token API
First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401. I included several
unit tests, most of which were based on the current scanner unit tests.
Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/requirements.txt
5 files changed, 638 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/2
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [python] Implement Scan Token API
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4367
to look at the new patch set (#5).
Change subject: [python] Implement Scan Token API
......................................................................
[python] Implement Scan Token API
First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401. I included several
unit tests, most of which were based on the current scanner unit tests.
Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/requirements.txt
5 files changed, 623 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/5
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] Implement Scan Token API
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4367/5/python/kudu/tests/test_scantoken.py
File python/kudu/tests/test_scantoken.py:
Line 77: actual_tuples = []
> beyond just creating the tokens, it looks like spinning up the thread pool,
Done
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [python] Implement Scan Token API
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/3343/
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [python] Implement Scan Token API
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [python] Implement Scan Token API
......................................................................
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4367/5/python/kudu/tests/test_scantoken.py
File python/kudu/tests/test_scantoken.py:
Line 35: Stollen from the the test scanner given the simiilarity in
Stolen & Similarity are mispelled
Line 77: input = [(token.serialize(), self.master_host, self.master_port) for token in builder.build()]
It looks like this line and below is repeated for the three tests, could you roll this into _get_scan_token_results to help remove some of the duplication?
http://gerrit.cloudera.org:8080/#/c/4367/5/python/requirements.txt
File python/requirements.txt:
Line 6: multiprocessing
This is a test-only dependency, right? Is there anyway to express that with pip?
--
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes