[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1498: HDDS-4339. Skip aws signature when it's absent in header.

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #1498:
URL: https://github.com/apache/hadoop-ozone/pull/1498#discussion_r507293372



##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java
##########
@@ -116,6 +116,13 @@ private OzoneClient getClient(OzoneConfiguration config) throws IOException {
     }
   }
 
+  // ONLY validate aws access id when needed.
+  private void validateAccessId(String awsAccessId) throws Exception {
+    if (awsAccessId == null || awsAccessId.equals("")) {
+      throw S3_AUTHINFO_CREATION_ERROR;

Review comment:
       https://github.com/apache/hadoop-ozone/pull/1110#issuecomment-648405855
   
   When S3 misses the auth header error returned is AuthorizationHeaderMalformedHeader.
   
   Question: After this fix, will it show this error when the auth header is missing or it will be just logged in S3G logs? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org