You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/26 22:22:27 UTC

[GitHub] [airflow] Taragolis commented on a diff in pull request #25980: Deprecate AWS S3 Connection Type

Taragolis commented on code in PR #25980:
URL: https://github.com/apache/airflow/pull/25980#discussion_r956478482


##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -115,7 +115,7 @@ class S3Hook(AwsBaseHook):
     """
 
     conn_type = 's3'
-    hook_name = 'Amazon S3'
+    hook_name = 'Amazon S3 (Deprecated)'

Review Comment:
   `hook_name` only use in UI and CLI (`airflow providers hooks`) for custom name of Connection as it described in base hook module 
   
   https://github.com/apache/airflow/blob/5c52bbf32d81291b57d051ccbd1a2479ff706efc/airflow/hooks/base.py#L108-L111
   
   ![image](https://user-images.githubusercontent.com/3998685/186997694-35a1b702-cb78-41e8-9cbd-05552585da40.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org