You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/31 16:24:58 UTC
[GitHub] [flink] leonardBang opened a new pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
leonardBang opened a new pull request #13289:
URL: https://github.com/apache/flink/pull/13289
## What is the purpose of the change
* This pull request support flexible syntax for Temporal table join.
* This PR also can support computed column on temporal table which is a project on TableScan.
## Brief change log
- Override `convertFrom()` in `SqlToRelConverter` to support flexible `LogicalSnapshot`
## Verifying this change
Add unit tests and ITCase to cover.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683886127
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ef462e3d6a961f1d353a84e8ae55982c97c67a8e (Fri Feb 19 07:23:04 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-697081273
> The compile is failed, please fix it first.
>
> ```
> FlinkPlannerImpl.scala message=File line length exceeds 100 characters line=168
> ```
I've fixed and rebased
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-695893187
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13289:
URL: https://github.com/apache/flink/pull/13289#discussion_r492517117
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkPlannerImpl.scala
##########
@@ -163,7 +163,35 @@ class FlinkPlannerImpl(
sqlValidator.getCatalogReader.unwrap(classOf[CalciteCatalogReader]),
cluster,
convertletTable,
- sqlToRelConverterConfig)
+ sqlToRelConverterConfig) {
+ // override convertFrom() to support flexible Temporal Table Syntax,
+ // this can be revert once FLINK-16579(Upgrade Calcite version to 1.23) resolved.
+ val relBuilder = config.getRelBuilderFactory.create(cluster, null)
+
+ override def convertFrom(bb: SqlToRelConverter#Blackboard, from: SqlNode): Unit = {
Review comment:
Create a JIRA issue to remove this overriding once we bump up Calcite version. And add comment above this method with the JIRA id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023)
* 78e195f2120b88bff90da918c1a5a0ae5327285f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13289:
URL: https://github.com/apache/flink/pull/13289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-696662161
The compile is failed, please fix it first.
```
FlinkPlannerImpl.scala message=File line length exceeds 100 characters line=168
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-696662161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683886127
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb (Mon Aug 31 16:27:27 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] danny0405 commented on a change in pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #13289:
URL: https://github.com/apache/flink/pull/13289#discussion_r482002500
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkPlannerImpl.scala
##########
@@ -163,7 +163,35 @@ class FlinkPlannerImpl(
sqlValidator.getCatalogReader.unwrap(classOf[CalciteCatalogReader]),
cluster,
convertletTable,
- sqlToRelConverterConfig)
+ sqlToRelConverterConfig) {
+ // override convertFrom() to support flexible Temporal Table Syntax,
+ // this can be revert once FLINK-16579(Upgrade Calcite version to 1.23) resolved.
+ val relBuilder = config.getRelBuilderFactory.create(cluster, null)
+
Review comment:
`val relBuilder: RelBuilder` to eliminate the IDEA warnings.
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/LookupJoinTest.scala
##########
@@ -489,9 +493,12 @@ class LookupJoinTest(legacyTableSource: Boolean) extends TableTestBase with Seri
}
object LookupJoinTest {
- @Parameterized.Parameters(name = "LegacyTableSource={0}")
+ @Parameterized.Parameters(name = "LegacyTableSource={0}, useComputedColumn={1}")
def parameters(): JCollection[Array[Object]] = {
- Seq[Array[AnyRef]](Array(JBoolean.TRUE), Array(JBoolean.FALSE))
+ Seq[Array[AnyRef]](
Review comment:
No need to add another param `useComputedColumn` i think. Just add new tables and new cases you want to test.
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/LookupJoinITCase.scala
##########
@@ -208,15 +247,19 @@ class LookupJoinITCase(legacyTableSource: Boolean, isAsyncMode: Boolean) extends
@Test
def testLeftJoinTemporalTable(): Unit = {
- val sql = s"SELECT T.id, T.len, D.name, D.age FROM T LEFT JOIN userTable " +
+ if (legacyTableSource) {
+ //Computed column do not support in legacyTableSource.
Review comment:
You can use junit `Assume.assumeTrue()` instead.
PS, can we just create another table with computed column there and add test cases for this patch ? It is not necessary to add another test param which makes the test looks verbose and complex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023)
* 78e195f2120b88bff90da918c1a5a0ae5327285f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
}, {
"hash" : "8788045dfd7023777299e2a4b514711bb4018c98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8788045dfd7023777299e2a4b514711bb4018c98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78e195f2120b88bff90da918c1a5a0ae5327285f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029)
* 8788045dfd7023777299e2a4b514711bb4018c98 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
}, {
"hash" : "8788045dfd7023777299e2a4b514711bb4018c98",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366",
"triggerID" : "8788045dfd7023777299e2a4b514711bb4018c98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78e195f2120b88bff90da918c1a5a0ae5327285f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029)
* 8788045dfd7023777299e2a4b514711bb4018c98 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-689347470
@danny0405 I have addressed your comments, Could you have a more look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
}, {
"hash" : "8788045dfd7023777299e2a4b514711bb4018c98",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366",
"triggerID" : "8788045dfd7023777299e2a4b514711bb4018c98",
"triggerType" : "PUSH"
}, {
"hash" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6769",
"triggerID" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"triggerType" : "PUSH"
}, {
"hash" : "ef462e3d6a961f1d353a84e8ae55982c97c67a8e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6785",
"triggerID" : "ef462e3d6a961f1d353a84e8ae55982c97c67a8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef462e3d6a961f1d353a84e8ae55982c97c67a8e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6785)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
}, {
"hash" : "8788045dfd7023777299e2a4b514711bb4018c98",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366",
"triggerID" : "8788045dfd7023777299e2a4b514711bb4018c98",
"triggerType" : "PUSH"
}, {
"hash" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6769",
"triggerID" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"triggerType" : "PUSH"
}, {
"hash" : "ef462e3d6a961f1d353a84e8ae55982c97c67a8e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ef462e3d6a961f1d353a84e8ae55982c97c67a8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83419c50b7ec6d6a966cc7a325fb11f4263b57dc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6769)
* ef462e3d6a961f1d353a84e8ae55982c97c67a8e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
}, {
"hash" : "8788045dfd7023777299e2a4b514711bb4018c98",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366",
"triggerID" : "8788045dfd7023777299e2a4b514711bb4018c98",
"triggerType" : "PUSH"
}, {
"hash" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6769",
"triggerID" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"triggerType" : "PUSH"
}, {
"hash" : "ef462e3d6a961f1d353a84e8ae55982c97c67a8e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6785",
"triggerID" : "ef462e3d6a961f1d353a84e8ae55982c97c67a8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83419c50b7ec6d6a966cc7a325fb11f4263b57dc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6769)
* ef462e3d6a961f1d353a84e8ae55982c97c67a8e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6785)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-695893187
@danny0405 could you take a look? thanks..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
}, {
"hash" : "8788045dfd7023777299e2a4b514711bb4018c98",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366",
"triggerID" : "8788045dfd7023777299e2a4b514711bb4018c98",
"triggerType" : "PUSH"
}, {
"hash" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8788045dfd7023777299e2a4b514711bb4018c98 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366)
* 83419c50b7ec6d6a966cc7a325fb11f4263b57dc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-697082510
Thanks for the updating @leonardBang .
Will merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78e195f2120b88bff90da918c1a5a0ae5327285f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-697081273
> The compile is failed, please fix it first.
>
> ```
> FlinkPlannerImpl.scala message=File line length exceeds 100 characters line=168
> ```
I've fixed and rebased
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
}, {
"hash" : "8788045dfd7023777299e2a4b514711bb4018c98",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366",
"triggerID" : "8788045dfd7023777299e2a4b514711bb4018c98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8788045dfd7023777299e2a4b514711bb4018c98 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-696079059
cc: @wuchong Could you take a look and help merge? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
}, {
"hash" : "8788045dfd7023777299e2a4b514711bb4018c98",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366",
"triggerID" : "8788045dfd7023777299e2a4b514711bb4018c98",
"triggerType" : "PUSH"
}, {
"hash" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6769",
"triggerID" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83419c50b7ec6d6a966cc7a325fb11f4263b57dc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6769)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13289:
URL: https://github.com/apache/flink/pull/13289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6023",
"triggerID" : "0ab49320f3f6b4ea1f2bd4539dd5dc64d98c4dbb",
"triggerType" : "PUSH"
}, {
"hash" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6029",
"triggerID" : "78e195f2120b88bff90da918c1a5a0ae5327285f",
"triggerType" : "PUSH"
}, {
"hash" : "8788045dfd7023777299e2a4b514711bb4018c98",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366",
"triggerID" : "8788045dfd7023777299e2a4b514711bb4018c98",
"triggerType" : "PUSH"
}, {
"hash" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6769",
"triggerID" : "83419c50b7ec6d6a966cc7a325fb11f4263b57dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8788045dfd7023777299e2a4b514711bb4018c98 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6366)
* 83419c50b7ec6d6a966cc7a325fb11f4263b57dc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6769)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13289:
URL: https://github.com/apache/flink/pull/13289#discussion_r492517117
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkPlannerImpl.scala
##########
@@ -163,7 +163,35 @@ class FlinkPlannerImpl(
sqlValidator.getCatalogReader.unwrap(classOf[CalciteCatalogReader]),
cluster,
convertletTable,
- sqlToRelConverterConfig)
+ sqlToRelConverterConfig) {
+ // override convertFrom() to support flexible Temporal Table Syntax,
+ // this can be revert once FLINK-16579(Upgrade Calcite version to 1.23) resolved.
+ val relBuilder = config.getRelBuilderFactory.create(cluster, null)
+
+ override def convertFrom(bb: SqlToRelConverter#Blackboard, from: SqlNode): Unit = {
Review comment:
Create a JIRA issue to remove this overriding once we bump up Calcite version. And add comment above this method with the JIRA id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13289:
URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org