You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/15 13:00:40 UTC
[GitHub] [camel-k] dmvolod opened a new pull request #1767: Fix build issue with openshift API version in go.mod
dmvolod opened a new pull request #1767:
URL: https://github.com/apache/camel-k/pull/1767
**Release Note**
This changes in go.mod fix `github.com/openshift/api@v3.9.1-0.20190927182313-d4a64ec2cbd8+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found` on download and build go modules
```release-note
NONE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #1767: Fix build issue with openshift API version in go.mod
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #1767:
URL: https://github.com/apache/camel-k/pull/1767#discussion_r505663853
##########
File path: go.mod
##########
@@ -61,6 +61,8 @@ replace github.com/docker/docker => github.com/moby/moby v0.7.3-0.20190826074503
// Using a fork that removes the https ping before using http in case of insecure registry (for Spectrum)
replace github.com/google/go-containerregistry => github.com/nicolaferraro/go-containerregistry v0.0.0-20200428072705-e7aced86aca8
+replace github.com/openshift/api => github.com/openshift/api v0.0.0-20190927182313-d4a64ec2cbd8
Review comment:
@dmvolod I mean changing:
```
github.com/openshift/api v3.9.1-0.20190927182313-d4a64ec2cbd8+incompatible
```
directly with:
```
github.com/openshift/api v0.0.0-20190927182313-d4a64ec2cbd8
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] dmvolod commented on a change in pull request #1767: Fix build issue with openshift API version in go.mod
Posted by GitBox <gi...@apache.org>.
dmvolod commented on a change in pull request #1767:
URL: https://github.com/apache/camel-k/pull/1767#discussion_r505661548
##########
File path: go.mod
##########
@@ -61,6 +61,8 @@ replace github.com/docker/docker => github.com/moby/moby v0.7.3-0.20190826074503
// Using a fork that removes the https ping before using http in case of insecure registry (for Spectrum)
replace github.com/google/go-containerregistry => github.com/nicolaferraro/go-containerregistry v0.0.0-20200428072705-e7aced86aca8
+replace github.com/openshift/api => github.com/openshift/api v0.0.0-20190927182313-d4a64ec2cbd8
Review comment:
@astefanutti it can't be add to the required section as I didn't change an openshift api version, just fix it for correct download
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] dmvolod commented on a change in pull request #1767: Fix build issue with openshift API version in go.mod
Posted by GitBox <gi...@apache.org>.
dmvolod commented on a change in pull request #1767:
URL: https://github.com/apache/camel-k/pull/1767#discussion_r505696634
##########
File path: go.mod
##########
@@ -61,6 +61,8 @@ replace github.com/docker/docker => github.com/moby/moby v0.7.3-0.20190826074503
// Using a fork that removes the https ping before using http in case of insecure registry (for Spectrum)
replace github.com/google/go-containerregistry => github.com/nicolaferraro/go-containerregistry v0.0.0-20200428072705-e7aced86aca8
+replace github.com/openshift/api => github.com/openshift/api v0.0.0-20190927182313-d4a64ec2cbd8
Review comment:
@astefanutti it seams to be not compiled anymore after recommended changes. Let's keep current solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] dmvolod commented on pull request #1767: Fix build issue with openshift API version in go.mod
Posted by GitBox <gi...@apache.org>.
dmvolod commented on pull request #1767:
URL: https://github.com/apache/camel-k/pull/1767#issuecomment-791934353
Closing as no more feedback for a long time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] dmvolod commented on pull request #1767: Fix build issue with openshift API version in go.mod
Posted by GitBox <gi...@apache.org>.
dmvolod commented on pull request #1767:
URL: https://github.com/apache/camel-k/pull/1767#issuecomment-767579317
@nicolaferraro , @lburgazzoli could you please a look, seems to be compile from scratch (without initial vendor folder) cause this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] dmvolod commented on a change in pull request #1767: Fix build issue with openshift API version in go.mod
Posted by GitBox <gi...@apache.org>.
dmvolod commented on a change in pull request #1767:
URL: https://github.com/apache/camel-k/pull/1767#discussion_r505670722
##########
File path: go.mod
##########
@@ -61,6 +61,8 @@ replace github.com/docker/docker => github.com/moby/moby v0.7.3-0.20190826074503
// Using a fork that removes the https ping before using http in case of insecure registry (for Spectrum)
replace github.com/google/go-containerregistry => github.com/nicolaferraro/go-containerregistry v0.0.0-20200428072705-e7aced86aca8
+replace github.com/openshift/api => github.com/openshift/api v0.0.0-20190927182313-d4a64ec2cbd8
Review comment:
Oh, thanks, will try to change as you suggested
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #1767: Fix build issue with openshift API version in go.mod
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #1767:
URL: https://github.com/apache/camel-k/pull/1767#discussion_r505545662
##########
File path: go.mod
##########
@@ -61,6 +61,8 @@ replace github.com/docker/docker => github.com/moby/moby v0.7.3-0.20190826074503
// Using a fork that removes the https ping before using http in case of insecure registry (for Spectrum)
replace github.com/google/go-containerregistry => github.com/nicolaferraro/go-containerregistry v0.0.0-20200428072705-e7aced86aca8
+replace github.com/openshift/api => github.com/openshift/api v0.0.0-20190927182313-d4a64ec2cbd8
Review comment:
Could you also add a comment that mentions the OpenShift version that commit relates?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] dmvolod closed pull request #1767: Fix build issue with openshift API version in go.mod
Posted by GitBox <gi...@apache.org>.
dmvolod closed pull request #1767:
URL: https://github.com/apache/camel-k/pull/1767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #1767: Fix build issue with openshift API version in go.mod
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #1767:
URL: https://github.com/apache/camel-k/pull/1767#discussion_r505544664
##########
File path: go.mod
##########
@@ -61,6 +61,8 @@ replace github.com/docker/docker => github.com/moby/moby v0.7.3-0.20190826074503
// Using a fork that removes the https ping before using http in case of insecure registry (for Spectrum)
replace github.com/google/go-containerregistry => github.com/nicolaferraro/go-containerregistry v0.0.0-20200428072705-e7aced86aca8
+replace github.com/openshift/api => github.com/openshift/api v0.0.0-20190927182313-d4a64ec2cbd8
Review comment:
Can it be set directly in the require section, rather than via a `replace` statement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org