You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/27 04:18:55 UTC

[GitHub] [spark] c21 commented on pull request #31948: [SPARK-34848][CORE] Add duration to TaskMetricDistributions

c21 commented on pull request #31948:
URL: https://github.com/apache/spark/pull/31948#issuecomment-808647121


   It seems that [unit test`stage with summaries` in `HistoryServerSuite.scala`](https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala#L184) starts failing after this PR. Shall we update [stage_with_summaries_expectation.json](https://github.com/apache/spark/blob/master/core/src/test/resources/HistoryServerExpectations/stage_with_summaries_expectation.json) as well? cc @srowen , thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org