You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vectorijk <gi...@git.apache.org> on 2016/06/27 07:57:03 UTC
[GitHub] spark pull request #13922: [SPARK-11938][PySpark] Expose numFeatures in all ...
GitHub user vectorijk opened a pull request:
https://github.com/apache/spark/pull/13922
[SPARK-11938][PySpark] Expose numFeatures in all ML PredictionModel for PySpark
## What changes were proposed in this pull request?
JIRA: [https://issues.apache.org/jira/browse/SPARK-11938](https://issues.apache.org/jira/browse/SPARK-11938)
[SPARK-9715](https://issues.apache.org/jira/browse/SPARK-9715) provided support for numFeatures in all ML `PredictionModel`s, we should also expose it at PySpark.
## How was this patch tested?
Unit Test for PySpark
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vectorijk/spark spark-11938
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13922.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13922
----
commit 8f2e5c67b7adc6f5a0ae853837ebb516967bca6c
Author: lewuathe <le...@me.com>
Date: 2016-04-01T14:29:53Z
[SPARK-11938] Expose numFeatures in all ML PredictionModel for PySpark
Aggregate numFeatures property in HasNumFeaturesModel in base.py.
commit 461b7c64a274a745f88f8eeb0d9c39470c7aa958
Author: lewuathe <le...@me.com>
Date: 2016-04-02T02:16:33Z
[SPARK-11938] Fix style
commit 872d384be9710eb5fd5c381ac4dd9eb7e40fa00a
Author: Kai Jiang <ji...@gmail.com>
Date: 2016-06-27T07:50:14Z
export numFeatures in ML PredictionModel
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13922: [SPARK-11938][PySpark] Expose numFeatures in all ML Pred...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13922
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13922: [SPARK-11938][PySpark] Expose numFeatures in all ML Pred...
Posted by vectorijk <gi...@git.apache.org>.
Github user vectorijk commented on the issue:
https://github.com/apache/spark/pull/13922
cc @jkbradley @yanboliang @Lewuathe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13922: [SPARK-11938][PySpark] Expose numFeatures in all ML Pred...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/13922
@vectorijk this is covered in #12889 by @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13922: [SPARK-11938][PySpark] Expose numFeatures in all ML Pred...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13922
**[Test build #61295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61295/consoleFull)** for PR 13922 at commit [`872d384`](https://github.com/apache/spark/commit/872d384be9710eb5fd5c381ac4dd9eb7e40fa00a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13922: [SPARK-11938][PySpark] Expose numFeatures in all ML Pred...
Posted by lins05 <gi...@git.apache.org>.
Github user lins05 commented on the issue:
https://github.com/apache/spark/pull/13922
Seems the `numFeatures` property is repeated in all these classification and regression classes. What about adding a `HasNumFeatures` mixin class and move the `numFeatures` property implementation there?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13922: [SPARK-11938][PySpark] Expose numFeatures in all ML Pred...
Posted by vectorijk <gi...@git.apache.org>.
Github user vectorijk commented on the issue:
https://github.com/apache/spark/pull/13922
@MLnick Thanks! I will close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13922: [SPARK-11938][PySpark] Expose numFeatures in all ...
Posted by vectorijk <gi...@git.apache.org>.
Github user vectorijk closed the pull request at:
https://github.com/apache/spark/pull/13922
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13922: [SPARK-11938][PySpark] Expose numFeatures in all ML Pred...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13922
**[Test build #61295 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61295/consoleFull)** for PR 13922 at commit [`872d384`](https://github.com/apache/spark/commit/872d384be9710eb5fd5c381ac4dd9eb7e40fa00a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class LogisticRegressionModel(JavaModel, JavaMLWritable, JavaMLReadable):`
* `class DecisionTreeClassificationModel(DecisionTreeModel, JavaMLWritable, JavaMLReadable):`
* `class RandomForestClassificationModel(TreeEnsembleModels, JavaMLWritable, JavaMLReadable):`
* `class GBTClassificationModel(TreeEnsembleModels, JavaMLWritable, JavaMLReadable):`
* `class NaiveBayesModel(JavaModel, JavaMLWritable, JavaMLReadable):`
* `class MultilayerPerceptronClassificationModel(JavaModel, JavaMLWritable, JavaMLReadable):`
* `class LinearRegressionModel(JavaModel, JavaMLWritable, JavaMLReadable):`
* `class DecisionTreeRegressionModel(DecisionTreeModel, JavaMLWritable, JavaMLReadable):`
* `class RandomForestRegressionModel(TreeEnsembleModels, JavaMLWritable, JavaMLReadable):`
* `class GBTRegressionModel(TreeEnsembleModels, JavaMLWritable, JavaMLReadable):`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13922: [SPARK-11938][PySpark] Expose numFeatures in all ML Pred...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13922
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61295/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org