[GitHub] [spark] srowen commented on a change in pull request #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#discussion_r334513859
 
 

 ##########
 File path: python/pyspark/sql/readwriter.py
 ##########
 @@ -593,7 +593,7 @@ def mode(self, saveMode):
 
         * `append`: Append contents of this :class:`DataFrame` to existing data.
         * `overwrite`: Overwrite existing data.
-        * `error` or `errorifexists`: Throw an exception if data already exists.
+        * `error`, `errorifexists`, `default`: Throw an exception if data already exists.
 
 Review comment:
   Interesting, I had also not heard of a "default" option. I wonder what the use case is, as you would set this at the time of creation anyway. I think it's fine to change the behavior, below, to truly make it the 'default'. If in doubt, let's not mention it in docs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org