You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/06/20 16:05:54 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request, #6477: Fix rpfilter config values from integer to boolean on upgrade path
nvazquez opened a new pull request, #6477:
URL: https://github.com/apache/cloudstack/pull/6477
### Description
This PR updates the config values for `network.disable.rpfilter` and `consoleproxy.disable.rpfilter` to meet the boolean type set on #6380.
Fixes: #6390
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477#issuecomment-1160723289
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477#issuecomment-1164182774
¿ any testing needed @nvazquez ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477#discussion_r902169025
##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -17,4 +17,7 @@
--;
-- Schema upgrade from 4.17.0.0 to 4.17.1.0
---;
\ No newline at end of file
+--;
+
+UPDATE `cloud`.`configuration` set `value` = 'false' where `name` = 'network.disable.rpfilter' and `value` != 'true';
Review Comment:
```suggestion
UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
```
Same for the other update...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477#issuecomment-1161270274
<b>Trillian test result (tid-4343)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37674 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6477-t4343-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477#issuecomment-1164335517
@DaanHoogland I have now included the upgrade testing on the PR description, thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477#issuecomment-1160677382
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477#issuecomment-1160720423
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477#issuecomment-1160677058
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477#issuecomment-1160722766
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6477: Fix rpfilter config values from integer to boolean on upgrade path
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6477:
URL: https://github.com/apache/cloudstack/pull/6477#discussion_r902373424
##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -17,4 +17,7 @@
--;
-- Schema upgrade from 4.17.0.0 to 4.17.1.0
---;
\ No newline at end of file
+--;
+
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
+UPDATE `cloud`.`configuration` set `value` = 'false' where `name` = 'consoleproxy.disable.rpfilter' and `value` != 'true';
Review Comment:
```suggestion
UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org