You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ksowmya <gi...@git.apache.org> on 2015/08/17 13:10:39 UTC

[GitHub] cloudstack pull request: Disablestorage pep8

GitHub user ksowmya opened a pull request:

    https://github.com/apache/cloudstack/pull/703

    Disablestorage pep8

    Fixed pep8 issues in script, most of them for E501 (long lines) with max-line-length set to default
    
    Test Result:
    Test Steps: ... === TestName: test_01_disable_enable_pool_1_host | Status : SUCCESS ===
    ok
    Test Steps: ... === TestName: test_01_disable_enable_pool_2_CLUSTER | Status : SUCCESS ===
    ok
    Test Steps: ... SKIP: No ZONE  storage pools found
    Test Steps: ... === TestName: test_02_vm_operations_on_disabled_pool_1_host | Status : SUCCESS ===
    ok
    Test Steps: ... === TestName: test_02_vm_operations_on_disabled_pool_2_CLUSTER | Status : SUCCESS ===
    ok
    Test Steps: ... SKIP: No ZONE wide storage pools found
    Test Steps: ... === TestName: test_01_cross_cluster_attach_disk | Status : SUCCESS ===
    ok


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ksowmya/cloudstack-1 disablestorage_pep8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/703.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #703
    
----
commit 2a0eaaebd301c623879384801261c39ea73da305
Author: Sowmya Krishnan <so...@citrix.com>
Date:   2015-08-17T10:52:54Z

    CLOUDSTACK-8738: Added the two methods for enable and cancel maintenance mode on StoragePool

commit 8bd1ca14ce3f7ea567f50662f2894c6bb4e2e326
Author: Sowmya Krishnan <so...@citrix.com>
Date:   2015-08-17T11:27:33Z

    Fixed pep8 issues

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Disablestorage pep8

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/703#issuecomment-132145192
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Disablestorage pep8

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/703


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Disablestorage pep8

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/703#issuecomment-131792278
  
    Hi @ksowmya Thanks for the PR! It seems this one contains the same commit (2a0eaaebd301c623879384801261c39ea73da305) as in PR #702? Could you please close that one and update the title of this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Disablestorage pep8

Posted by ksowmya <gi...@git.apache.org>.
Github user ksowmya commented on the pull request:

    https://github.com/apache/cloudstack/pull/703#issuecomment-131794674
  
    @remibergsma , Thanks! I've updated this one to include both commits.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Disablestorage pep8

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/703#issuecomment-132234105
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---