You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/25 21:20:04 UTC
[GitHub] john-bodley opened a new pull request #5086: [get_df] Adding
support for multi-statement SQL
john-bodley opened a new pull request #5086: [get_df] Adding support for multi-statement SQL
URL: https://github.com/apache/incubator-superset/pull/5086
@mistercrunch sorry I previously reverted #5060 as it didn't handle the case of statements including the `;` character as part of a filter etc. Previously I was ignorantly splitting on the `;` character, whereas in this PR I use the `sqlparse` stdlib to parse the raw SQL which correctly identifies the statement(s).
to: @betodealmeida @GabeLoins @michellethomas @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org